Try fix flake in OTLP logs tests#8508
Merged
andrewlock merged 2 commits intomasterfrom Apr 28, 2026
Merged
Conversation
Contributor
Snapshots difference summaryThe following differences have been observed in committed snapshots. It is meant to help the reviewer. 1 occurrences of : + {
+ "time_unix_nano": "0",
+ "severity_number": "SEVERITY_NUMBER_INFO",
+ "severity_text": "Information",
+ "body": {
+ "string_value": "Hello from OpenTelemetry logger outside span context"
+ },
+ "observed_time_unix_nano": "0"
+ },
1 occurrences of : + {
+ "time_unix_nano": "0",
+ "severity_number": "SEVERITY_NUMBER_FATAL",
+ "severity_text": "Critical",
+ "body": {
+ "string_value": "This is a critical message"
+ },
+ "observed_time_unix_nano": "0"
+ },
1 occurrences of : - },
- {
- "time_unix_nano": "0",
- "severity_number": "SEVERITY_NUMBER_INFO",
- "severity_text": "Information",
- "body": {
- "string_value": "Hello from OpenTelemetry logger outside span context"
- },
- "observed_time_unix_nano": "0"
- },
- {
- "time_unix_nano": "0",
- "severity_number": "SEVERITY_NUMBER_FATAL",
- "severity_text": "Critical",
- "body": {
- "string_value": "This is a critical message"
- },
- "observed_time_unix_nano": "0"
1 occurrences of : - "severity_number": "SEVERITY_NUMBER_INFO",
- "severity_text": "Information",
+ "severity_number": "SEVERITY_NUMBER_DEBUG",
+ "severity_text": "Debug",
[...]
- "string_value": "Response from other library"
+ "string_value": "Debug information from other library"
1 occurrences of : - "severity_number": "SEVERITY_NUMBER_DEBUG",
- "severity_text": "Debug",
+ "severity_number": "SEVERITY_NUMBER_INFO",
+ "severity_text": "Information",
[...]
- "string_value": "Debug information from other library"
+ "string_value": "Response from other library"
|
BenchmarksBenchmark execution time: 2026-04-23 11:47:48 Comparing candidate commit b4b2abd in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics, 61 known flaky benchmarks, 26 flaky benchmarks without significant changes.
|
andrewlock
commented
Apr 23, 2026
Member
Author
There was a problem hiding this comment.
The changes here are just re-ordering the logs to be in body.string_value order
andrewlock
changed the title
NachoEchevarria
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Try to fix flake in OTLP logs test
Reason for change
The test was flaking, because it was sending logs in multiple batches.
Implementation details
Collapse the log groups into one, and sort them to make sure the order is deterministic
Test coverage
It passes locally, hopefully CI is good too...
Other details
Follow on from #8488