Migrate remaining integration tests to CombinatorialOrPairwiseData - #8528
Migrate remaining integration tests to CombinatorialOrPairwiseData#8528bouwkast wants to merge 20 commits into
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
BenchmarksBenchmark execution time: 2026-07-29 15:12:24 Comparing candidate commit 52c3887 in PR branch Found 1 performance improvements and 1 performance regressions! Performance is the same for 70 metrics, 0 unstable metrics, 61 known flaky benchmarks, 65 flaky benchmarks without significant changes.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8528) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8528) - mean (73ms) : 70, 77
master - mean (72ms) : 69, 75
section Bailout
This PR (8528) - mean (75ms) : 72, 78
master - mean (78ms) : 75, 82
section CallTarget+Inlining+NGEN
This PR (8528) - mean (1,089ms) : 1034, 1144
master - mean (1,090ms) : 1044, 1135
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8528) - mean (111ms) : 104, 118
master - mean (114ms) : 108, 120
section Bailout
This PR (8528) - mean (110ms) : 108, 112
master - mean (113ms) : 108, 118
section CallTarget+Inlining+NGEN
This PR (8528) - mean (785ms) : 764, 806
master - mean (786ms) : 766, 805
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8528) - mean (98ms) : 95, 101
master - mean (98ms) : 95, 102
section Bailout
This PR (8528) - mean (98ms) : 96, 100
master - mean (99ms) : 97, 102
section CallTarget+Inlining+NGEN
This PR (8528) - mean (940ms) : 904, 977
master - mean (949ms) : 915, 982
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8528) - mean (99ms) : 93, 106
master - mean (101ms) : 96, 106
section Bailout
This PR (8528) - mean (99ms) : 94, 105
master - mean (99ms) : 95, 104
section CallTarget+Inlining+NGEN
This PR (8528) - mean (819ms) : 784, 854
master - mean (830ms) : 787, 872
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8528) - mean (216ms) : 209, 223
master - mean (205ms) : 200, 211
section Bailout
This PR (8528) - mean (221ms) : 216, 226
master - mean (210ms) : 205, 215
section CallTarget+Inlining+NGEN
This PR (8528) - mean (1,303ms) : 1258, 1347
master - mean (1,240ms) : 1194, 1286
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8528) - mean (313ms) : 303, 322
master - mean (293ms) : 285, 301
section Bailout
This PR (8528) - mean (312ms) : crit, 304, 320
master - mean (294ms) : 288, 301
section CallTarget+Inlining+NGEN
This PR (8528) - mean (1,028ms) : 1010, 1047
master - mean (984ms) : 958, 1010
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8528) - mean (306ms) : 296, 316
master - mean (289ms) : 284, 294
section Bailout
This PR (8528) - mean (308ms) : crit, 298, 317
master - mean (291ms) : 287, 296
section CallTarget+Inlining+NGEN
This PR (8528) - mean (1,215ms) : 1175, 1255
master - mean (1,180ms) : 1144, 1216
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8528) - mean (306ms) : 294, 317
master - mean (286ms) : 280, 291
section Bailout
This PR (8528) - mean (307ms) : crit, 299, 316
master - mean (288ms) : 283, 293
section CallTarget+Inlining+NGEN
This PR (8528) - mean (1,127ms) : 1021, 1232
master - mean (1,062ms) : 989, 1135
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
04125b8 to
17e53b9
Compare
17e53b9 to
68e0763
Compare
68e0763 to
52c3887
Compare
Summary of changes
Migrates (what I think are) the remaining integration tests to use CombinatorialOrPairwiseData with the goal of speeding up PR CI runs with the hope of not missing regressions
Reason for change
As we have many tests our CI takes time running them, this aims to reduce some pressure as if a PR meets the criteria for running in Pairwise mode we will swap from combinatorial to pairwise for all of these integrations tests.
This will hopefully reduce times for runs that likely won't modify / impact these tests.
Implementation details
One commit per file with the following pattern(s):
GetEnabledConfig()and the matching[MemberData(...)][CombinatorialOrPairwiseData][PackageVersionData(nameof(PackageVersions.X))]and[MetadataSchemaVersionData]Note that some tests needed a few more changes.
Test coverage
Less!
Same though on non-PR runs or on PR runs that end up on the thorough testing.
Other details
I have a planned follow up to reduce the V1 Schema tests that are run in general (the V0/V1 split causes most tests to be doubled for no real benefit as the move to the V1 schema has largely been replaced)