Migrate remaining integration tests to CombinatorialOrPairwiseData#8528
Migrate remaining integration tests to CombinatorialOrPairwiseData#8528bouwkast wants to merge 20 commits into
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
BenchmarksBenchmark execution time: 2026-05-14 14:17:47 Comparing candidate commit 17e53b9 in PR branch Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥 Scenarios present only in baseline:
Found 4 performance improvements and 3 performance regressions! Performance is the same for 49 metrics, 16 unstable metrics, 90 known flaky benchmarks, 36 flaky benchmarks without significant changes.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8528) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8528) - mean (73ms) : 70, 76
master - mean (73ms) : 71, 75
section Bailout
This PR (8528) - mean (77ms) : 75, 80
master - mean (77ms) : 75, 79
section CallTarget+Inlining+NGEN
This PR (8528) - mean (1,088ms) : 1035, 1140
master - mean (1,082ms) : 1039, 1125
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8528) - mean (115ms) : 111, 119
master - mean (114ms) : 109, 118
section Bailout
This PR (8528) - mean (119ms) : 113, 126
master - mean (116ms) : 111, 122
section CallTarget+Inlining+NGEN
This PR (8528) - mean (783ms) : 757, 810
master - mean (786ms) : 760, 811
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8528) - mean (101ms) : 97, 106
master - mean (102ms) : 98, 105
section Bailout
This PR (8528) - mean (106ms) : 99, 113
master - mean (106ms) : 99, 113
section CallTarget+Inlining+NGEN
This PR (8528) - mean (943ms) : 910, 977
master - mean (941ms) : 904, 977
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8528) - mean (101ms) : 97, 105
master - mean (100ms) : 97, 104
section Bailout
This PR (8528) - mean (102ms) : 99, 104
master - mean (101ms) : 98, 104
section CallTarget+Inlining+NGEN
This PR (8528) - mean (825ms) : 788, 861
master - mean (826ms) : 787, 866
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8528) - mean (204ms) : 196, 211
master - mean (204ms) : 194, 214
section Bailout
This PR (8528) - mean (208ms) : 202, 214
master - mean (208ms) : 198, 217
section CallTarget+Inlining+NGEN
This PR (8528) - mean (1,206ms) : 1149, 1263
master - mean (1,212ms) : 1167, 1256
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8528) - mean (290ms) : 281, 299
master - mean (290ms) : 278, 302
section Bailout
This PR (8528) - mean (291ms) : 281, 300
master - mean (294ms) : 278, 310
section CallTarget+Inlining+NGEN
This PR (8528) - mean (959ms) : 932, 986
master - mean (961ms) : 931, 992
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8528) - mean (289ms) : 278, 299
master - mean (287ms) : 272, 302
section Bailout
This PR (8528) - mean (287ms) : 274, 301
master - mean (288ms) : 270, 305
section CallTarget+Inlining+NGEN
This PR (8528) - mean (1,154ms) : 1110, 1198
master - mean (1,162ms) : 1117, 1207
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8528) - mean (291ms) : 282, 301
master - mean (285ms) : 272, 298
section Bailout
This PR (8528) - mean (292ms) : 281, 302
master - mean (288ms) : 272, 304
section CallTarget+Inlining+NGEN
This PR (8528) - mean (1,047ms) : 995, 1098
master - mean (1,050ms) : 981, 1119
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
04125b8 to
17e53b9
Compare
Summary of changes
Migrates (what I think are) the remaining integration tests to use CombinatorialOrPairwiseData with the goal of speeding up PR CI runs with the hope of not missing regressions
Reason for change
As we have many tests our CI takes time running them, this aims to reduce some pressure as if a PR meets the criteria for running in Pairwise mode we will swap from combinatorial to pairwise for all of these integrations tests.
This will hopefully reduce times for runs that likely won't modify / impact these tests.
Implementation details
One commit per file with the following pattern(s):
GetEnabledConfig()and the matching[MemberData(...)][CombinatorialOrPairwiseData][PackageVersionData(nameof(PackageVersions.X))]and[MetadataSchemaVersionData]Note that some tests needed a few more changes.
Test coverage
Less!
Same though on non-PR runs or on PR runs that end up on the thorough testing.
Other details
I have a planned follow up to reduce the V1 Schema tests that are run in general (the V0/V1 split causes most tests to be doubled for no real benefit as the move to the V1 schema has largely been replaced)