[SLES-2826] Reproducing AAS Restart Named Pipe Overlap Issue with Logs [Do Not Merge]#8632
Draft
Lewis-E wants to merge 4 commits into
Draft
[SLES-2826] Reproducing AAS Restart Named Pipe Overlap Issue with Logs [Do Not Merge]#8632Lewis-E wants to merge 4 commits into
Lewis-E wants to merge 4 commits into
Conversation
…ssification Adds [aas-repro]-prefixed Information/Warning logs at every state transition: init (IIS Worker Process PID, AppDomain, pipe names, agent path), per-iteration 7-retry NeverChecked outcomes, the bad path (never_checked_exhausted), steady- state poll signals, spawned child PID + exit code, and SequentialFailures count. Adds NamedPipeIsBoundDiagnostic/GetMatchingProcessesDiagnostic helpers that log on the TRUE branch (production helpers only log FALSE) and emit full PID@StartTime list from Process.GetProcessesByName so orphan agents are visible. For repro only — not for customer release.
- Wrap int args in new object[] on spawned/start_success log calls to resolve CS0121 (int disambiguates as CallerLineNumber otherwise) - Add #pragma warning disable/restore CA1837 around Process.GetCurrentProcess().Id (warnings-as-errors on net6.0)
github-actions
Bot
added
the
area:tracer
Lewis-E
changed the title
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8632) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8632) - mean (74ms) : 69, 79
master - mean (72ms) : 70, 75
section Bailout
This PR (8632) - mean (79ms) : 75, 83
master - mean (78ms) : 74, 83
section CallTarget+Inlining+NGEN
This PR (8632) - mean (1,102ms) : 1053, 1150
master - mean (1,102ms) : 1051, 1152
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8632) - mean (117ms) : 110, 125
master - mean (116ms) : 110, 122
section Bailout
This PR (8632) - mean (115ms) : 111, 119
master - mean (119ms) : 111, 126
section CallTarget+Inlining+NGEN
This PR (8632) - mean (786ms) : 756, 817
master - mean (791ms) : 761, 822
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8632) - mean (105ms) : 99, 111
master - mean (101ms) : 98, 104
section Bailout
This PR (8632) - mean (103ms) : 99, 107
master - mean (105ms) : 99, 110
section CallTarget+Inlining+NGEN
This PR (8632) - mean (944ms) : 909, 978
master - mean (945ms) : 902, 989
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8632) - mean (101ms) : 97, 106
master - mean (101ms) : 95, 107
section Bailout
This PR (8632) - mean (104ms) : 99, 108
master - mean (100ms) : 98, 102
section CallTarget+Inlining+NGEN
This PR (8632) - mean (821ms) : 783, 859
master - mean (825ms) : 786, 863
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8632) - mean (199ms) : 193, 204
master - mean (200ms) : 195, 204
section Bailout
This PR (8632) - mean (203ms) : 198, 208
master - mean (204ms) : 200, 208
section CallTarget+Inlining+NGEN
This PR (8632) - mean (1,204ms) : 1150, 1258
master - mean (1,196ms) : 1154, 1238
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8632) - mean (288ms) : 281, 296
master - mean (287ms) : 280, 295
section Bailout
This PR (8632) - mean (290ms) : 282, 298
master - mean (288ms) : 283, 293
section CallTarget+Inlining+NGEN
This PR (8632) - mean (965ms) : 946, 984
master - mean (959ms) : 943, 976
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8632) - mean (281ms) : 275, 287
master - mean (279ms) : 274, 284
section Bailout
This PR (8632) - mean (280ms) : 274, 285
master - mean (278ms) : 272, 284
section CallTarget+Inlining+NGEN
This PR (8632) - mean (1,155ms) : 1115, 1195
master - mean (1,157ms) : 1115, 1198
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8632) - mean (278ms) : 273, 284
master - mean (276ms) : 269, 284
section Bailout
This PR (8632) - mean (279ms) : 271, 287
master - mean (276ms) : 270, 282
section CallTarget+Inlining+NGEN
This PR (8632) - mean (1,039ms) : 990, 1089
master - mean (1,037ms) : 988, 1086
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
When the IIS Worker Process exits, the OS closes its handles, the job object's refcount drops to zero, and Windows kills datadog-trace-agent.exe and dogstatsd.exe automatically. Prevents the orphan failure mode where the agent survives its parent and holds the named pipe indefinitely, locking new IIS Worker Processes out of starting their own agents. Logs [aas-repro] job_object_create and job_object_assign so the behavior is observable in the live repro and in production. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
BenchmarksBenchmark execution time: 2026-05-15 18:13:37 Comparing candidate commit b88ca09 in PR branch Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥 Scenarios present only in baseline:
Found 4 performance improvements and 4 performance regressions! Performance is the same for 47 metrics, 17 unstable metrics, 88 known flaky benchmarks, 38 flaky benchmarks without significant changes.
|
Explicit [aas-repro]-tagged logs for the MaxFailures terminal state and keep-alive task exit. Lets us grep for these signatures in H&R Block-style incident logs to confirm or rule out the MaxFailures hypothesis. Also threads the most-recent spawn exit code through ProcessMetadata so sequential_failure and keep_alive_terminating include it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds [aas-repro]-prefixed Information/Warning logs at every state transition:
init (IIS Worker Process PID, AppDomain, pipe names, agent path), per-iteration
7-retry NeverChecked outcomes, the bad path (never_checked_exhausted), steady-
state poll signals, spawned child PID + exit code, and SequentialFailures count.
Adds NamedPipeIsBoundDiagnostic/GetMatchingProcessesDiagnostic helpers that log
on the TRUE branch (production helpers only log FALSE) and emit full
PID@StartTime list from Process.GetProcessesByName so orphan agents are visible.
For repro only — not for customer release.## Summary of changes
Reason for change
Implementation details
Test coverage
Other details