Add EventBridge DSM producer injection#8639
Open
jeastham1993 wants to merge 1 commit into
Open
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5634ae9a25
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
BenchmarksBenchmark execution time: 2026-05-14 17:39:20 Comparing candidate commit 5634ae9 in PR branch Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥 Scenarios present only in baseline:
Found 3 performance improvements and 2 performance regressions! Performance is the same for 50 metrics, 17 unstable metrics, 89 known flaky benchmarks, 37 flaky benchmarks without significant changes.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8639) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8639) - mean (75ms) : 71, 79
master - mean (73ms) : 70, 75
section Bailout
This PR (8639) - mean (78ms) : 74, 81
master - mean (79ms) : 75, 83
section CallTarget+Inlining+NGEN
This PR (8639) - mean (1,107ms) : 1044, 1170
master - mean (1,104ms) : 1056, 1153
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8639) - mean (115ms) : 107, 122
master - mean (113ms) : 109, 117
section Bailout
This PR (8639) - mean (114ms) : 111, 117
master - mean (118ms) : 113, 124
section CallTarget+Inlining+NGEN
This PR (8639) - mean (791ms) : 758, 824
master - mean (787ms) : 759, 814
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8639) - mean (101ms) : 97, 104
master - mean (102ms) : 98, 106
section Bailout
This PR (8639) - mean (101ms) : 99, 104
master - mean (106ms) : 100, 111
section CallTarget+Inlining+NGEN
This PR (8639) - mean (949ms) : 910, 988
master - mean (946ms) : 907, 986
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8639) - mean (103ms) : 98, 108
master - mean (99ms) : 95, 103
section Bailout
This PR (8639) - mean (101ms) : 97, 105
master - mean (103ms) : 98, 108
section CallTarget+Inlining+NGEN
This PR (8639) - mean (823ms) : 782, 864
master - mean (822ms) : 788, 856
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8639) - mean (200ms) : 194, 206
master - mean (202ms) : 194, 210
section Bailout
This PR (8639) - mean (203ms) : 197, 208
master - mean (206ms) : 198, 213
section CallTarget+Inlining+NGEN
This PR (8639) - mean (1,204ms) : 1142, 1266
master - mean (1,205ms) : 1159, 1251
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8639) - mean (288ms) : 278, 298
master - mean (288ms) : 281, 295
section Bailout
This PR (8639) - mean (287ms) : 281, 294
master - mean (290ms) : 283, 296
section CallTarget+Inlining+NGEN
This PR (8639) - mean (961ms) : 941, 980
master - mean (967ms) : 941, 992
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8639) - mean (282ms) : 274, 289
master - mean (281ms) : 275, 287
section Bailout
This PR (8639) - mean (282ms) : 275, 289
master - mean (280ms) : 275, 285
section CallTarget+Inlining+NGEN
This PR (8639) - mean (1,158ms) : 1112, 1205
master - mean (1,163ms) : 1117, 1208
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8639) - mean (278ms) : 272, 283
master - mean (281ms) : 274, 289
section Bailout
This PR (8639) - mean (279ms) : 273, 285
master - mean (282ms) : 275, 288
section CallTarget+Inlining+NGEN
This PR (8639) - mean (1,040ms) : 998, 1083
master - mean (1,041ms) : 997, 1085
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Update the Amazon EventBridge context propagation to support data streams monitoring injection.
Reason for change
Other AWS messaging technologies (SNS/SQS/Kinesis) support DSM, extending support into the full suite of AWS services.
Implementation details
The core change is in ContextPropagation.cs (line 28): each PutEvents entry now creates a produce checkpoint when an EventBusName is available, then injects dd-pathway-ctx-base64 into the existing _datadog JSON alongside the trace headers.
Test coverage
Tests added to ContextPropagationTests.cs to verify the header is injected and is base-64 decodable.
Other details