Bump DatadogTestCollector and DatadogTestLogger to 0.0.55 - #8949
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 25b5ff4d4d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <ItemGroup Condition=" $(DD_LOGGER_ENABLED) != 'false' "> | ||
| <PackageReference Include="DatadogTestCollector" Version="0.0.54" ExcludeAssets="compile"/> | ||
| <PackageReference Include="DatadogTestLogger" Version="0.0.54" ExcludeAssets="compile"/> | ||
| <PackageReference Include="DatadogTestCollector" Version="0.0.55" ExcludeAssets="compile"/> |
There was a problem hiding this comment.
When the Datadog logger is enabled on server builds, the test runner loads tracer/test/test.settings, whose assemblyQualifiedName still requests Datadog.collector, Version=0.0.54.0. After this reference restores the 0.0.55 collector assembly, the in-process coverage collector cannot be resolved under the stale identity, breaking CI coverage collection; update the runsettings version alongside this package bump.
Useful? React with 👍 / 👎.
| <PackageReference Include="DatadogTestCollector" Version="0.0.54" ExcludeAssets="compile"/> | ||
| <PackageReference Include="DatadogTestLogger" Version="0.0.54" ExcludeAssets="compile"/> | ||
| <PackageReference Include="DatadogTestCollector" Version="0.0.55" ExcludeAssets="compile"/> | ||
| <PackageReference Include="DatadogTestLogger" Version="0.0.55" ExcludeAssets="compile"/> |
There was a problem hiding this comment.
With DD_LOGGER_ENABLED unset or enabled, every tracer test project imports this reference, but at this revision none of the configured NuGet or Azure feeds contains DatadogTestLogger 0.0.55: the documented validation restore already fails with NU1102. Consequently normal test restores cannot complete unless callers explicitly disable the logger; publish the package before taking this dependency or retain 0.0.54 until it is available.
Useful? React with 👍 / 👎.
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8949) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8949) - mean (71ms) : 69, 73
master - mean (75ms) : 71, 78
section Bailout
This PR (8949) - mean (75ms) : 74, 77
master - mean (76ms) : 74, 78
section CallTarget+Inlining+NGEN
This PR (8949) - mean (1,095ms) : 1029, 1162
master - mean (1,097ms) : 1034, 1160
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8949) - mean (110ms) : 106, 114
master - mean (111ms) : 105, 118
section Bailout
This PR (8949) - mean (111ms) : 109, 113
master - mean (111ms) : 109, 113
section CallTarget+Inlining+NGEN
This PR (8949) - mean (787ms) : 756, 819
master - mean (788ms) : 756, 819
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8949) - mean (98ms) : 95, 100
master - mean (98ms) : 95, 102
section Bailout
This PR (8949) - mean (99ms) : 97, 101
master - mean (99ms) : 96, 102
section CallTarget+Inlining+NGEN
This PR (8949) - mean (940ms) : 904, 977
master - mean (949ms) : 912, 986
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8949) - mean (101ms) : 95, 107
master - mean (101ms) : 95, 107
section Bailout
This PR (8949) - mean (98ms) : 96, 101
master - mean (99ms) : 94, 104
section CallTarget+Inlining+NGEN
This PR (8949) - mean (822ms) : 785, 858
master - mean (825ms) : 785, 866
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8949) - mean (215ms) : 211, 220
master - mean (214ms) : 208, 219
section Bailout
This PR (8949) - mean (220ms) : 215, 225
master - mean (218ms) : 213, 223
section CallTarget+Inlining+NGEN
This PR (8949) - mean (1,288ms) : 1229, 1348
master - mean (1,270ms) : 1221, 1318
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8949) - mean (309ms) : 301, 317
master - mean (309ms) : 302, 316
section Bailout
This PR (8949) - mean (309ms) : 301, 317
master - mean (309ms) : 303, 315
section CallTarget+Inlining+NGEN
This PR (8949) - mean (1,019ms) : 997, 1040
master - mean (1,024ms) : 1000, 1049
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8949) - mean (302ms) : 295, 308
master - mean (300ms) : 292, 307
section Bailout
This PR (8949) - mean (299ms) : 294, 304
master - mean (302ms) : 295, 309
section CallTarget+Inlining+NGEN
This PR (8949) - mean (1,211ms) : 1159, 1263
master - mean (1,208ms) : 1167, 1249
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8949) - mean (301ms) : 293, 310
master - mean (300ms) : 292, 308
section Bailout
This PR (8949) - mean (302ms) : 294, 310
master - mean (299ms) : 293, 305
section CallTarget+Inlining+NGEN
This PR (8949) - mean (1,102ms) : 1004, 1201
master - mean (1,094ms) : 1002, 1185
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-07-27 19:54:54 Comparing candidate commit 25b5ff4 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 70 metrics, 0 unstable metrics, 58 known flaky benchmarks, 68 flaky benchmarks without significant changes.
|
andrewlock
approved these changes
Jul 28, 2026
andrewlock
enabled auto-merge (squash)
July 28, 2026 08:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Bumps the
DatadogTestCollectorandDatadogTestLoggerpackage references from0.0.54to0.0.55in the tracer and profiler test projects.Reason for change
Consume version
0.0.55of the Datadog test tooling.Implementation details
Test coverage
git diff --checkpasses.dotnet restore tracer/test/Datadog.Trace.TestHelpers/Datadog.Trace.TestHelpers.csproj --disable-parallel --force-evaluatecurrently fails withNU1102becauseDatadogTestLogger 0.0.55was not yet available from the configured NuGet or Azure feeds at validation time.DatadogTestCollector 0.0.55is available.Other details
#incident-57303