Skip to content

Handle duplicate keys in ASM DecodeMap - #8951

Merged
andrewlock merged 3 commits into
masterfrom
andrew/fix-asm-bug
Jul 28, 2026
Merged

Handle duplicate keys in ASM DecodeMap#8951
andrewlock merged 3 commits into
masterfrom
andrew/fix-asm-bug

Conversation

@andrewlock

@andrewlock andrewlock commented Jul 28, 2026

Copy link
Copy Markdown
Member

Summary of changes

Handle duplicate keys being returned by WAF

Reason for change

We saw errors which look like they come from the waf returning duplicate keys, which was causing the dictionary.Add() call to throw

Implementation details

Initially, I was using TryAdd() in .NET Core and Contains() followed by Add() in .NET Framework. but I don't know if it's worth that overhead for what is clearly a rare strange scenario, so switched just to a replace instead.

That said someone from ASM should validate 1. do we Expect duplicate keys coming from the waf here?

  • If not, why did we get them, and how should we handle them?
  • If yes, we will need larger structural changes to handle that (change dictionary to a list of KeyValuePair for example)

Test coverage

Meh

@andrewlock
andrewlock requested a review from a team as a code owner July 28, 2026 10:57
dromanol
dromanol approved these changes Jul 28, 2026
View reviewed changes

@dromanol dromanol left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@pr-commenter

pr-commenter Bot commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-28 13:36:49

Comparing candidate commit cb1ac7f in PR branch andrew/fix-asm-bug with baseline commit fb1bb2e in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 2 performance regressions! Performance is the same for 70 metrics, 0 unstable metrics, 63 known flaky benchmarks, 63 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net472

  • 🟥 throughput [-26778.618op/s; -24125.411op/s] or [-7.542%; -6.795%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net472

  • 🟥 throughput [-4839.785op/s; -4397.829op/s] or [-5.525%; -5.020%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-10784.733op/s; -10214.993op/s] or [-12.787%; -12.112%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • 🟥 throughput [-9658.720op/s; -8260.658op/s] or [-9.821%; -8.399%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+323.983ms; +325.625ms] or [+160.772%; +161.587%]
  • 🟥 throughput [-40.819op/s; -37.186op/s] or [-7.344%; -6.690%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+374.166ms; +378.298ms] or [+295.614%; +298.879%]
  • 🟩 throughput [+97.883op/s; +103.386op/s] or [+12.905%; +13.631%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+397.454ms; +400.825ms] or [+351.732%; +354.715%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+1.308KB; +1.308KB] or [+27.528%; +27.540%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+9.976%; +9.987%]
  • 🟩 execution_time [-16.266ms; -12.091ms] or [-7.597%; -5.647%]
  • 🟩 throughput [+8380.202op/s; +11208.748op/s] or [+6.117%; +8.182%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+27.500%; +27.510%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.307KB; +1.307KB] or [+105.743%; +105.758%]
  • 🟥 throughput [-257464.815op/s; -253591.136op/s] or [-26.288%; -25.893%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+38.557%; +38.566%]
  • 🟩 execution_time [-27.533ms; -22.603ms] or [-12.278%; -10.080%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+105.288%; +105.304%]
  • 🟥 throughput [-150932.152op/s; -134812.513op/s] or [-21.686%; -19.370%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟩 throughput [+8541.626op/s; +11460.269op/s] or [+5.435%; +7.292%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • 🟩 throughput [+9514.046op/s; +12133.437op/s] or [+7.579%; +9.666%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 throughput [+426978.141op/s; +445150.971op/s] or [+14.237%; +14.843%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-18.929ms; -14.598ms] or [-8.725%; -6.729%]
  • 🟩 throughput [+155354.749op/s; +208766.182op/s] or [+6.166%; +8.286%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟥 execution_time [+299.725ms; +300.387ms] or [+149.763%; +150.093%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • 🟥 execution_time [+300.864ms; +304.644ms] or [+151.726%; +153.633%]
  • 🟩 throughput [+714.542op/s; +932.809op/s] or [+5.465%; +7.135%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟥 execution_time [+300.154ms; +302.627ms] or [+151.194%; +152.440%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+296.455ms; +297.488ms] or [+145.607%; +146.114%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+293.125ms; +296.729ms] or [+143.298%; +145.060%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+301.050ms; +302.831ms] or [+150.464%; +151.354%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟥 execution_time [+21.122µs; +44.731µs] or [+6.743%; +14.280%]
  • 🟥 throughput [-418.089op/s; -219.405op/s] or [-13.033%; -6.840%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+300.111ms; +300.948ms] or [+149.786%; +150.204%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • unstable execution_time [+317.185ms; +388.830ms] or [+344.635%; +422.480%]
  • 🟩 throughput [+827.611op/s; +1070.170op/s] or [+6.801%; +8.794%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • unstable execution_time [+298.283ms; +351.424ms] or [+226.483%; +266.833%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 allocated_mem [+2.824KB; +2.829KB] or [+5.017%; +5.026%]
  • unstable execution_time [+339.045ms; +387.283ms] or [+155.890%; +178.069%]
  • 🟥 throughput [-524.810op/s; -482.063op/s] or [-47.553%; -43.680%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [+200.333ms; +333.601ms] or [+85.373%; +142.166%]
  • 🟥 throughput [-673.356op/s; -589.881op/s] or [-44.913%; -39.345%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+341.380ms; +350.294ms] or [+204.185%; +209.516%]
  • 🟥 throughput [-406.800op/s; -367.894op/s] or [-28.325%; -25.616%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1

  • unstable throughput [+7.363op/s; +43.950op/s] or [+2.116%; +12.633%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1

  • unstable execution_time [-217.372µs; -20.014µs] or [-11.645%; -1.072%]
  • unstable throughput [+18.463op/s; +144.309op/s] or [+3.446%; +26.936%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-185.698µs; -144.927µs] or [-9.407%; -7.341%]
  • 🟩 throughput [+41.480op/s; +52.719op/s] or [+8.188%; +10.407%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 execution_time [+302.006ms; +304.031ms] or [+152.084%; +153.104%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 execution_time [+300.991ms; +303.295ms] or [+150.827%; +151.982%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 execution_time [+301.426ms; +304.650ms] or [+151.423%; +153.043%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 execution_time [+301.837ms; +303.785ms] or [+151.572%; +152.551%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • 🟥 execution_time [+298.497ms; +301.262ms] or [+147.593%; +148.961%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+303.575ms; +307.353ms] or [+153.865%; +155.780%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 execution_time [+301.435ms; +303.191ms] or [+151.293%; +152.175%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 execution_time [+298.201ms; +312.247ms] or [+148.626%; +155.627%]
  • 🟩 throughput [+34700.877op/s; +47452.455op/s] or [+6.890%; +9.423%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 execution_time [+301.616ms; +304.795ms] or [+150.052%; +151.633%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • 🟩 execution_time [-16.648ms; -12.959ms] or [-7.741%; -6.026%]
  • 🟩 throughput [+19083.138op/s; +27318.373op/s] or [+5.235%; +7.494%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472

  • unstable execution_time [+18.147µs; +63.384µs] or [+4.482%; +15.656%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-21.000KB; -20.975KB] or [-7.660%; -7.651%]
  • unstable execution_time [-30.714µs; +28.189µs] or [-6.071%; +5.571%]
  • unstable throughput [-97.647op/s; +108.767op/s] or [-4.873%; +5.428%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • unstable execution_time [-64.101µs; -1.988µs] or [-11.108%; -0.345%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • unstable execution_time [+10.375µs; +16.316µs] or [+24.523%; +38.566%]
  • 🟥 throughput [-6470.193op/s; -4385.300op/s] or [-27.237%; -18.461%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-16.249µs; -9.329µs] or [-25.210%; -14.473%]
  • 🟩 throughput [+2433.619op/s; +3896.709op/s] or [+14.931%; +23.908%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+302.652ms; +304.006ms] or [+152.977%; +153.661%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+301.047ms; +303.933ms] or [+153.232%; +154.701%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+301.549ms; +304.443ms] or [+150.963%; +152.412%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • 🟩 throughput [+34066.708op/s; +40869.349op/s] or [+6.448%; +7.736%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+299.928ms; +301.935ms] or [+149.487%; +150.487%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+300.497ms; +301.601ms] or [+150.895%; +151.450%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+302.566ms; +304.663ms] or [+153.442%; +154.506%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+299.921ms; +301.193ms] or [+149.602%; +150.236%]
  • 🟩 throughput [+60225874.297op/s; +61114488.158op/s] or [+43.860%; +44.507%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • 🟥 execution_time [+424.736ms; +429.751ms] or [+528.235%; +534.472%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+299.495ms; +300.505ms] or [+149.381%; +149.885%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟩 throughput [+93190.568op/s; +101530.670op/s] or [+8.701%; +9.480%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • 🟩 throughput [+49809.888op/s; +69181.043op/s] or [+5.765%; +8.008%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • 🟩 throughput [+79508.975op/s; +110090.506op/s] or [+6.154%; +8.521%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • 🟩 throughput [+77754.048op/s; +85280.442op/s] or [+7.722%; +8.470%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 throughput [+56471.747op/s; +61729.875op/s] or [+10.254%; +11.209%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • 🟩 throughput [+23902.735op/s; +33725.678op/s] or [+5.350%; +7.549%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • 🟩 throughput [+51933.927op/s; +75986.172op/s] or [+5.802%; +8.490%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8951) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration73.15 ± (73.16 - 73.71) ms73.44 ± (73.50 - 74.15) ms+0.4%✅⬆️
.NET Framework 4.8 - Bailout
duration74.66 ± (74.65 - 75.02) ms78.33 ± (77.98 - 78.55) ms+4.9%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1082.23 ± (1083.48 - 1089.39) ms1089.03 ± (1089.72 - 1096.48) ms+0.6%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms22.25 ± (22.21 - 22.29) ms22.36 ± (22.31 - 22.41) ms+0.5%✅⬆️
process.time_to_main_ms82.74 ± (82.45 - 83.03) ms84.49 ± (84.16 - 84.82) ms+2.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed11.00 ± (11.00 - 11.01) MB11.01 ± (11.00 - 11.01) MB+0.0%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.03 ± (22.00 - 22.05) ms21.97 ± (21.95 - 22.00) ms-0.2%✅
process.time_to_main_ms82.03 ± (81.88 - 82.18) ms83.29 ± (83.11 - 83.47) ms+1.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed11.05 ± (11.04 - 11.05) MB11.05 ± (11.05 - 11.05) MB+0.0%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms208.72 ± (207.98 - 209.47) ms209.09 ± (208.13 - 210.04) ms+0.2%✅⬆️
process.time_to_main_ms535.91 ± (534.72 - 537.11) ms537.59 ± (536.27 - 538.91) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed49.66 ± (49.64 - 49.69) MB49.60 ± (49.57 - 49.63) MB-0.1%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.2%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms21.08 ± (21.03 - 21.13) ms21.13 ± (21.09 - 21.18) ms+0.3%✅⬆️
process.time_to_main_ms73.57 ± (73.30 - 73.84) ms73.75 ± (73.52 - 73.98) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.72 ± (10.72 - 10.72) MB10.73 ± (10.72 - 10.73) MB+0.0%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms20.76 ± (20.73 - 20.79) ms20.78 ± (20.74 - 20.82) ms+0.1%✅⬆️
process.time_to_main_ms72.32 ± (72.18 - 72.47) ms72.54 ± (72.38 - 72.69) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.84 ± (10.84 - 10.85) MB10.84 ± (10.84 - 10.84) MB-0.0%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms370.15 ± (367.90 - 372.39) ms367.21 ± (364.78 - 369.63) ms-0.8%✅
process.time_to_main_ms544.64 ± (543.41 - 545.87) ms545.58 ± (544.47 - 546.70) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed50.59 ± (50.57 - 50.62) MB50.64 ± (50.62 - 50.66) MB+0.1%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.1%✅
.NET 8 - Baseline
process.internal_duration_ms19.07 ± (19.04 - 19.10) ms19.08 ± (19.05 - 19.11) ms+0.0%✅⬆️
process.time_to_main_ms69.89 ± (69.75 - 70.04) ms70.47 ± (70.32 - 70.62) ms+0.8%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.75 ± (7.75 - 7.76) MB7.77 ± (7.76 - 7.77) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.55 ± (19.49 - 19.61) ms19.34 ± (19.30 - 19.38) ms-1.1%✅
process.time_to_main_ms74.88 ± (74.57 - 75.20) ms74.58 ± (74.34 - 74.81) ms-0.4%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.80 ± (7.80 - 7.80) MB7.83 ± (7.82 - 7.84) MB+0.4%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms296.22 ± (293.74 - 298.70) ms299.02 ± (296.89 - 301.16) ms+0.9%✅⬆️
process.time_to_main_ms495.84 ± (494.70 - 496.99) ms491.57 ± (490.59 - 492.54) ms-0.9%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed38.03 ± (38.00 - 38.06) MB38.10 ± (38.07 - 38.13) MB+0.2%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.8%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration205.73 ± (205.83 - 206.69) ms210.61 ± (210.53 - 211.37) ms+2.4%✅⬆️
.NET Framework 4.8 - Bailout
duration210.46 ± (210.18 - 211.12) ms213.94 ± (213.66 - 214.70) ms+1.7%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1230.24 ± (1232.41 - 1239.84) ms1271.33 ± (1269.19 - 1276.06) ms+3.3%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms200.20 ± (199.76 - 200.64) ms204.09 ± (203.62 - 204.55) ms+1.9%✅⬆️
process.time_to_main_ms88.02 ± (87.69 - 88.35) ms90.18 ± (89.88 - 90.49) ms+2.5%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.10 ± (16.07 - 16.12) MB16.16 ± (16.14 - 16.18) MB+0.4%✅⬆️
runtime.dotnet.threads.count20 ± (19 - 20)20 ± (20 - 20)+1.6%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms198.48 ± (198.08 - 198.89) ms204.62 ± (204.17 - 205.07) ms+3.1%✅⬆️
process.time_to_main_ms88.65 ± (88.41 - 88.88) ms92.35 ± (92.09 - 92.62) ms+4.2%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.18 ± (16.16 - 16.21) MB16.17 ± (16.15 - 16.19) MB-0.1%✅
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)+0.3%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms392.79 ± (391.35 - 394.22) ms397.48 ± (396.09 - 398.86) ms+1.2%✅⬆️
process.time_to_main_ms558.54 ± (557.16 - 559.92) ms567.99 ± (566.62 - 569.36) ms+1.7%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.98 ± (58.76 - 59.20) MB59.71 ± (59.56 - 59.87) MB+1.2%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)+0.4%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms203.95 ± (203.53 - 204.38) ms208.36 ± (207.90 - 208.81) ms+2.2%✅⬆️
process.time_to_main_ms76.41 ± (76.11 - 76.71) ms78.32 ± (78.05 - 78.58) ms+2.5%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.56 ± (16.54 - 16.59) MB16.45 ± (16.43 - 16.47) MB-0.7%✅
runtime.dotnet.threads.count19 ± (19 - 19)20 ± (19 - 20)+1.0%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms203.68 ± (203.25 - 204.12) ms206.83 ± (206.34 - 207.31) ms+1.5%✅⬆️
process.time_to_main_ms77.38 ± (77.15 - 77.61) ms79.13 ± (78.89 - 79.37) ms+2.3%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.59 ± (16.56 - 16.61) MB16.51 ± (16.49 - 16.53) MB-0.5%✅
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 21)+0.7%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms581.19 ± (578.48 - 583.91) ms579.68 ± (577.02 - 582.34) ms-0.3%✅
process.time_to_main_ms570.26 ± (568.94 - 571.59) ms584.01 ± (582.77 - 585.25) ms+2.4%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed61.57 ± (61.49 - 61.64) MB61.51 ± (61.42 - 61.59) MB-0.1%✅
runtime.dotnet.threads.count31 ± (31 - 31)31 ± (31 - 31)-0.2%✅
.NET 8 - Baseline
process.internal_duration_ms203.00 ± (202.55 - 203.46) ms207.83 ± (207.43 - 208.23) ms+2.4%✅⬆️
process.time_to_main_ms76.12 ± (75.89 - 76.35) ms78.26 ± (77.97 - 78.55) ms+2.8%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.81 ± (11.79 - 11.84) MB11.74 ± (11.72 - 11.76) MB-0.6%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+1.1%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms201.16 ± (200.76 - 201.57) ms209.94 ± (209.46 - 210.42) ms+4.4%✅⬆️
process.time_to_main_ms76.66 ± (76.49 - 76.82) ms80.78 ± (80.55 - 81.02) ms+5.4%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.85 ± (11.83 - 11.87) MB11.80 ± (11.78 - 11.82) MB-0.4%✅
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+1.0%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms511.05 ± (506.81 - 515.28) ms537.37 ± (529.95 - 544.79) ms+5.2%✅⬆️
process.time_to_main_ms518.64 ± (517.65 - 519.63) ms538.69 ± (537.64 - 539.75) ms+3.9%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed51.42 ± (51.38 - 51.47) MB51.55 ± (51.46 - 51.63) MB+0.2%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)+0.5%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8951) - mean (74ms)  : 69, 79
    master - mean (73ms)  : 69, 77

    section Bailout
    This PR (8951) - mean (78ms)  : 74, 83
    master - mean (75ms)  : 72, 77

    section CallTarget+Inlining+NGEN
    This PR (8951) - mean (1,093ms)  : 1045, 1141
    master - mean (1,086ms)  : 1043, 1129
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8951) - mean (114ms)  : 108, 120
    master - mean (111ms)  : 105, 118

    section Bailout
    This PR (8951) - mean (112ms)  : 109, 115
    master - mean (110ms)  : 107, 112

    section CallTarget+Inlining+NGEN
    This PR (8951) - mean (785ms)  : 760, 810
    master - mean (780ms)  : 755, 806
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8951) - mean (102ms)  : 96, 107
    master - mean (101ms)  : 95, 107

    section Bailout
    This PR (8951) - mean (99ms)  : 97, 102
    master - mean (99ms)  : 96, 101

    section CallTarget+Inlining+NGEN
    This PR (8951) - mean (951ms)  : 907, 995
    master - mean (944ms)  : 909, 979
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8951) - mean (97ms)  : 93, 102
    master - mean (96ms)  : 93, 99

    section Bailout
    This PR (8951) - mean (102ms)  : 98, 107
    master - mean (102ms)  : 95, 109

    section CallTarget+Inlining+NGEN
    This PR (8951) - mean (821ms)  : 783, 859
    master - mean (824ms)  : 778, 870
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8951) - mean (211ms)  : 206, 216
    master - mean (206ms)  : 201, 211

    section Bailout
    This PR (8951) - mean (214ms)  : 209, 220
    master - mean (211ms)  : 206, 215

    section CallTarget+Inlining+NGEN
    This PR (8951) - mean (1,273ms)  : 1224, 1322
    master - mean (1,236ms)  : 1181, 1292
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8951) - mean (305ms)  : 297, 312
    master - mean (298ms)  : 292, 305

    section Bailout
    This PR (8951) - mean (307ms)  : 299, 315
    master - mean (297ms)  : 291, 304

    section CallTarget+Inlining+NGEN
    This PR (8951) - mean (1,007ms)  : 981, 1033
    master - mean (992ms)  : 970, 1014
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8951) - mean (296ms)  : 287, 305
    master - mean (290ms)  : 284, 296

    section Bailout
    This PR (8951) - mean (295ms)  : 288, 302
    master - mean (291ms)  : 284, 297

    section CallTarget+Inlining+NGEN
    This PR (8951) - mean (1,201ms)  : 1156, 1246
    master - mean (1,189ms)  : 1153, 1226
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8951) - mean (297ms)  : 291, 303
    master - mean (290ms)  : 281, 299

    section Bailout
    This PR (8951) - mean (301ms)  : 293, 310
    master - mean (288ms)  : 283, 294

    section CallTarget+Inlining+NGEN
    This PR (8951) - mean (1,113ms)  : 1003, 1224
    master - mean (1,063ms)  : 1001, 1126
Loading

bouwkast
bouwkast approved these changes Jul 28, 2026
View reviewed changes
Comment thread tracer/src/Datadog.Trace/AppSec/Waf/NativeBindings/DdwafObjectStruct.cs Outdated
@andrewlock @bouwkast
Apply suggestion from @bouwkast
cb1ac7f 
Co-authored-by: Steven Bouwkamp <steven.bouwkamp@datadoghq.com>
@andrewlock
andrewlock enabled auto-merge (squash) July 28, 2026 12:20
@andrewlock
andrewlock merged commit 4587aca into master Jul 28, 2026
63 of 71 checks passed
@andrewlock
andrewlock deleted the andrew/fix-asm-bug branch July 28, 2026 13:43
@github-actions github-actions Bot added this to the vNext-v3 milestone Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bouwkast bouwkast bouwkast approved these changes
@dromanol dromanol dromanol approved these changes

Assignees

No one assigned

Labels

area:asm identified-by:telemetry

Projects

None yet

Milestone

vNext-v3

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewlock @bouwkast @dromanol