Make sure we pin the dd-apm-test-agent smoke test image - #8952
Merged
Conversation
andrewlock
added
area:builds
andrewlock
changed the title
dd-apm-test-agent smoke test image
| var name = atIndex >= 0 ? image[..atIndex] : image; | ||
|
|
||
| var firstColon = name.IndexOf(':'); | ||
| var repo = firstColon >= 0 ? name[..firstColon] : name; |
Collaborator
There was a problem hiding this comment.
This parsing would fail when using a port (localhost:5000/team/image:latest@sha256:...)
We are not using ports right now, though, so it does not fail currently.
Using lastIndexOf could be an alternative
Member
Author
There was a problem hiding this comment.
interesting, didn't even consider that seeing as we don't really use ports 😅 Agreed it would be better, but given we were using IndexOf previously and I doubt that we'll ever include ports, I'll leave it for now and we can support it later as necessary (just to reduce CI burden tbh 😅)
NachoEchevarria
approved these changes
Jul 28, 2026
BenchmarksBenchmark execution time: 2026-07-28 12:01:19 Comparing candidate commit 1434a6d in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 70 metrics, 1 unstable metrics, 59 known flaky benchmarks, 67 flaky benchmarks without significant changes.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8952) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8952) - mean (70ms) : 68, 72
master - mean (73ms) : 69, 77
section Bailout
This PR (8952) - mean (75ms) : 73, 77
master - mean (75ms) : 72, 77
section CallTarget+Inlining+NGEN
This PR (8952) - mean (1,092ms) : 1050, 1133
master - mean (1,086ms) : 1043, 1129
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8952) - mean (108ms) : 105, 112
master - mean (111ms) : 105, 118
section Bailout
This PR (8952) - mean (113ms) : 106, 120
master - mean (110ms) : 107, 112
section CallTarget+Inlining+NGEN
This PR (8952) - mean (780ms) : 762, 798
master - mean (780ms) : 755, 806
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8952) - mean (101ms) : 95, 107
master - mean (101ms) : 95, 107
section Bailout
This PR (8952) - mean (101ms) : 96, 107
master - mean (99ms) : 96, 101
section CallTarget+Inlining+NGEN
This PR (8952) - mean (946ms) : 903, 989
master - mean (944ms) : 909, 979
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8952) - mean (96ms) : 93, 98
master - mean (96ms) : 93, 99
section Bailout
This PR (8952) - mean (100ms) : 93, 107
master - mean (102ms) : 95, 109
section CallTarget+Inlining+NGEN
This PR (8952) - mean (820ms) : 783, 857
master - mean (824ms) : 778, 870
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8952) - mean (208ms) : 203, 213
master - mean (206ms) : 201, 211
section Bailout
This PR (8952) - mean (210ms) : 207, 214
master - mean (211ms) : 206, 215
section CallTarget+Inlining+NGEN
This PR (8952) - mean (1,244ms) : 1198, 1289
master - mean (1,236ms) : 1181, 1292
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8952) - mean (299ms) : 289, 308
master - mean (298ms) : 292, 305
section Bailout
This PR (8952) - mean (300ms) : 291, 309
master - mean (297ms) : 291, 304
section CallTarget+Inlining+NGEN
This PR (8952) - mean (994ms) : 966, 1023
master - mean (992ms) : 970, 1014
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8952) - mean (290ms) : 284, 295
master - mean (290ms) : 284, 296
section Bailout
This PR (8952) - mean (291ms) : 285, 298
master - mean (291ms) : 284, 297
section CallTarget+Inlining+NGEN
This PR (8952) - mean (1,188ms) : 1145, 1232
master - mean (1,189ms) : 1153, 1226
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8952) - mean (291ms) : 285, 297
master - mean (290ms) : 281, 299
section Bailout
This PR (8952) - mean (292ms) : 286, 298
master - mean (288ms) : 283, 294
section CallTarget+Inlining+NGEN
This PR (8952) - mean (1,077ms) : 997, 1157
master - mean (1,063ms) : 1001, 1126
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Pins the test-agent image to the sha256 digest that is installed in the image
Reason for change
We pin the digest in the root docker-compose.yml file, but we store the smoke test digests in a different file, so we need to pin it there as well (previously we were not pinning these images at all).
Implementation details
dd-apm-test-agentimage to the same digest as we use in docker-compose.ymlTest coverage
Covered by existing - shouldn't get unable to find image issues now
Other details
Didn't add it to the auto-bumped smoke test image digests, because we don't want to auto-bump this one.
#incident-57303