Try to fix unit tests touching [TracerRestorer] - #8957
Conversation
BenchmarksBenchmark execution time: 2026-07-29 14:20:49 Comparing candidate commit 4a6d059 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 70 metrics, 0 unstable metrics, 63 known flaky benchmarks, 63 flaky benchmarks without significant changes.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8957) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8957) - mean (74ms) : 69, 78
master - mean (72ms) : 69, 75
section Bailout
This PR (8957) - mean (75ms) : 73, 77
master - mean (78ms) : 75, 82
section CallTarget+Inlining+NGEN
This PR (8957) - mean (1,093ms) : 1037, 1149
master - mean (1,090ms) : 1044, 1135
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8957) - mean (112ms) : 106, 118
master - mean (114ms) : 108, 120
section Bailout
This PR (8957) - mean (111ms) : 109, 113
master - mean (113ms) : 108, 118
section CallTarget+Inlining+NGEN
This PR (8957) - mean (791ms) : 763, 818
master - mean (786ms) : 766, 805
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8957) - mean (98ms) : 95, 101
master - mean (98ms) : 95, 102
section Bailout
This PR (8957) - mean (99ms) : 97, 101
master - mean (99ms) : 97, 102
section CallTarget+Inlining+NGEN
This PR (8957) - mean (953ms) : 914, 991
master - mean (949ms) : 915, 982
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8957) - mean (100ms) : 94, 106
master - mean (101ms) : 96, 106
section Bailout
This PR (8957) - mean (98ms) : 95, 101
master - mean (99ms) : 95, 104
section CallTarget+Inlining+NGEN
This PR (8957) - mean (820ms) : 782, 858
master - mean (830ms) : 787, 872
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8957) - mean (215ms) : 207, 223
master - mean (205ms) : 200, 211
section Bailout
This PR (8957) - mean (221ms) : 215, 227
master - mean (210ms) : 205, 215
section CallTarget+Inlining+NGEN
This PR (8957) - mean (1,297ms) : 1251, 1343
master - mean (1,240ms) : 1194, 1286
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8957) - mean (310ms) : 303, 317
master - mean (293ms) : 285, 301
section Bailout
This PR (8957) - mean (310ms) : 304, 315
master - mean (294ms) : 288, 301
section CallTarget+Inlining+NGEN
This PR (8957) - mean (1,023ms) : 999, 1047
master - mean (984ms) : 958, 1010
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8957) - mean (302ms) : 295, 310
master - mean (289ms) : 284, 294
section Bailout
This PR (8957) - mean (303ms) : 295, 312
master - mean (291ms) : 287, 296
section CallTarget+Inlining+NGEN
This PR (8957) - mean (1,212ms) : 1163, 1260
master - mean (1,180ms) : 1144, 1216
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8957) - mean (304ms) : 296, 311
master - mean (286ms) : 280, 291
section Bailout
This PR (8957) - mean (305ms) : crit, 296, 314
master - mean (288ms) : 283, 293
section CallTarget+Inlining+NGEN
This PR (8957) - mean (1,130ms) : crit, 1005, 1254
master - mean (1,062ms) : 989, 1135
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Summary of changes
Try to fix the attributes in unit tests
Reason for change
[TracerRestorer]as they don't access global stateImplementation details
Throw AI at it and tell it to fix the flake 😅
Test coverage
Ran locally, but this is the test
Other details
Possibly caused by
#incident-57303