Exclude zero-version assemblies from dependency collection - #8965
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
BenchmarksBenchmark execution time: 2026-07-30 17:03:48 Comparing candidate commit 5196987 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 71 metrics, 0 unstable metrics, 60 known flaky benchmarks, 66 flaky benchmarks without significant changes.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8965) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8965) - mean (72ms) : 69, 75
master - mean (71ms) : 69, 73
section Bailout
This PR (8965) - mean (79ms) : 75, 83
master - mean (79ms) : 73, 84
section CallTarget+Inlining+NGEN
This PR (8965) - mean (1,095ms) : 1041, 1150
master - mean (1,096ms) : 1041, 1152
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8965) - mean (113ms) : 108, 119
master - mean (113ms) : 107, 120
section Bailout
This PR (8965) - mean (114ms) : 108, 120
master - mean (115ms) : 110, 120
section CallTarget+Inlining+NGEN
This PR (8965) - mean (783ms) : 764, 802
master - mean (785ms) : 766, 803
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8965) - mean (103ms) : 97, 108
master - mean (100ms) : 96, 103
section Bailout
This PR (8965) - mean (100ms) : 97, 103
master - mean (102ms) : 98, 107
section CallTarget+Inlining+NGEN
This PR (8965) - mean (953ms) : 919, 987
master - mean (948ms) : 900, 995
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8965) - mean (99ms) : 93, 106
master - mean (97ms) : 94, 99
section Bailout
This PR (8965) - mean (102ms) : 97, 107
master - mean (99ms) : 95, 104
section CallTarget+Inlining+NGEN
This PR (8965) - mean (822ms) : 777, 868
master - mean (824ms) : 775, 873
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8965) - mean (208ms) : 203, 213
master - mean (209ms) : 203, 215
section Bailout
This PR (8965) - mean (213ms) : 210, 216
master - mean (214ms) : 210, 217
section CallTarget+Inlining+NGEN
This PR (8965) - mean (1,248ms) : 1204, 1292
master - mean (1,251ms) : 1208, 1294
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8965) - mean (298ms) : 293, 303
master - mean (299ms) : 293, 306
section Bailout
This PR (8965) - mean (299ms) : 295, 303
master - mean (301ms) : 296, 306
section CallTarget+Inlining+NGEN
This PR (8965) - mean (996ms) : 978, 1015
master - mean (995ms) : 971, 1019
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8965) - mean (292ms) : 288, 297
master - mean (294ms) : 289, 299
section Bailout
This PR (8965) - mean (292ms) : 289, 296
master - mean (293ms) : 289, 298
section CallTarget+Inlining+NGEN
This PR (8965) - mean (1,191ms) : 1149, 1233
master - mean (1,191ms) : 1147, 1236
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8965) - mean (292ms) : 287, 297
master - mean (293ms) : 288, 299
section Bailout
This PR (8965) - mean (292ms) : 287, 296
master - mean (294ms) : 290, 298
section CallTarget+Inlining+NGEN
This PR (8965) - mean (1,065ms) : 1020, 1110
master - mean (1,076ms) : 1006, 1146
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Summary of changes
Exclude all zero-version assemblies from dependency collection
Reason for change
These assemblies are almost always generated, and so are not useful, and cause cardinality explosions.
Implementation details
Test coverage
Consolidated unit tests and added tests for "0.0" and "0.0.0" ("0" alone is not valid)
Other details
#incident-58487