Fix flake in RabbitMQ DSM snapshots across bucket boundaries - #8972
Fix flake in RabbitMQ DSM snapshots across bucket boundaries#8972bouwkast wants to merge 1 commit into
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8972) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8972) - mean (75ms) : 71, 78
master - mean (72ms) : 69, 75
section Bailout
This PR (8972) - mean (77ms) : 73, 81
master - mean (81ms) : 73, 89
section CallTarget+Inlining+NGEN
This PR (8972) - mean (1,093ms) : 1038, 1148
master - mean (1,096ms) : 1052, 1141
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8972) - mean (112ms) : 106, 119
master - mean (115ms) : 108, 121
section Bailout
This PR (8972) - mean (111ms) : 108, 113
master - mean (115ms) : 108, 122
section CallTarget+Inlining+NGEN
This PR (8972) - mean (786ms) : 760, 811
master - mean (785ms) : 763, 807
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8972) - mean (97ms) : 95, 100
master - mean (103ms) : 97, 109
section Bailout
This PR (8972) - mean (98ms) : 96, 100
master - mean (99ms) : 96, 103
section CallTarget+Inlining+NGEN
This PR (8972) - mean (943ms) : 901, 985
master - mean (950ms) : 901, 999
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8972) - mean (101ms) : 95, 106
master - mean (98ms) : 92, 105
section Bailout
This PR (8972) - mean (99ms) : 94, 104
master - mean (102ms) : 96, 108
section CallTarget+Inlining+NGEN
This PR (8972) - mean (821ms) : 786, 855
master - mean (822ms) : 782, 862
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8972) - mean (211ms) : 205, 217
master - mean (211ms) : 205, 217
section Bailout
This PR (8972) - mean (215ms) : 211, 219
master - mean (215ms) : 211, 219
section CallTarget+Inlining+NGEN
This PR (8972) - mean (1,265ms) : 1212, 1319
master - mean (1,268ms) : 1214, 1321
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8972) - mean (303ms) : 294, 312
master - mean (303ms) : 294, 312
section Bailout
This PR (8972) - mean (303ms) : 297, 308
master - mean (305ms) : 295, 315
section CallTarget+Inlining+NGEN
This PR (8972) - mean (1,005ms) : 980, 1031
master - mean (1,009ms) : 984, 1035
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8972) - mean (295ms) : 289, 302
master - mean (298ms) : 291, 305
section Bailout
This PR (8972) - mean (296ms) : 290, 303
master - mean (297ms) : 291, 303
section CallTarget+Inlining+NGEN
This PR (8972) - mean (1,201ms) : 1159, 1243
master - mean (1,200ms) : 1160, 1239
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8972) - mean (294ms) : 287, 301
master - mean (300ms) : 294, 306
section Bailout
This PR (8972) - mean (294ms) : 289, 299
master - mean (301ms) : 293, 308
section CallTarget+Inlining+NGEN
This PR (8972) - mean (1,072ms) : 1008, 1136
master - mean (1,094ms) : 989, 1199
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-07-31 20:28:47 Comparing candidate commit 4d5e3f4 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 71 metrics, 0 unstable metrics, 65 known flaky benchmarks, 61 flaky benchmarks without significant changes.
|
Summary of changes
Since the DSM stats are aggregated in 10 second buckes the same pathway can appear more than once, so this goes and groups them and then grabs the first only.
Reason for change
Flaked here https://dev.azure.com/datadoghq/a51c4863-3eb4-4c5d-878a-58b41a049e4e/_build/results?buildId=206016&view=logs&j=0cad3504-1a92-5a43-34ae-f4023f981687&t=0b455496-9860-5768-a99e-6f5c6c3cdcbd
and the cause was that the snapshots changed.
Implementation details
Test coverage
Same
Other details
#incident-57303