Fix support for building StackExchange Redis sample in latest package version - #8982
Fix support for building StackExchange Redis sample in latest package version#8982andrewlock wants to merge 1 commit into
Conversation
BenchmarksBenchmark execution time: 2026-08-03 15:24:54 Comparing candidate commit b15e9f2 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 71 metrics, 0 unstable metrics, 68 known flaky benchmarks, 58 flaky benchmarks without significant changes.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8982) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8982) - mean (74ms) : 70, 78
master - mean (72ms) : 69, 75
section Bailout
This PR (8982) - mean (76ms) : 74, 77
master - mean (79ms) : 75, 83
section CallTarget+Inlining+NGEN
This PR (8982) - mean (1,096ms) : 1044, 1147
master - mean (1,099ms) : 1029, 1168
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8982) - mean (112ms) : 105, 119
master - mean (115ms) : 109, 120
section Bailout
This PR (8982) - mean (112ms) : 110, 114
master - mean (113ms) : 108, 117
section CallTarget+Inlining+NGEN
This PR (8982) - mean (788ms) : 759, 818
master - mean (783ms) : 760, 807
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8982) - mean (99ms) : 94, 104
master - mean (98ms) : 94, 102
section Bailout
This PR (8982) - mean (104ms) : 97, 110
master - mean (99ms) : 97, 100
section CallTarget+Inlining+NGEN
This PR (8982) - mean (951ms) : 898, 1005
master - mean (943ms) : 900, 987
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8982) - mean (96ms) : 93, 99
master - mean (100ms) : 94, 106
section Bailout
This PR (8982) - mean (97ms) : 95, 100
master - mean (99ms) : 95, 104
section CallTarget+Inlining+NGEN
This PR (8982) - mean (824ms) : 784, 863
master - mean (819ms) : 781, 857
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8982) - mean (211ms) : 207, 214
master - mean (206ms) : 202, 210
section Bailout
This PR (8982) - mean (213ms) : 211, 216
master - mean (209ms) : 204, 214
section CallTarget+Inlining+NGEN
This PR (8982) - mean (1,254ms) : 1208, 1300
master - mean (1,231ms) : 1172, 1289
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8982) - mean (300ms) : 296, 305
master - mean (293ms) : 287, 298
section Bailout
This PR (8982) - mean (301ms) : 295, 306
master - mean (293ms) : 289, 297
section CallTarget+Inlining+NGEN
This PR (8982) - mean (998ms) : 983, 1013
master - mean (981ms) : 954, 1008
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8982) - mean (293ms) : 288, 299
master - mean (288ms) : 283, 292
section Bailout
This PR (8982) - mean (294ms) : 289, 299
master - mean (288ms) : 284, 291
section CallTarget+Inlining+NGEN
This PR (8982) - mean (1,191ms) : 1152, 1229
master - mean (1,173ms) : 1143, 1203
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8982) - mean (295ms) : 289, 300
master - mean (286ms) : 282, 291
section Bailout
This PR (8982) - mean (293ms) : 290, 297
master - mean (286ms) : 281, 291
section CallTarget+Inlining+NGEN
This PR (8982) - mean (1,073ms) : 1016, 1129
master - mean (1,054ms) : 1006, 1102
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Summary of changes
Fix samples from breaking in latest version of StackExchange.Redis
Reason for change
In 3.1.0, they introduce a new obsolete attribute, in preparation for removing of a property.
Implementation details
Gate the problematic API on 3.1.0+
Test coverage
I'll cherry-pick this into #8955 to confirm
Other details
Creating as a separate PR rather than pushing directly to the test PR to avoid the fact it can automatically get re-pushed