fix: reduce heap allocations introduced by ETP#4960
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intoJul 2, 2026
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 9034d27 | Docs | Datadog PR Page | Give us feedback! |
BenchmarksBenchmark execution time: 2026-07-01 18:31:15 Comparing candidate commit 9034d27 in PR branch Found 8 performance improvements and 0 performance regressions! Performance is the same for 316 metrics, 2 unstable metrics, 1 flaky benchmarks without significant changes.
|
hannahkm
force-pushed
the
hannahkm/fix-etp-regression
branch
2 times, most recently
from
f5e9205 to
5e2fc07
Compare
Contributor
Config Audit |
hannahkm
force-pushed
the
hannahkm/fix-etp-regression
branch
2 times, most recently
from
0af971e to
1d4e5fc
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de1ac4fccb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
hannahkm
changed the title
darccio
reviewed
Jul 1, 2026
### What does this PR do? Replaces the decoder for certain benchmarks with a simple buffer read. Imitates a real HTTP request, but without additional decoding work that would interfere with what we actually want to benchmark (*encoding*) <!-- * A brief description of the change being made with this pull request. * If the description here cannot be expressed in a succinct form, consider opening multiple pull requests instead of a single one. --> ### Motivation Benchmarks should measure what we're actually interested in. <!-- * What inspired you to submit this pull request? * Link any related GitHub issues or PRs here. * If this resolves a GitHub issue, include "Fixes #XXXX" to link the issue and auto-close it on merge. --> ### Reviewer's Checklist <!-- * Authors can use this list as a reference to ensure that there are no problems during the review but the signing off is to be done by the reviewer(s). --> - [ ] Changed code has unit tests for its functionality at or near 100% coverage. - [ ] [System-Tests](https://github.com/DataDog/system-tests/) covering this feature have been added and enabled with the va.b.c-dev version tag. - [ ] There is a benchmark for any new code, or changes to existing code. - [ ] If this interacts with the agent in a new way, a system test has been added. - [ ] New code is free of linting errors. You can check this by running `make lint` locally. - [ ] New code doesn't break existing tests. You can check this by running `make test` locally. - [ ] Add an appropriate team label so this PR gets put in the right place for the release notes. - [ ] All generated files are up to date. You can check this by running `make generate` locally. - [ ] Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running `make fix-modules` locally. Unsure? Have a question? Request a review!
hannahkm
force-pushed
the
hannahkm/fix-etp-regression
branch
from
2fce544 to
9034d27
Compare
darccio
approved these changes
Jul 2, 2026
kakkoyun
approved these changes
Jul 2, 2026
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
hannahkm/fix-etp-regression
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
No longer includes decoding code in benchmarks, making measurements more accurate to what we actually care about (encoding payloads).
Partially or fully reverts the regressions from this PR.
Motivation
Reduce memory overhead of ETP benchmarks AND make benchmarks more accurate to real life customer data. Decoding does not happen in a customer app, but rather in the backend/agent. Having decoding measured as part of a benchmark's life cycle is not realistic or usually helpful.
Reviewer's Checklist
make lintlocally.make testlocally.make generatelocally.make fix-moduleslocally.Unsure? Have a question? Request a review!