Skip to content

Clean up README#143

Merged
sarahchen6 merged 3 commits intomasterfrom
sarahchen6/minor-improvements
Mar 12, 2026
Merged

Clean up README#143
sarahchen6 merged 3 commits intomasterfrom
sarahchen6/minor-improvements

Conversation

@sarahchen6
Copy link
Copy Markdown
Contributor

Improve README clarity (and test #139)

@github-actions
Copy link
Copy Markdown

Mirrored test images for 143_merge-* were added in https://github.com/DataDog/images/pull/9085. When you've finished validating the image, please remove the mirrored test images.

@sarahchen6
Copy link
Copy Markdown
Contributor Author

sarahchen6 commented Mar 12, 2026

After running Create test image mirror PR for 143 (workflow run), this PR to add the mirrored test images was automatically opened: https://github.com/DataDog/images/pull/9085 🙌 It was automatically approved and would've been automatically merged like this PR if I had been more patient by a few more seconds.

@sarahchen6
Copy link
Copy Markdown
Contributor Author

sarahchen6 commented Mar 12, 2026

After 6fca017 and running the workflow again (workflow run), an update PR was automatically created: https://github.com/DataDog/images/pull/9086 🙌 This was automatically approved and merged.

@sarahchen6
Copy link
Copy Markdown
Contributor Author

Tested the 143_merge-* mirrored images in dd-trace-java CI: DataDog/dd-trace-java#10827

@sarahchen6
Copy link
Copy Markdown
Contributor Author

sarahchen6 commented Mar 12, 2026

After this PR is merged, we can check the Update mirror digests for ci-* images workflow and remove the test images from DataDog/images.

Copy link
Copy Markdown
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe make sense to replace 123 with NNN because it is a bit confusing why we referencing to very particular PR number.

@sarahchen6 sarahchen6 merged commit ed5926e into master Mar 12, 2026
4 checks passed
@sarahchen6
Copy link
Copy Markdown
Contributor Author

Following up, the Update mirror digests for ci-* images workflow succeeded (workflow run) and created this PR: https://github.com/DataDog/images/pull/9088 to update ci-* image digests, which was automatically merged 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants