Skip to content

Commit 008a521

Browse files
committed
use substring rather than split to avoid regex matching
1 parent 6ccec5d commit 008a521

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

dd-trace-core/src/main/java/datadog/trace/lambda/LambdaAppSecHandler.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -501,7 +501,11 @@ private static LambdaEventData extractAlbData(
501501
String method = (String) event.get("httpMethod");
502502
String path = (String) event.get("path");
503503
String xff = headers.get("x-forwarded-for");
504-
String sourceIp = xff != null ? xff.split(",")[0].trim() : null;
504+
String sourceIp = null;
505+
if (xff != null) {
506+
int commaIdx = xff.indexOf(',');
507+
sourceIp = (commaIdx >= 0 ? xff.substring(0, commaIdx) : xff).trim();
508+
}
505509

506510
return new LambdaEventData(
507511
headers, method, path, sourceIp, null, triggerType, pathParameters, queryParameters, body);

0 commit comments

Comments
 (0)