Skip to content

Commit 03435e3

Browse files
committed
feat(http): Disable API tests until a library is available
1 parent 4e9e167 commit 03435e3

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

components/http/http-api/build.gradle.kts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ apply(from = "$rootDir/gradle/java.gradle")
77

88
description = "HTTP Client API"
99

10-
val minimumBranchCoverage by extra(0.7)
11-
val minimumInstructionCoverage by extra(0.7)
10+
val minimumBranchCoverage by extra(0) // extra(0.7) -- need a library implementation
11+
val minimumInstructionCoverage by extra(0) // extra(0.7) -- need a library implementation
1212

1313
// Exclude interfaces for test coverage
1414
val excludedClassesCoverage by extra(
@@ -28,8 +28,8 @@ val excludedClassesCoverage by extra(
2828

2929
dependencies {
3030
// Add API implementations to test providers
31-
testRuntimeOnly(project(":components:http:http-lib-jdk"))
32-
testRuntimeOnly(project(":components:http:http-lib-okhttp"))
31+
// testRuntimeOnly(project(":components:http:http-lib-jdk"))
32+
// testRuntimeOnly(project(":components:http:http-lib-okhttp"))
3333
// Add MockServer for test fixtures
3434
testFixturesImplementation("org.mock-server:mockserver-junit-jupiter-no-dependencies:5.14.0")
3535
}

components/http/http-api/src/test/java/datadog/http/client/HttpProvidersTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import java.util.function.Supplier;
1313
import java.util.stream.Stream;
1414
import org.junit.jupiter.api.BeforeAll;
15+
import org.junit.jupiter.api.Disabled;
1516
import org.junit.jupiter.api.Test;
1617
import org.junit.jupiter.api.condition.EnabledForJreRange;
1718
import org.junit.jupiter.params.ParameterizedTest;
@@ -121,6 +122,7 @@ private void assertType(Object builder) {
121122
assertTrue(builder.getClass().getName().startsWith(getImplementationPackage()));
122123
}
123124

125+
@Disabled
124126
@EnabledForJreRange(max = JAVA_10)
125127
static class OkHttpProvidersForkedTest extends HttpProvidersTest {
126128
@Override
@@ -129,6 +131,7 @@ String getImplementationPackage() {
129131
}
130132
}
131133

134+
@Disabled
132135
@EnabledForJreRange(min = JAVA_11)
133136
static class JdkHttpProvidersForkedTest extends HttpProvidersTest {
134137
@Override
@@ -137,6 +140,7 @@ String getImplementationPackage() {
137140
}
138141
}
139142

143+
@Disabled
140144
@EnabledForJreRange(min = JAVA_11)
141145
static class HttpProvidersCompatForkedTest extends HttpProvidersTest {
142146
@BeforeAll

0 commit comments

Comments
 (0)