replace tabletest by valuesource for single param

Author: jpbempel

.claude/skills/migrate-groovy-to-java/SKILL.md

@@ -20,7 +20,7 @@ When converting Groovy code to Java code, make sure that:
 - `@TableTest` and `@MethodSource` may be combined on the same `@ParameterizedTest` when most cases are tabular but a few cases require programmatic setup.
 - In combined mode, keep table-friendly cases in `@TableTest`, and put only non-tabular/complex cases in `@MethodSource`.
 - If `@TableTest` is not viable for the test at all, use `@MethodSource` only.
-- If `@TableTest` was successfully used, `@ParameterizedTest` can then be removed as `@TableTest` replace it fully
+- If `@TableTest` was successfully used and if the `@ParameterizedTest` is not used to specify the test name, `@ParameterizedTest` can then be removed as `@TableTest` replace it fully.
 - For `@MethodSource`, name the arguments method `<testMethodName>Arguments` (camelCase, e.g. `testMethodArguments`) and return `Stream<Arguments>` using `Stream.of(...)` and `arguments(...)` with static import.
 - Ensure parameterized test names are human-readable (i.e. no hashcodes); instead add a description string as the first `Arguments.arguments(...)` value or index the test case
 - When converting tuples, create a light dedicated structure instead to keep the typing system

dd-trace-core/src/test/java/datadog/trace/core/BlackholeSpanTest.java

@@ -1,26 +1,24 @@
 package datadog.trace.core;
 
+import static datadog.trace.junit.utils.config.WithConfigExtension.injectSysConfig;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import datadog.trace.bootstrap.instrumentation.api.AgentScope;
 import datadog.trace.bootstrap.instrumentation.api.AgentSpan;
 import datadog.trace.common.writer.ListWriter;
-import datadog.trace.junit.utils.config.WithConfigExtension;
 import java.util.Arrays;
 import java.util.Properties;
-import org.tabletest.junit.TableTest;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
 
 public class BlackholeSpanTest extends DDCoreJavaSpecification {
 
-  @TableTest({
-    "scenario                         | moreBits",
-    "128 bit traceid logging enabled  | true    ",
-    "128 bit traceid logging disabled | false   "
-  })
-  void shouldMuteTracing(String moreBits) throws Exception {
-    WithConfigExtension.injectSysConfig("trace.128.bit.traceid.logging.enabled", moreBits);
+  @ValueSource(strings = {"true", "false"})
+  @ParameterizedTest
+  void shouldMuteTracing(String use128bitTraceId) throws Exception {
+    injectSysConfig("trace.128.bit.traceid.logging.enabled", use128bitTraceId);
     ListWriter writer = new ListWriter();
     Properties props = new Properties();
     CoreTracer tracer = tracerBuilder().withProperties(props).writer(writer).build();

dd-trace-core/src/test/java/datadog/trace/core/LongRunningTracesTrackerTest.java

@@ -121,10 +121,9 @@ void traceWithoutRightStateAreNotTracked() {
 
   @Test
   void maxTrackedTracesIsEnforced() {
-    for (int i = 0; i < MAX_TRACKED_TRACES; i++) {
+    for (int i = 0; i < MAX_TRACKED_TRACES + 1; i++) {
       tracker.add(newTraceToTrack());
     }
-    tracker.add(newTraceToTrack());
     assertEquals(MAX_TRACKED_TRACES, tracker.trackedCount());
     assertEquals(1, tracker.getDropped());
   }

dd-trace-core/src/test/java/datadog/trace/core/TraceCorrelationTest.java

@@ -10,15 +10,13 @@
 import datadog.trace.common.writer.ListWriter;
 import datadog.trace.junit.utils.config.WithConfigExtension;
 import org.junit.jupiter.api.Test;
-import org.tabletest.junit.TableTest;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
 
 public class TraceCorrelationTest extends DDCoreJavaSpecification {
 
-  @TableTest({
-    "scenario         | log128bTraceId",
-    "128-bit enabled  | true          ",
-    "128-bit disabled | false         "
-  })
+  @ValueSource(booleans = {true, false})
+  @ParameterizedTest
   void getTraceIdWithoutTrace(boolean log128bTraceId) {
     WithConfigExtension.injectSysConfig(
         TRACE_128_BIT_TRACEID_GENERATION_ENABLED, String.valueOf(log128bTraceId));
@@ -36,11 +34,8 @@ void getTraceIdWithoutTrace(boolean log128bTraceId) {
     tracer.close();
   }
 
-  @TableTest({
-    "scenario         | log128bTraceId",
-    "128-bit enabled  | true          ",
-    "128-bit disabled | false         "
-  })
+  @ValueSource(booleans = {true, false})
+  @ParameterizedTest
   void getTraceIdWithTrace(boolean log128bTraceId) {
     WithConfigExtension.injectSysConfig(
         TRACE_128_BIT_TRACEID_GENERATION_ENABLED, String.valueOf(log128bTraceId));