Update JUnit Tests to run with STRICT_TEST mode by default (#11045)

updating config helper to have descriptive exception in strict mode

init

fixing test_base issues and adding drain to confighelpre

suppressforbidden

move ConfigInversionExtension to config-utils

simplifying extension

Merge branch 'master' into mhlidd/junit_strict_mode

Co-authored-by: devflow.devflow-routing-intake <devflow.devflow-routing-intake@kubernetes.us1.ddbuild.io>

Author: mhlidd

buildSrc/src/main/kotlin/dd-trace-java.configure-tests.gradle.kts

@@ -46,6 +46,9 @@ tasks.withType<Test>().configureEach {
   // Use a task-specific user prefs directory
   systemProperty("java.util.prefs.userRoot", layout.buildDirectory.dir("tmp/userPrefs/$name").get().asFile.absolutePath)
 
+  // Enable JUnit 5 auto-detection so ConfigInversionExtension (STRICT mode) is loaded automatically
+  systemProperty("junit.jupiter.extensions.autodetection.enabled", "true")
+
   // Split up tests that want to run forked in their own separate JVM for generated tasks
   if (name.startsWith("forkedTest") || name.endsWith("ForkedTest")) {
     setExcludes(emptyList())

utils/config-utils/build.gradle.kts

@@ -1,5 +1,6 @@
 plugins {
   `java-library`
+  `java-test-fixtures`
   id("dd-trace-java.supported-config-generator")
 }
 
@@ -60,6 +61,8 @@ dependencies {
   implementation(libs.slf4j)
   implementation("org.snakeyaml", "snakeyaml-engine", "2.9")
 
+  testFixturesImplementation(libs.junit.jupiter)
+
   testImplementation(project(":utils:test-utils"))
   testImplementation("org.snakeyaml:snakeyaml-engine:2.9")
   testImplementation("com.squareup.okhttp3:mockwebserver:${libs.versions.okhttp.legacy.get()}")

utils/config-utils/src/test/java/datadog/trace/config/inversion/ConfigHelperTest.java

@@ -3,6 +3,7 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 
 import datadog.trace.test.util.ControllableEnvironmentVariables;
 import java.util.ArrayList;
@@ -167,6 +168,14 @@ void testInconsistentAliasesAndAliasMapping() {
     assertFalse(result.containsKey(NEW_ALIAS_TARGET));
   }
 
+  @Test
+  void testStrictTestThrowsForUnsupportedConfig() {
+    env.set("DD_FAKE_VAR", "banana");
+
+    // STRICT_TEST mode should throw for unsupported DD_ variables
+    assertThrows(IllegalArgumentException.class, () -> ConfigHelper.env("DD_FAKE_VAR"));
+  }
+
   @Test
   void testUnsupportedEnvWarningNotInTestMode() {
     ConfigHelper.get().setConfigInversionStrict(ConfigHelper.StrictnessPolicy.TEST);

utils/config-utils/src/testFixtures/java/datadog/trace/test/ConfigInversionExtension.java

@@ -0,0 +1,40 @@
+package datadog.trace.test;
+
+import datadog.trace.config.inversion.ConfigHelper;
+import datadog.trace.config.inversion.ConfigHelper.StrictnessPolicy;
+import java.util.List;
+import org.junit.jupiter.api.extension.AfterAllCallback;
+import org.junit.jupiter.api.extension.BeforeAllCallback;
+import org.junit.jupiter.api.extension.ExtensionContext;
+
+/**
+ * JUnit 5 extension that enforces {@link StrictnessPolicy#STRICT_TEST} mode on {@link ConfigHelper}
+ * during test execution. Any access to an unsupported configuration key will throw {@link
+ * IllegalArgumentException} and be collected for assertion in {@link #afterAll}.
+ *
+ * <p>Registered via {@code META-INF/services/org.junit.jupiter.api.extension.Extension} for
+ * automatic discovery. Requires {@code junit.jupiter.extensions.autodetection.enabled=true}.
+ */
+public class ConfigInversionExtension implements BeforeAllCallback, AfterAllCallback {
+
+  private StrictnessPolicy previousPolicy;
+
+  @Override
+  public void beforeAll(ExtensionContext ctx) {
+    previousPolicy = ConfigHelper.get().configInversionStrictFlag();
+    ConfigHelper.get().setConfigInversionStrict(StrictnessPolicy.STRICT_TEST);
+  }
+
+  @Override
+  public void afterAll(ExtensionContext ctx) {
+    List<String> unsupported = ConfigHelper.get().drainUnsupportedConfigs();
+    ConfigHelper.get().setConfigInversionStrict(previousPolicy);
+
+    if (!unsupported.isEmpty()) {
+      throw new AssertionError(
+          "Unsupported configurations found during test. "
+              + "Add these to metadata/supported-configurations.json or opt out with StrictnessPolicy.TEST:\n  "
+              + String.join("\n  ", unsupported));
+    }
+  }
+}

utils/config-utils/src/testFixtures/resources/META-INF/services/org.junit.jupiter.api.extension.Extension

@@ -0,0 +1 @@
+datadog.trace.test.ConfigInversionExtension