Commit 19ae772
committed
fix(appsec/jetty): cover Jetty 10.0.0-10.0.9 and close PartHelper InputStream
- jetty-appsec-9.4: extend muzzle to also cover Jetty 10.0.0–10.0.9, which were
previously a gap. In those versions _multiParts is typed MultiPartFormInputStream
(not MultiParts); the primary Reference spec matches 9.4.10+ and 10.0.10+, and an
OrReference alternative matches 10.0.0–10.0.9. The GetFilenamesAdvice already uses
typing=DYNAMIC so no advice changes are needed.
- jetty-appsec-8.1.3 PartHelper: wrap part.getInputStream() in try-with-resources to
avoid leaking file descriptors on file-backed multipart form fields.1 parent e43466f commit 19ae772
3 files changed
Lines changed: 22 additions & 5 deletions
File tree
- dd-java-agent/instrumentation/jetty/jetty-appsec
- jetty-appsec-8.1.3/src/main/java/datadog/trace/instrumentation/jetty8
- jetty-appsec-9.4
- src/main/java/datadog/trace/instrumentation/jetty94
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | | - | |
98 | | - | |
| 97 | + | |
99 | 98 | | |
100 | 99 | | |
101 | 100 | | |
| |||
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
8 | 16 | | |
9 | 17 | | |
10 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
| 61 | + | |
62 | 62 | | |
63 | | - | |
64 | | - | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
65 | 66 | | |
66 | 67 | | |
67 | 68 | | |
| |||
73 | 74 | | |
74 | 75 | | |
75 | 76 | | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
76 | 86 | | |
77 | 87 | | |
78 | 88 | | |
| |||
0 commit comments