Commit 1f77338
committed
fix(appsec): capture all FileChannel.open args to avoid CSI generator partial-arg path
beforeOpenSet previously captured only 2 of 3 arguments, triggering the
partial-argument code path in AdviceGeneratorImpl which calls Stream.sorted()
without a comparator on ArgumentSpecification (not Comparable). Adding the
unused FileAttribute[] third parameter makes the capture complete and
sequential, so isPositionalArguments() returns false and the sorted() path
is never entered.1 parent b27caf4 commit 1f77338
File tree
1 file changed
+3
-1
lines changed- dd-java-agent/instrumentation/java/java-io-1.8/src/main/java/datadog/trace/instrumentation/java/lang
1 file changed
+3
-1
lines changedLines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
31 | 32 | | |
32 | 33 | | |
33 | 34 | | |
34 | | - | |
| 35 | + | |
| 36 | + | |
35 | 37 | | |
36 | 38 | | |
37 | 39 | | |
| |||
0 commit comments