Skip to content

Commit 2b2852b

Browse files
committed
moving logger out of nested class
1 parent c19cb84 commit 2b2852b

3 files changed

Lines changed: 14 additions & 11 deletions

File tree

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
package datadog.trace.instrumentation.jms;
2+
3+
import datadog.trace.bootstrap.instrumentation.api.AgentSpan;
4+
import org.slf4j.Logger;
5+
import org.slf4j.LoggerFactory;
6+
7+
public class JMSLogger {
8+
private static final Logger log = LoggerFactory.getLogger(JMSLogger.class);
9+
10+
public static void logIterationSpan(AgentSpan span) {
11+
log.debug("Expecting the following `ITERATION` span to be finished {}", span);
12+
}
13+
}

dd-java-agent/instrumentation/jms/javax-jms-1.1/src/main/java/datadog/trace/instrumentation/jms/JMSMessageConsumerInstrumentation.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,6 @@
3939
import net.bytebuddy.asm.Advice;
4040
import net.bytebuddy.description.type.TypeDescription;
4141
import net.bytebuddy.matcher.ElementMatcher;
42-
import org.slf4j.Logger;
43-
import org.slf4j.LoggerFactory;
4442

4543
public final class JMSMessageConsumerInstrumentation
4644
implements Instrumenter.ForTypeHierarchy, Instrumenter.HasMethodAdvice {
@@ -216,12 +214,4 @@ public static void setMessageListener(
216214
}
217215
}
218216
}
219-
220-
public static class JMSLogger {
221-
private static final Logger log = LoggerFactory.getLogger(JMSLogger.class);
222-
223-
public static void logIterationSpan(AgentSpan span) {
224-
log.debug("Expecting the following `ITERATION` span to be finished {}", span);
225-
}
226-
}
227217
}

dd-java-agent/instrumentation/jms/javax-jms-1.1/src/main/java/datadog/trace/instrumentation/jms/JavaxJmsModule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public String[] helperClassNames() {
3737
packageName + ".MessageExtractAdapter$1",
3838
packageName + ".MessageInjectAdapter",
3939
packageName + ".DatadogMessageListener",
40-
packageName + ".JMSMessageConsumerInstrumentation$JMSLogger"
40+
packageName + ".JMSLogger"
4141
};
4242
}
4343

0 commit comments

Comments
 (0)