Apply reviewer suggestions

- Use built-in Gradle WriteProperties task instead of custom doLast
  action, which handles inputs/outputs/caching natively
- Fix Groovy with{} usage in test: apply it on ZipOutputStream
  (not ZipEntry as incorrectly suggested in the upstream commit)

Author: jandro996

dd-java-agent/build.gradle

@@ -324,17 +324,17 @@ def generateAgentJarIndex = tasks.register('generateAgentJarIndex', JavaExec) {
 }
 sourceSets.main.resources.srcDir(generateAgentJarIndex)
 
-def generatePomProperties = tasks.register('generatePomProperties') {
-  def outputDir = project.layout.buildDirectory.dir("generated/maven-metadata")
-  inputs.property("version", project.provider { project.version.toString() })
-  outputs.dir(outputDir)
-  doLast {
-    def pomPropsFile = outputDir.get().file("META-INF/maven/com.datadoghq/dd-java-agent/pom.properties").asFile
-    pomPropsFile.parentFile.mkdirs()
-    pomPropsFile.text = "groupId=com.datadoghq\nartifactId=dd-java-agent\nversion=${project.version}\n"
-  }
+def pomPropertiesOutputDir = project.layout.buildDirectory.dir("generated/maven-metadata")
+def generatePomProperties = tasks.register('generatePomProperties', WriteProperties) {
+  destinationFile = pomPropertiesOutputDir.map { it.file("META-INF/maven/com.datadoghq/dd-java-agent/pom.properties") }
+  property("groupId", "com.datadoghq")
+  property("artifactId", "dd-java-agent")
+  property("version", project.providers.provider { project.version.toString() })
+}
+sourceSets.main.resources.srcDir(pomPropertiesOutputDir)
+tasks.named("processResources") {
+  dependsOn(generatePomProperties)
 }
-sourceSets.main.resources.srcDir(generatePomProperties)
 
 subprojects { Project subProj ->
   // Don't need javadoc task run for internal projects.

telemetry/src/test/groovy/datadog/telemetry/dependency/DependencyResolverSpecification.groovy

@@ -98,12 +98,11 @@ class DependencyResolverSpecification extends DepSpecification {
   void 'jar with dd-java-agent pom.properties resolves to com.datadoghq:dd-java-agent'() {
     given: 'a jar containing META-INF/maven/com.datadoghq/dd-java-agent/pom.properties'
     File file = new File(testDir, 'dd-java-agent.jar')
-    ZipOutputStream out = new ZipOutputStream(new FileOutputStream(file))
-    ZipEntry e = new ZipEntry('META-INF/maven/com.datadoghq/dd-java-agent/pom.properties').with {
-        putNextEntry(e)
-        write('groupId=com.datadoghq\nartifactId=dd-java-agent\nversion=1.0.0\n'.getBytes('UTF-8'))
-        closeEntry()
-        close()
+    new ZipOutputStream(new FileOutputStream(file)).with {
+      putNextEntry(new ZipEntry('META-INF/maven/com.datadoghq/dd-java-agent/pom.properties'))
+      write('groupId=com.datadoghq\nartifactId=dd-java-agent\nversion=1.0.0\n'.getBytes('UTF-8'))
+      closeEntry()
+      close()
     }
 
     when: