Skip to content

Commit 2f706c9

Browse files
committed
Fix test formatting and add tabletest to java_deps
1 parent 85b3626 commit 2f706c9

File tree

4 files changed

+15
-16
lines changed

4 files changed

+15
-16
lines changed

.claude/skills/migrate-junit-source-to-tabletest/SKILL.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,8 @@ Process (do in this order):
1212
5) Run module tests once and verify "BUILD SUCCESSFUL". If failed, inspect JUnit XML report.
1313

1414
Dependency:
15-
- If missing, add:
16-
- Groovy: testImplementation libs.tabletest
17-
- Kotlin: testImplementation(libs.tabletest)
15+
- @TableTest should be in `gradle/java_deps.gradle` as `testImplementation libs.tabletest` where Java modules inherit it via `gradle/java.gradle`.
16+
- As a fallback, add module-specific `testImplementation(libs.tabletest)` or `testImplementation libs.tabletest`.
1817

1918
Import: `import org.tabletest.junit.TableTest;`
2019

dd-trace-api/build.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,5 @@ dependencies {
7575
api(libs.slf4j)
7676
testImplementation(libs.guava)
7777
testImplementation(libs.bundles.mockito)
78-
testImplementation(libs.tabletest)
7978
testImplementation(project(":utils:test-utils"))
8079
}

dd-trace-api/src/test/java/datadog/trace/api/DDTraceIdTest.java

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -159,18 +159,18 @@ void failParsingIllegal128BitIdHexadecimalStringRepresentation(String hexId) {
159159
}
160160

161161
@TableTest({
162-
"scenario | hexId | start | length | lowerCaseOnly",
163-
"null string | | 0 | 0 | true ",
164-
"empty string | '' | 0 | 0 | true ",
165-
"out of bound length | '123456789abcdef0' | 0 | 17 | true ",
166-
"out of bound end | '123456789abcdef0' | 7 | 10 | true ",
167-
"out of bound start | '123456789abcdef0' | 17 | 0 | true ",
168-
"invalid minus one | '-1' | 0 | 1 | true ",
169-
"invalid minus a | '-a' | 0 | 1 | true ",
170-
"invalid character | '123abcg' | 0 | 7 | true ",
171-
"invalid upper case A | 'A' | 0 | 1 | true ",
172-
"invalid upper case | '123ABC' | 0 | 6 | true ",
173-
"too long | '111111111111111111111111111111111' | 0 | 33 | true"
162+
"scenario | hexId | start | length | lowerCaseOnly",
163+
"null string | | 0 | 0 | true ",
164+
"empty string | '' | 0 | 0 | true ",
165+
"out of bound length | '123456789abcdef0' | 0 | 17 | true ",
166+
"out of bound end | '123456789abcdef0' | 7 | 10 | true ",
167+
"out of bound start | '123456789abcdef0' | 17 | 0 | true ",
168+
"invalid minus one | '-1' | 0 | 1 | true ",
169+
"invalid minus a | '-a' | 0 | 1 | true ",
170+
"invalid character | '123abcg' | 0 | 7 | true ",
171+
"invalid upper case A | 'A' | 0 | 1 | true ",
172+
"invalid upper case | '123ABC' | 0 | 6 | true ",
173+
"too long | '111111111111111111111111111111111' | 0 | 33 | true "
174174
})
175175
@ParameterizedTest
176176
void failParsingIllegal128BitIdHexadecimalStringRepresentationFromPartialString(

gradle/java_deps.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ apply plugin: 'groovy'
33
dependencies {
44
testImplementation libs.bundles.spock
55
testImplementation libs.bundles.groovy
6+
testImplementation libs.tabletest
67

78
testImplementation libs.bundles.test.logging
89

0 commit comments

Comments
 (0)