fix: limit warning to once per project build

Author: daniel-mohedano

dd-java-agent/instrumentation/gradle/gradle-3.0/src/main/groovy/datadog/trace/instrumentation/gradle/legacy/GradleProjectConfigurator.groovy

@@ -45,6 +45,8 @@ class GradleProjectConfigurator {
   private static final String JACOCO_PLUGIN_ID = 'jacoco'
   private static final String JACOCO_AGENT_CONFIGURATION_NAME = 'jacocoAgent'
   private static final String JACOCO_ANT_CONFIGURATION_NAME = 'jacocoAnt'
+  private static final String DEPENDENCY_VERIFICATION_WARNING_EMITTED =
+  'datadog.civisibility.dependency-verification-warning-emitted'
 
   void configureTracer(Task task, Map<String, String> propagatedSystemProperties) {
     def config = Config.get()
@@ -226,13 +228,17 @@ class GradleProjectConfigurator {
     }
 
     if (project.rootProject.file('gradle/verification-metadata.xml').isFile()) {
-      project.logger.warn(
-        "Datadog Test Optimization disabled Gradle dependency verification for configuration "
-        + "${configuration.name}. To keep verification enabled, set "
-        + "DD_CIVISIBILITY_GRADLE_DEPENDENCY_VERIFICATION_ENABLED=true and add "
-        + "the Datadog compiler plugin and injected JaCoCo dependencies to "
-        + "gradle/verification-metadata.xml. If the metadata is not updated, Gradle will "
-        + "fail the build while resolving these dependencies.")
+      def extraProperties = project.rootProject.extensions.extraProperties
+      if (!extraProperties.has(DEPENDENCY_VERIFICATION_WARNING_EMITTED)) {
+        extraProperties.set(DEPENDENCY_VERIFICATION_WARNING_EMITTED, true)
+        project.logger.warn(
+          "Datadog Test Optimization disabled Gradle dependency verification for dependencies "
+          + "injected into this build. To keep verification enabled, set "
+          + "DD_CIVISIBILITY_GRADLE_DEPENDENCY_VERIFICATION_ENABLED=true and add "
+          + "the Datadog compiler plugin and injected JaCoCo dependencies to "
+          + "gradle/verification-metadata.xml. If the metadata is not updated, Gradle will "
+          + "fail the build while resolving these dependencies.")
+      }
     }
     configuration.resolutionStrategy.disableDependencyVerification()
   }

dd-java-agent/instrumentation/gradle/gradle-8.3/src/main/groovy/datadog/trace/instrumentation/gradle/CiVisibilityPlugin.java

@@ -33,6 +33,8 @@ public abstract class CiVisibilityPlugin implements Plugin<Project> {
   private static final String JACOCO_PLUGIN_ID = "jacoco";
   private static final String JACOCO_AGENT_CONFIGURATION_NAME = "jacocoAgent";
   private static final String JACOCO_ANT_CONFIGURATION_NAME = "jacocoAnt";
+  private static final String DEPENDENCY_VERIFICATION_WARNING_EMITTED =
+      "datadog.civisibility.dependency-verification-warning-emitted";
 
   private Project project;
 
@@ -124,14 +126,24 @@ private void disableDependencyVerificationIfConfigured(Configuration configurati
             .getProjectDir()
             .toPath()
             .resolve("gradle/verification-metadata.xml"))) {
-      LOGGER.warn(
-          "Datadog Test Optimization disabled Gradle dependency verification for configuration "
-              + "{}. To keep verification enabled, set "
-              + "DD_CIVISIBILITY_GRADLE_DEPENDENCY_VERIFICATION_ENABLED=true and add "
-              + "the Datadog compiler plugin and injected JaCoCo dependencies to "
-              + "gradle/verification-metadata.xml. If the metadata is not updated, Gradle will "
-              + "fail the build while resolving these dependencies.",
-          configuration.getName());
+      if (!project
+          .getRootProject()
+          .getExtensions()
+          .getExtraProperties()
+          .has(DEPENDENCY_VERIFICATION_WARNING_EMITTED)) {
+        project
+            .getRootProject()
+            .getExtensions()
+            .getExtraProperties()
+            .set(DEPENDENCY_VERIFICATION_WARNING_EMITTED, true);
+        LOGGER.warn(
+            "Datadog Test Optimization disabled Gradle dependency verification for dependencies "
+                + "injected into this build. To keep verification enabled, set "
+                + "DD_CIVISIBILITY_GRADLE_DEPENDENCY_VERIFICATION_ENABLED=true and add "
+                + "the Datadog compiler plugin and injected JaCoCo dependencies to "
+                + "gradle/verification-metadata.xml. If the metadata is not updated, Gradle will "
+                + "fail the build while resolving these dependencies.");
+      }
     }
     configuration.getResolutionStrategy().disableDependencyVerification();
   }

dd-smoke-tests/gradle/src/test/java/datadog/smoketest/GradleDaemonSmokeTest.java

@@ -1,5 +1,6 @@
 package datadog.smoketest;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -191,12 +192,12 @@ void testInjectedDependencyVerification(String gradleVersion, boolean verificati
       assertTrue(buildResult.getOutput().contains("Dependency verification failed"));
     } else {
       assertBuildSuccessful(buildResult);
-      assertTrue(
-          buildResult
-              .getOutput()
-              .contains(
-                  "Datadog Test Optimization disabled Gradle dependency verification for "
-                      + "configuration "));
+      String warning =
+          "Datadog Test Optimization disabled Gradle dependency verification for dependencies "
+              + "injected into this build.";
+      int firstWarning = buildResult.getOutput().indexOf(warning);
+      assertTrue(firstWarning >= 0);
+      assertEquals(firstWarning, buildResult.getOutput().lastIndexOf(warning));
     }
   }