Commit 3ccb046
committed
fix(appsec/jetty): disable multipart test on Jetty 9.0.x and bump test version to 10.0.10
- jetty-server-9.0 and jetty-server-9.0.4: set testBodyMultipart() = false.
jetty-appsec-8.1.3 covers [8.1.3, 9.2.0.RC0) which includes Jetty 9.0.x;
its extractContentParameters() calls ParameterCollector.put(String, String)
which does not exist in Jetty 9.0.x, causing HTTP 500 on multipart requests.
- jetty-server-10.0: bump test dependency from 10.0.0 to 10.0.10.
jetty-appsec-9.4 requires _multiParts: Lorg/eclipse/jetty/server/MultiParts;
but that type was only introduced in 10.0.10 (previously MultiPartFormInputStream),
so the muzzle check fails for Jetty 10.0.0-10.0.9, leaving tests uninstrumented.
- Revert accidental modification of agent-jmxfetch/integrations-core submodule
back to its master pointer.1 parent f8163c2 commit 3ccb046
4 files changed
Lines changed: 14 additions & 6 deletions
File tree
- dd-java-agent
- agent-jmxfetch
- instrumentation/jetty/jetty-server
- jetty-server-10.0
- jetty-server-9.0.4/src/test/groovy/datadog/trace/instrumentation/jetty9
- jetty-server-9.0/src/test/groovy/datadog/trace/instrumentation/jetty9
Submodule integrations-core updated 7572 files
Lines changed: 5 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
52 | | - | |
53 | | - | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
54 | 56 | | |
55 | 57 | | |
56 | 58 | | |
| |||
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
85 | | - | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
86 | 89 | | |
87 | 90 | | |
88 | 91 | | |
| |||
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
85 | 88 | | |
86 | 89 | | |
87 | 90 | | |
| |||
0 commit comments