Skip to content

Commit 45ce7df

Browse files
amarzialimcculls
andauthored
Apply suggestions from code review
Co-authored-by: Stuart McCulloch <stuart.mcculloch@datadoghq.com>
1 parent 20701e9 commit 45ce7df

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

  • dd-java-agent/instrumentation/aws-java

dd-java-agent/instrumentation/aws-java/aws-java-sqs-1.0/src/main/java/datadog/trace/instrumentation/aws/v1/sqs/TracingIterator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ protected void startNewMessageSpan(Message message) {
6969
try {
7070
if (InstrumenterConfig.get().isLegacyContextManagerEnabled()) {
7171
closePrevious(true);
72-
} else {
72+
} else if (message == null) { // previous message span was the last
7373
final AgentSpan previousSpan = spanFromContext(getRootContext().swap());
7474
if (previousSpan != null) {
7575
previousSpan.finishWithEndToEnd();

dd-java-agent/instrumentation/aws-java/aws-java-sqs-2.0/src/main/java/datadog/trace/instrumentation/aws/v2/sqs/TracingIterator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ protected void startNewMessageSpan(Message message) {
7171
try {
7272
if (InstrumenterConfig.get().isLegacyContextManagerEnabled()) {
7373
closePrevious(true);
74-
} else {
74+
} else if (message == null) { // previous message span was the last
7575
final AgentSpan previousSpan = spanFromContext(getRootContext().swap());
7676
if (previousSpan != null) {
7777
previousSpan.finishWithEndToEnd();

0 commit comments

Comments
 (0)