Don't send IO failures to telemetry logs (#10210)

* Don't send IO failures to telemetry logs

* adjust tests

Author: amarziali

internal-api/src/main/java/datadog/trace/relocate/api/IOLogger.java

@@ -1,5 +1,7 @@
 package datadog.trace.relocate.api;
 
+import static datadog.trace.api.telemetry.LogCollector.EXCLUDE_TELEMETRY;
+
 import java.util.concurrent.TimeUnit;
 import org.slf4j.Logger;
 
@@ -24,14 +26,14 @@ public IOLogger(final Logger log) {
    */
   public boolean success(final String format, final Object... arguments) {
     if (log.isDebugEnabled()) {
-      log.debug(format, arguments);
+      log.debug(EXCLUDE_TELEMETRY, format, arguments);
       return true;
     }
 
     if (this.logNextSuccess) {
       this.logNextSuccess = false;
       if (log.isInfoEnabled()) {
-        log.info(format, arguments);
+        log.info(EXCLUDE_TELEMETRY, format, arguments);
         return true;
       }
     }
@@ -67,29 +69,38 @@ public boolean error(final String message, Response response, Exception exceptio
     if (log.isDebugEnabled()) {
       if (response != null) {
         log.debug(
+            EXCLUDE_TELEMETRY,
             "{} Status: {}, Response: {}, Body: {}",
             message,
             response.getStatusCode(),
             response.getMessage(),
             response.getBody());
       } else if (exception != null) {
-        log.debug(message, exception);
+        log.debug(EXCLUDE_TELEMETRY, message, exception);
       } else {
-        log.debug(message);
+        log.debug(EXCLUDE_TELEMETRY, message);
       }
       return true;
     }
     boolean hasLogged;
     if (response != null) {
       hasLogged =
           ratelimitedLogger.warn(
-              "{} Status: {} {}", message, response.getStatusCode(), response.getMessage());
+              EXCLUDE_TELEMETRY,
+              "{} Status: {} {}",
+              message,
+              response.getStatusCode(),
+              response.getMessage());
     } else if (exception != null) {
       // NOTE: We do not pass the full exception to warn on purpose. We don't want to
       //       print a full stacktrace unless we're in debug mode
       hasLogged =
           ratelimitedLogger.warn(
-              "{} {}: {}", message, exception.getClass().getName(), exception.getMessage());
+              EXCLUDE_TELEMETRY,
+              "{} {}: {}",
+              message,
+              exception.getClass().getName(),
+              exception.getMessage());
     } else {
       hasLogged = ratelimitedLogger.warn(message);
     }

internal-api/src/test/groovy/datadog/trace/relocate/api/IOLoggerTest.groovy

@@ -1,5 +1,7 @@
 package datadog.trace.relocate.api
 
+import static datadog.trace.api.telemetry.LogCollector.EXCLUDE_TELEMETRY
+
 import datadog.trace.test.util.DDSpecification
 import org.slf4j.Logger
 
@@ -21,7 +23,7 @@ class IOLoggerTest extends DDSpecification {
     ioLogger.success("test {}", "message")
 
     then:
-    1 * log.debug("test {}", "message")
+    1 * log.debug(EXCLUDE_TELEMETRY, "test {}", "message")
   }
 
   def "Success - Info level"() {
@@ -46,7 +48,7 @@ class IOLoggerTest extends DDSpecification {
     ioLogger.error("test message")
 
     then:
-    1 * log.debug("test message")
+    1 * log.debug(EXCLUDE_TELEMETRY, "test message")
   }
 
   def "Error - Debug level - Response"() {
@@ -59,6 +61,7 @@ class IOLoggerTest extends DDSpecification {
 
     then:
     1 * log.debug(
+      EXCLUDE_TELEMETRY,
       _,
       "test message",
       404,
@@ -76,7 +79,7 @@ class IOLoggerTest extends DDSpecification {
     ioLogger.error("test message", exception)
 
     then:
-    1 * log.debug(
+    1 * log.debug(EXCLUDE_TELEMETRY,
       "test message",
       exception
       )
@@ -104,6 +107,7 @@ class IOLoggerTest extends DDSpecification {
 
     then:
     1 * rateLimitedLogger.warn(
+      EXCLUDE_TELEMETRY,
       _,
       "test message",
       404,
@@ -121,6 +125,7 @@ class IOLoggerTest extends DDSpecification {
 
     then:
     1 * rateLimitedLogger.warn(
+      EXCLUDE_TELEMETRY,
       _,
       "test message",
       "java.lang.RuntimeException",
@@ -140,8 +145,8 @@ class IOLoggerTest extends DDSpecification {
 
     then:
     1 * rateLimitedLogger.warn("test message") >> true
-    1 * log.info("very successful")
-    0 * log.info("very successful again")
+    1 * log.info(EXCLUDE_TELEMETRY,"very successful")
+    0 * log.info(EXCLUDE_TELEMETRY,"very successful again")
   }
 
   def "Unlogged Error Then Success - Info level"() {