fix: Properly run fail directives

Author: bric3

buildSrc/src/main/kotlin/datadog/gradle/plugin/muzzle/tasks/MuzzleTask.kt

@@ -74,13 +74,17 @@ abstract class MuzzleTask @Inject constructor(
   @TaskAction
   fun muzzle() {
     when {
+        // Version-specific task: created by MuzzlePlugin for each resolved artifact.
+        muzzleDirective.isPresent -> {
+          assertMuzzle(muzzleDirective.get())
+        }
+        // Fallback for the root "muzzle" lifecycle task when no pass{} directives are
+        // declared. In that case there are no version-specific pass tasks, so we assert
+        // the instrumentation against its own compile-time classpath as a basic sanity check.
         !project.extensions.getByType<MuzzleExtension>().directives.any { it.assertPass } -> {
           project.logger.info("No muzzle pass directives configured. Asserting pass against instrumentation compile-time dependencies")
           assertMuzzle()
         }
-        muzzleDirective.isPresent -> {
-          assertMuzzle(muzzleDirective.get())
-        }
     }
   }
 

buildSrc/src/test/kotlin/datadog/gradle/plugin/muzzle/MuzzlePluginFunctionalTest.kt

@@ -4,7 +4,6 @@ import datadog.gradle.plugin.GradleFixture
 import datadog.gradle.plugin.MavenRepoFixture
 import org.assertj.core.api.Assertions.assertThat
 import org.gradle.testkit.runner.TaskOutcome.SUCCESS
-import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.api.Test
 import org.junit.jupiter.api.io.TempDir
 import org.junit.jupiter.params.ParameterizedTest
@@ -436,7 +435,6 @@ class MuzzlePluginFunctionalTest {
   }
 
   @Test
-  @Disabled("Current implementation doesn't fail build when fail directive unexpectedly passes - MuzzleTask catches exceptions")
   fun `fail directive that passes validation causes build failure`(@TempDir projectDir: File) {
     val fixture = MuzzlePluginTestFixture(projectDir)
     fixture.writeProject(