Skip to content

Commit 52472e9

Browse files
Revert parts of cov report upload logic
1 parent bd72002 commit 52472e9

4 files changed

Lines changed: 11 additions & 16 deletions

File tree

dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/CiVisibilityCoverageServices.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import datadog.trace.api.civisibility.coverage.CoverageStore;
77
import datadog.trace.api.civisibility.coverage.NoOpCoverageStore;
88
import datadog.trace.civisibility.config.ExecutionSettings;
9-
import datadog.trace.civisibility.config.JvmInfo;
109
import datadog.trace.civisibility.coverage.SkippableAwareCoverageStoreFactory;
1110
import datadog.trace.civisibility.coverage.file.FileCoverageStore;
1211
import datadog.trace.civisibility.coverage.line.LineCoverageStore;
@@ -32,13 +31,7 @@ static class Parent {
3231
Parent(CiVisibilityServices services, CiVisibilityRepoServices repoServices) {
3332
moduleSignalRouter = new ModuleSignalRouter();
3433

35-
ExecutionSettings executionSettings =
36-
repoServices.executionSettingsFactory.create(JvmInfo.CURRENT_JVM, null);
37-
CoverageReportUploader coverageReportUploader =
38-
executionSettings.isCodeCoverageReportUploadEnabled()
39-
? new CoverageReportUploader(
40-
services.ciIntake, repoServices.ciTags, services.metricCollector)
41-
: null;
34+
CoverageReportUploader coverageReportUploader = null;
4235

4336
coverageProcessorFactory =
4437
new JacocoCoverageProcessor.Factory(

dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/CiVisibilityServices.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ public class CiVisibilityServices {
8686
this.config = config;
8787
this.metricCollector = metricCollector;
8888
this.backendApi = new BackendApiFactory(config, sco).createBackendApi(Intake.API);
89-
this.ciIntake = new BackendApiFactory(config, sco).createBackendApi(Intake.CI_INTAKE);
89+
this.ciIntake = null;
9090
this.jvmInfoFactory = new CachingJvmInfoFactory(config, new JvmInfoFactoryImpl());
9191
this.gitClientFactory = buildGitClientFactory(config, metricCollector);
9292

dd-java-agent/instrumentation/gradle/gradle-3.0/src/main/groovy/datadog/trace/instrumentation/gradle/legacy/GradleProjectConfigurator.groovy

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,12 +187,12 @@ class GradleProjectConfigurator {
187187

188188
private void configureJacoco(Project project, BuildSessionSettings sessionSettings) {
189189
def config = Config.get()
190-
if (project.plugins.hasPlugin(JACOCO_PLUGIN_ID)) {
191-
// Jacoco is already configured for this project
190+
if (!config.isCiVisibilityJacocoPluginVersionProvided() && !sessionSettings.isCoverageReportUploadEnabled()) {
192191
return
193192
}
194193

195-
if (!config.isCiVisibilityJacocoPluginVersionProvided() && !sessionSettings.isCoverageReportUploadEnabled()) {
194+
if (project.plugins.hasPlugin(JACOCO_PLUGIN_ID)) {
195+
// Jacoco is already configured for this project
196196
return
197197
}
198198

dd-java-agent/instrumentation/maven/maven-3.2.1/src/main/java/datadog/trace/instrumentation/maven3/MavenProjectConfigurator.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -245,12 +245,14 @@ private static Xpp3Dom addAnnotationProcessorPath(
245245
void configureJacoco(
246246
MavenSession session, MavenProject project, BuildSessionSettings sessionSettings) {
247247
excludeDatadogClassLoaderFromJacocoInstrumentation(project);
248-
if (runsWithJacoco(session, project)) {
249-
// Jacoco is already configured for this project
250-
return;
251-
}
252248
if (Config.get().isCiVisibilityJacocoPluginVersionProvided()
253249
|| sessionSettings.isCoverageReportUploadEnabled()) {
250+
251+
if (runsWithJacoco(session, project)) {
252+
// Jacoco is already configured for this project
253+
return;
254+
}
255+
254256
configureJacocoPlugin(project, sessionSettings);
255257
}
256258
}

0 commit comments

Comments
 (0)