Skip to content

Commit 5661257

Browse files
authored
Merge branch 'master' into sarahchen6/g2j-components
2 parents ecf9f02 + 77900be commit 5661257

37 files changed

Lines changed: 683 additions & 104 deletions

File tree

.github/chainguard/self.pin-system-tests.create-pr.sts.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ subject_pattern: repo:DataDog/dd-trace-java:ref:refs/(heads/master|tags/v\d+\.\d
55
claim_pattern:
66
event_name: (workflow_dispatch|push)
77
ref: refs/(heads/master|tags/v\d+\.\d+\.0)
8-
job_workflow_ref: DataDog/dd-trace-java/\.github/workflows/create-release-branch\.yaml@refs/heads/master
8+
job_workflow_ref: DataDog/dd-trace-java/\.github/workflows/create-release-branch\.yaml@refs/(heads/master|tags/v\d+\.\d+\.0)
99

1010
permissions:
1111
contents: write

.github/workflows/analyze-changes.yaml

Lines changed: 8 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
${{ runner.os }}-gradle-
3131
3232
- name: Initialize CodeQL
33-
uses: github/codeql-action/init@89a39a4e59826350b863aa6b6252a07ad50cf83e # v4.32.4
33+
uses: github/codeql-action/init@c793b717bc78562f491db7b0e93a3a178b099162 # v4.32.5
3434
with:
3535
languages: 'java'
3636
build-mode: 'manual'
@@ -39,17 +39,11 @@ jobs:
3939
env:
4040
ORG_GRADLE_PROJECT_akkaRepositoryToken: ${{ secrets.AKKA_REPO_TOKEN }}
4141
run: |
42-
GRADLE_OPTS="-Dorg.gradle.jvmargs='-Xmx3G -Xms2G'" \
43-
JAVA_HOME=$JAVA_HOME_8_X64 \
44-
JAVA_8_HOME=$JAVA_HOME_8_X64 \
45-
JAVA_11_HOME=$JAVA_HOME_11_X64 \
46-
JAVA_17_HOME=$JAVA_HOME_17_X64 \
47-
JAVA_21_HOME=$JAVA_HOME_21_X64 \
48-
./gradlew clean :dd-java-agent:shadowJar \
49-
--build-cache --parallel --stacktrace --no-daemon --max-workers=4
42+
GRADLE_OPTS="-Dorg.gradle.jvmargs='-Xms2G -Xmx3G'" \
43+
./gradlew clean :dd-java-agent:shadowJar --build-cache --parallel --stacktrace --no-daemon --max-workers=4
5044
5145
- name: Perform CodeQL Analysis and upload results to GitHub Security tab
52-
uses: github/codeql-action/analyze@89a39a4e59826350b863aa6b6252a07ad50cf83e # v4.32.4
46+
uses: github/codeql-action/analyze@c793b717bc78562f491db7b0e93a3a178b099162 # v4.32.5
5347

5448
trivy:
5549
name: Analyze changes with Trivy
@@ -85,14 +79,8 @@ jobs:
8579
env:
8680
ORG_GRADLE_PROJECT_akkaRepositoryToken: ${{ secrets.AKKA_REPO_TOKEN }}
8781
run: |
88-
GRADLE_OPTS="-Dorg.gradle.jvmargs='-Xmx3G -Xms2G'" \
89-
JAVA_HOME=$JAVA_HOME_8_X64 \
90-
JAVA_8_HOME=$JAVA_HOME_8_X64 \
91-
JAVA_11_HOME=$JAVA_HOME_11_X64 \
92-
JAVA_17_HOME=$JAVA_HOME_17_X64 \
93-
JAVA_21_HOME=$JAVA_HOME_21_X64 \
94-
./gradlew clean publishToMavenLocal \
95-
--build-cache --parallel --stacktrace --no-daemon --max-workers=4
82+
GRADLE_OPTS="-Dorg.gradle.jvmargs='-Xms2G -Xmx3G'" \
83+
./gradlew clean publishToMavenLocal --build-cache --parallel --stacktrace --no-daemon --max-workers=4
9684
9785
- name: Copy published artifacts
9886
run: |
@@ -101,7 +89,7 @@ jobs:
10189
ls -laR "./workspace/.trivy"
10290
10391
- name: Run Trivy security scanner
104-
uses: aquasecurity/trivy-action@e368e328979b113139d6f9068e03accaed98a518 # v0.34.1
92+
uses: aquasecurity/trivy-action@97e0b3872f55f89b95b2f65b3dbab56962816478 # v0.34.2
10593
with:
10694
scan-type: rootfs
10795
scan-ref: './workspace/.trivy/'
@@ -114,7 +102,7 @@ jobs:
114102
TRIVY_JAVA_DB_REPOSITORY: ghcr.io/aquasecurity/trivy-java-db,public.ecr.aws/aquasecurity/trivy-java-db
115103

116104
- name: Upload Trivy scan results to GitHub Security tab
117-
uses: github/codeql-action/upload-sarif@89a39a4e59826350b863aa6b6252a07ad50cf83e # v4.32.4
105+
uses: github/codeql-action/upload-sarif@c793b717bc78562f491db7b0e93a3a178b099162 # v4.32.5
118106
if: always()
119107
with:
120108
sarif_file: 'trivy-results.sarif'

.github/workflows/run-system-tests.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
--build-cache --parallel --stacktrace --no-daemon --max-workers=4
5454
5555
- name: Upload artifact
56-
uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f
56+
uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f
5757
with:
5858
name: binaries
5959
path: workspace/dd-java-agent/build/libs/

communication/src/main/java/datadog/communication/ddagent/DDAgentFeaturesDiscovery.java

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
package datadog.communication.ddagent;
22

3-
import static datadog.communication.http.OkHttpUtils.DATADOG_CONTAINER_ID;
43
import static datadog.communication.http.OkHttpUtils.DATADOG_CONTAINER_TAGS_HASH;
4+
import static datadog.communication.http.OkHttpUtils.msgpackRequestBodyOf;
5+
import static datadog.communication.http.OkHttpUtils.prepareRequest;
56
import static datadog.communication.serialization.msgpack.MsgPackWriter.FIXARRAY;
7+
import static java.util.Collections.emptyMap;
68
import static java.util.Collections.emptySet;
79
import static java.util.Collections.singletonList;
810
import static java.util.Collections.unmodifiableSet;
@@ -11,7 +13,6 @@
1113
import com.squareup.moshi.Moshi;
1214
import com.squareup.moshi.Types;
1315
import datadog.common.container.ContainerInfo;
14-
import datadog.communication.http.OkHttpUtils;
1516
import datadog.metrics.api.Monitoring;
1617
import datadog.metrics.api.Recording;
1718
import datadog.metrics.impl.statsd.DDAgentStatsDClientManager;
@@ -151,13 +152,9 @@ private void doDiscovery(State newState) {
151152
// 3. fallback if the endpoint couldn't be found or the response couldn't be parsed
152153
try (Recording recording = discoveryTimer.start()) {
153154
boolean fallback = true;
154-
final Request.Builder requestBuilder =
155-
new Request.Builder().url(agentBaseUrl.resolve("info").url());
156-
final String containerId = ContainerInfo.get().getContainerId();
157-
if (containerId != null) {
158-
requestBuilder.header(DATADOG_CONTAINER_ID, containerId);
159-
}
160-
try (Response response = client.newCall(requestBuilder.build()).execute()) {
155+
final Request request =
156+
prepareRequest(agentBaseUrl.resolve("info"), emptyMap()).get().build();
157+
try (Response response = client.newCall(request).execute()) {
161158
if (response.isSuccessful()) {
162159
processInfoResponseHeaders(response);
163160
fallback = !processInfoResponse(newState, response.body().string());
@@ -202,11 +199,8 @@ private String probeTracesEndpoint(State newState, String[] endpoints) {
202199
try (Response response =
203200
client
204201
.newCall(
205-
new Request.Builder()
206-
.put(
207-
OkHttpUtils.msgpackRequestBodyOf(
208-
singletonList(ByteBuffer.wrap(PROBE_MESSAGE))))
209-
.url(agentBaseUrl.resolve(candidate))
202+
prepareRequest(agentBaseUrl.resolve(candidate), emptyMap())
203+
.put(msgpackRequestBodyOf(singletonList(ByteBuffer.wrap(PROBE_MESSAGE))))
210204
.build())
211205
.execute()) {
212206
if (response.code() != 404) {

0 commit comments

Comments
 (0)