Skip to content

Commit 62334e0

Browse files
authored
Merge branch 'master' into mtoff/otlp-traces-exporter-config
2 parents c0a51a9 + dbb0729 commit 62334e0

4 files changed

Lines changed: 18 additions & 11 deletions

File tree

dd-java-agent/instrumentation/confluent-schema-registry/confluent-schema-registry-4.1/build.gradle

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ muzzle {
88
versions = "[4.1.0,)"
99
// broken POMs: depend on non-existent org.eclipse.jetty:jetty-bom:9.4.59
1010
// can be fixed after https://github.com/confluentinc/kafka-connect-storage-common/issues/468 is resolved
11-
skipVersions += ['7.4.14', '7.5.13', '7.6.10', '7.7.8', '7.8.7']
11+
skipVersions += ['7.4.14', '7.5.13', '7.6.10', '7.7.8', '7.8.7', '7.9.6']
1212
excludeDependency "org.codehaus.jackson:jackson-mapper-asl" // missing on some releases
1313
assertInverse = true
1414
}
@@ -30,4 +30,3 @@ dependencies {
3030

3131
latestDepTestImplementation group: 'io.confluent', name: 'kafka-avro-serializer', version: '+'
3232
}
33-

dd-java-agent/instrumentation/kafka/kafka-connect-0.11/build.gradle

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@ muzzle {
1616
'7.7.8-ce',
1717
'7.7.8-ccs',
1818
'7.8.7-ce',
19-
'7.8.7-ccs'
19+
'7.8.7-ccs',
20+
'7.9.6-ce',
21+
'7.9.6-ccs'
2022
]
2123
excludeDependency "io.confluent.cloud:*"
2224
excludeDependency "io.confluent.observability:*"

dd-java-agent/instrumentation/spring/spring-scheduling-3.1/src/latestDepTest/groovy/SpringSchedulingTest.groovy

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,14 @@ class SpringSchedulingTest extends InstrumentationSpecification {
2525
setup:
2626
def context = new AnnotationConfigApplicationContext(TriggerTaskConfig, SchedulingConfig)
2727
def task = context.getBean(TriggerTask)
28+
def scheduledTaskEndpoint = context.getBean(ScheduledTasksEndpoint)
2829

2930
task.blockUntilExecute()
31+
// Capture cron tasks before closing the context (endpoint is unavailable after close).
32+
def cronTasks = scheduledTaskEndpoint.scheduledTasks().getCron()
33+
// Close the context immediately after the first execution to prevent a second cron
34+
// firing before assertions complete, which would produce extra traces and cause flakiness.
35+
context.close()
3036

3137
expect:
3238
assert task != null
@@ -54,13 +60,10 @@ class SpringSchedulingTest extends InstrumentationSpecification {
5460
}
5561
}
5662
and:
57-
def scheduledTaskEndpoint = context.getBean(ScheduledTasksEndpoint)
5863
assert scheduledTaskEndpoint != null
59-
scheduledTaskEndpoint.scheduledTasks().getCron().each {
64+
cronTasks.each {
6065
it.getRunnable().getTarget() == TriggerTask.getName()
6166
}
62-
cleanup:
63-
context.close()
6467
}
6568

6669
def "schedule interval test"() {

dd-java-agent/instrumentation/spring/spring-scheduling-3.1/src/test/groovy/SpringSchedulingTest.groovy

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,14 @@ class SpringSchedulingTest extends InstrumentationSpecification {
2525
setup:
2626
def context = new AnnotationConfigApplicationContext(TriggerTaskConfig, SchedulingConfig)
2727
def task = context.getBean(TriggerTask)
28+
def scheduledTaskEndpoint = context.getBean(ScheduledTasksEndpoint)
2829

2930
task.blockUntilExecute()
31+
// Capture cron tasks before closing the context (endpoint is unavailable after close).
32+
def cronTasks = scheduledTaskEndpoint.scheduledTasks().getCron()
33+
// Close the context immediately after the first execution to prevent a second cron
34+
// firing before assertions complete, which would produce extra traces and cause flakiness.
35+
context.close()
3036

3137
expect:
3238
assert task != null
@@ -54,13 +60,10 @@ class SpringSchedulingTest extends InstrumentationSpecification {
5460
}
5561
}
5662
and:
57-
def scheduledTaskEndpoint = context.getBean(ScheduledTasksEndpoint)
5863
assert scheduledTaskEndpoint != null
59-
scheduledTaskEndpoint.scheduledTasks().getCron().each {
64+
cronTasks.each {
6065
it.getRunnable().getTarget() == TriggerTask.getName()
6166
}
62-
cleanup:
63-
context.close()
6467
}
6568

6669
def "schedule interval test"() {

0 commit comments

Comments
 (0)