Update record detection for fixed JDK (#12031)

Update record detection for fixed JDK

JDK 25.0.4 fixes the Record with type annotation bug (JDK-8376185) so
we are updating the detection to filter out for this JDK version and
onward

Co-authored-by: devflow.devflow-routing-intake <devflow.devflow-routing-intake@kubernetes.us1.ddbuild.io>

Author: jpbempel

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/agent/ConfigurationUpdater.java

@@ -57,6 +57,8 @@ public class ConfigurationUpdater implements DebuggerContext.ProbeResolver, Conf
   private static final int MINUTES_BETWEEN_ERROR_LOG = 5;
   private static final boolean JAVA_AT_LEAST_19 = JavaVirtualMachine.isJavaVersionAtLeast(19);
   private static final boolean JAVA_AT_LEAST_16 = JavaVirtualMachine.isJavaVersionAtLeast(16);
+  private static final boolean JAVA_AT_LEAST_25_0_4 =
+      JavaVirtualMachine.isJavaVersionAtLeast(25, 0, 4);
   private static final Method GET_RECORD_COMPONENTS_METHOD;
   private static final Method GET_ANNOTATED_TYPES_METHOD;
 
@@ -353,8 +355,9 @@ private static class JDKVersionSpecificHelper {
 
     public static List<Class<?>> detectRecordWithTypeAnnotation(
         Consumer<String> reportError, List<Class<?>> changedClasses) {
-      if (!JAVA_AT_LEAST_16) {
+      if (!JAVA_AT_LEAST_16 || JAVA_AT_LEAST_25_0_4) {
         // records introduced in JDK 16 (final version)
+        // JDK-8376185 fixed since JDK 25.0.4
         return changedClasses;
       }
       List<Class<?>> result = new ArrayList<>();

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/agent/DebuggerTransformer.java

@@ -95,6 +95,8 @@ public class DebuggerTransformer implements ClassFileTransformer {
           SpanProbe.class);
   private static final String JAVA_IO_TMPDIR = "java.io.tmpdir";
   private static final boolean JAVA_AT_LEAST_19 = JavaVirtualMachine.isJavaVersionAtLeast(19);
+  private static final boolean JAVA_AT_LEAST_25_0_4 =
+      JavaVirtualMachine.isJavaVersionAtLeast(25, 0, 4);
   public static Path DUMP_PATH = Paths.get(SystemProperties.get(JAVA_IO_TMPDIR), "debugger");
   private static final String[] SKIPPED_PACKAGES =
       new String[] {
@@ -353,6 +355,9 @@ private boolean checkMethodParameters(
    */
   private boolean checkRecordTypeAnnotation(
       ClassNode classNode, List<ProbeDefinition> definitions, String fullyQualifiedClassName) {
+    if (JAVA_AT_LEAST_25_0_4) {
+      return true;
+    }
     if (!ASMHelper.isRecord(classNode)) {
       return true;
     }

dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/agent/CapturedSnapshotTest.java

@@ -3283,6 +3283,10 @@ public void noInstrumentationForAgentClasses() throws Exception {
   @Test
   @EnabledForJreRange(min = JRE.JAVA_17)
   public void recordWithTypeAnnotation() throws IOException, URISyntaxException {
+    if (JavaVirtualMachine.isJavaVersionAtLeast(25, 0, 4)) {
+      // Fixed since JDK 25.0.4
+      return;
+    }
     final String CLASS_NAME = "com.datadog.debugger.CapturedSnapshot33";
     LogProbe probe1 = createMethodProbeAtExit(PROBE_ID1, CLASS_NAME, "parse", null);
     TestSnapshotListener listener = installProbes(probe1);

dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/agent/ConfigurationUpdaterTest.java

@@ -715,9 +715,10 @@ public void methodParametersAttributeRecord()
   @EnabledForJreRange(min = JRE.JAVA_17)
   public void recordWithTypeAnnotation()
       throws IOException, URISyntaxException, UnmodifiableClassException {
-    // make sure record method are not detected as having methodParameters attribute.
-    // /!\ record canonical constructor has the MethodParameters attribute,
-    // but not returned by Class::getDeclaredMethods()
+    if (JavaVirtualMachine.isJavaVersionAtLeast(25, 0, 4)) {
+      // Fixed since JDK 25.0.4
+      return;
+    }
     final String CLASS_NAME = "com.datadog.debugger.CapturedSnapshot33";
     Map<String, byte[]> buffers = compile(CLASS_NAME, SourceCompiler.DebugInfo.ALL, "17");
     Class<?> testClass = loadClass(CLASS_NAME, buffers);