Skip to content

Commit 65a53a6

Browse files
committed
fixes
1 parent aa036e7 commit 65a53a6

2 files changed

Lines changed: 8 additions & 5 deletions

File tree

dd-java-agent/instrumentation/scala/scala-promise/scala-promise-2.10/src/main/java/datadog/trace/instrumentation/scala210/concurrent/PromiseObjectInstrumentation.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import datadog.trace.bootstrap.ContextStore;
99
import datadog.trace.bootstrap.InstrumentationContext;
1010
import datadog.trace.bootstrap.instrumentation.api.AgentSpan;
11+
import datadog.trace.bootstrap.instrumentation.api.Java8BytecodeBridge;
1112
import datadog.trace.instrumentation.scala.PromiseHelper;
1213
import net.bytebuddy.asm.Advice;
1314
import scala.concurrent.impl.CallbackRunnable;
@@ -44,7 +45,7 @@ public static <T> void afterResolve(@Advice.Return(readOnly = false) Try<T> reso
4445
final Context existing = contextStore.get(resolved);
4546
Try<T> next =
4647
PromiseHelper.getTry(
47-
resolved, span, existing != null ? AgentSpan.fromContext(existing) : null);
48+
resolved, span, existing != null ? Java8BytecodeBridge.spanFromContext(existing) : null);
4849
if (next != resolved) {
4950
contextStore.put(next, span);
5051
resolved = next;

dd-java-agent/instrumentation/scala/scala-promise/scala-promise-2.10/src/main/java/datadog/trace/instrumentation/scala210/concurrent/ScalaPromiseModule.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,16 @@ public String[] helperClassNames() {
5757

5858
@Override
5959
public List<Instrumenter> typeInstrumentations() {
60+
final InstrumenterConfig config = InstrumenterConfig.get();
6061
final List<Instrumenter> instrumenters = new ArrayList<>(3);
6162
instrumenters.add(new CallbackRunnableInstrumentation());
62-
instrumenters.add(new FutureObjectInstrumentation());
63+
if (config.isIntegrationEnabled(singleton("scala_future_object"), true)) {
64+
instrumenters.add(new FutureObjectInstrumentation());
65+
}
6366
// Only enable this if integrations have been enabled and the extra "integration"
6467
// scala_promise_completion_priority has been enabled specifically
65-
if (InstrumenterConfig.get()
66-
.isIntegrationEnabled(
67-
Collections.singletonList("scala_promise_completion_priority"), false)) {
68+
if (config.isIntegrationEnabled(
69+
Collections.singletonList("scala_promise_completion_priority"), false)) {
6870
instrumenters.add(new PromiseObjectInstrumentation());
6971
}
7072
return instrumenters;

0 commit comments

Comments
 (0)