Skip to content

Commit 674ebf5

Browse files
mccullsdevflow.devflow-routing-intake
andauthored
Rename span.attachWithCurrent() to span.attachWithContext() and prefer it over currentContext.with(span).attach() (#11907)
Rename span.attachWithCurrent() to span.attachWithContext() and prefer it over currentContext.with(span).attach() Co-authored-by: devflow.devflow-routing-intake <devflow.devflow-routing-intake@kubernetes.us1.ddbuild.io>
1 parent c21ff33 commit 674ebf5

21 files changed

Lines changed: 21 additions & 38 deletions

File tree

dd-java-agent/instrumentation/axway-api-7.5/src/main/java/datadog/trace/instrumentation/axway/HTTPPluginAdvice.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import static datadog.trace.bootstrap.instrumentation.api.AgentSpan.fromContext;
44
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.startSpan;
5-
import static datadog.trace.bootstrap.instrumentation.api.Java8BytecodeBridge.currentContext;
65
import static datadog.trace.bootstrap.instrumentation.api.Java8BytecodeBridge.rootContext;
76
import static datadog.trace.instrumentation.axway.AxwayHTTPPluginDecorator.DECORATE;
87
import static datadog.trace.instrumentation.axway.AxwayHTTPPluginDecorator.SERVER_TRANSACTION_CLASS;
@@ -21,7 +20,7 @@ public static ContextScope onEnter(@Advice.Argument(value = 2) final Object serv
2120
DECORATE.afterStart(span);
2221
// serverTransaction is like request + connection in one object:
2322
DECORATE.onRequest(span, serverTransaction, serverTransaction, rootContext());
24-
return currentContext().with(span).attach();
23+
return span.attachWithContext();
2524
}
2625

2726
@Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class)

dd-java-agent/instrumentation/finatra-2.9/src/main/java/datadog/trace/instrumentation/finatra/FinatraInstrumentation.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import static datadog.trace.agent.tooling.bytebuddy.matcher.NameMatchers.named;
66
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.activeSpan;
77
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.startSpan;
8-
import static datadog.trace.bootstrap.instrumentation.api.Java8BytecodeBridge.currentContext;
98
import static datadog.trace.bootstrap.instrumentation.api.Java8BytecodeBridge.spanFromContext;
109
import static datadog.trace.bootstrap.instrumentation.decorator.http.HttpResourceDecorator.HTTP_RESOURCE_DECORATOR;
1110
import static datadog.trace.instrumentation.finatra.FinatraDecorator.DECORATE;
@@ -79,7 +78,7 @@ public static ContextScope nameSpan(
7978
DECORATE.afterStart(span);
8079
span.setResourceName(DECORATE.className(clazz));
8180

82-
return currentContext().with(span).attach();
81+
return span.attachWithContext();
8382
}
8483

8584
@Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class)

dd-java-agent/instrumentation/micronaut/micronaut-http-server-netty/micronaut-http-server-netty-common/src/main/java/datadog/trace/instrumentation/micronaut/WriteFinalNettyResponseAdvice.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package datadog.trace.instrumentation.micronaut;
22

3-
import static datadog.trace.bootstrap.instrumentation.api.Java8BytecodeBridge.currentContext;
43
import static datadog.trace.instrumentation.micronaut.MicronautDecorator.DECORATE;
54
import static datadog.trace.instrumentation.micronaut.MicronautDecorator.SPAN_ATTRIBUTE;
65

@@ -20,7 +19,7 @@ public static void beginRequest(
2019
return;
2120
}
2221

23-
try (final ContextScope scope = currentContext().with(span).attach()) {
22+
try (final ContextScope scope = span.attachWithContext()) {
2423
DECORATE.onResponse(span, message);
2524
DECORATE.beforeFinish(scope.context());
2625
span.finish();

dd-java-agent/instrumentation/netty/netty-3.8/src/main/java/datadog/trace/instrumentation/netty38/ChannelFutureListenerInstrumentation.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import static datadog.trace.agent.tooling.bytebuddy.matcher.HierarchyMatchers.implementsInterface;
44
import static datadog.trace.agent.tooling.bytebuddy.matcher.NameMatchers.named;
55
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.startSpan;
6-
import static datadog.trace.bootstrap.instrumentation.api.Java8BytecodeBridge.currentContext;
76
import static datadog.trace.instrumentation.netty38.server.NettyHttpServerDecorator.DECORATE;
87
import static datadog.trace.instrumentation.netty38.server.NettyHttpServerDecorator.NETTY;
98
import static datadog.trace.instrumentation.netty38.server.NettyHttpServerDecorator.NETTY_CONNECT;
@@ -110,7 +109,7 @@ public static AgentScope activateScope(@Advice.Argument(0) final ChannelFuture f
110109

111110
final AgentSpan errorSpan = startSpan("netty", NETTY_CONNECT).setTag(Tags.COMPONENT, "netty");
112111
errorSpan.spanContext().setIntegrationName(NETTY);
113-
try (final ContextScope scope = currentContext().with(errorSpan).attach()) {
112+
try (final ContextScope scope = errorSpan.attachWithContext()) {
114113
DECORATE.onError(errorSpan, cause);
115114
DECORATE.beforeFinish(scope.context());
116115
errorSpan.finish();

dd-java-agent/instrumentation/netty/netty-3.8/src/main/java/datadog/trace/instrumentation/netty38/server/HttpServerResponseTracingHandler.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import static datadog.trace.instrumentation.netty38.server.NettyHttpServerDecorator.DECORATE;
44

5-
import datadog.context.Context;
65
import datadog.context.ContextScope;
76
import datadog.trace.bootstrap.ContextStore;
87
import datadog.trace.bootstrap.instrumentation.api.AgentSpan;
@@ -36,7 +35,7 @@ public void writeRequested(final ChannelHandlerContext ctx, final MessageEvent m
3635
return;
3736
}
3837

39-
try (final ContextScope scope = Context.current().with(span).attach()) {
38+
try (final ContextScope scope = span.attachWithContext()) {
4039
final HttpResponse response = (HttpResponse) msg.getMessage();
4140

4241
try {

dd-java-agent/instrumentation/netty/netty-4.0/src/main/java/datadog/trace/instrumentation/netty40/ChannelFutureListenerInstrumentation.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import static datadog.trace.agent.tooling.bytebuddy.matcher.HierarchyMatchers.implementsInterface;
44
import static datadog.trace.agent.tooling.bytebuddy.matcher.NameMatchers.named;
55
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.startSpan;
6-
import static datadog.trace.bootstrap.instrumentation.api.Java8BytecodeBridge.currentContext;
76
import static datadog.trace.instrumentation.netty40.AttributeKeys.CONNECT_PARENT_CONTINUATION_ATTRIBUTE_KEY;
87
import static datadog.trace.instrumentation.netty40.server.NettyHttpServerDecorator.NETTY;
98
import static datadog.trace.instrumentation.netty40.server.NettyHttpServerDecorator.NETTY_CONNECT;
@@ -95,7 +94,7 @@ public static AgentScope activateScope(@Advice.Argument(0) final ChannelFuture f
9594

9695
final AgentSpan errorSpan = startSpan("netty", NETTY_CONNECT).setTag(Tags.COMPONENT, "netty");
9796
errorSpan.spanContext().setIntegrationName(NETTY);
98-
try (final ContextScope scope = currentContext().with(errorSpan).attach()) {
97+
try (final ContextScope scope = errorSpan.attachWithContext()) {
9998
NettyHttpServerDecorator.DECORATE.onError(errorSpan, cause);
10099
NettyHttpServerDecorator.DECORATE.beforeFinish(scope.context());
101100
errorSpan.finish();

dd-java-agent/instrumentation/netty/netty-4.1/src/main/java/datadog/trace/instrumentation/netty41/ChannelFutureListenerInstrumentation.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import static datadog.trace.agent.tooling.bytebuddy.matcher.HierarchyMatchers.implementsInterface;
44
import static datadog.trace.agent.tooling.bytebuddy.matcher.NameMatchers.named;
55
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.startSpan;
6-
import static datadog.trace.bootstrap.instrumentation.api.Java8BytecodeBridge.currentContext;
76
import static datadog.trace.instrumentation.netty41.AttributeKeys.CONNECT_PARENT_CONTINUATION_ATTRIBUTE_KEY;
87
import static datadog.trace.instrumentation.netty41.server.NettyHttpServerDecorator.NETTY;
98
import static datadog.trace.instrumentation.netty41.server.NettyHttpServerDecorator.NETTY_CONNECT;
@@ -95,7 +94,7 @@ public static AgentScope activateScope(@Advice.Argument(0) final ChannelFuture f
9594

9695
final AgentSpan errorSpan = startSpan("netty", NETTY_CONNECT).setTag(Tags.COMPONENT, "netty");
9796
errorSpan.spanContext().setIntegrationName(NETTY);
98-
try (final ContextScope scope = currentContext().with(errorSpan).attach()) {
97+
try (final ContextScope scope = errorSpan.attachWithContext()) {
9998
NettyHttpServerDecorator.DECORATE.onError(errorSpan, cause);
10099
NettyHttpServerDecorator.DECORATE.beforeFinish(scope.context());
101100
errorSpan.finish();

dd-java-agent/instrumentation/play-ws/play-ws-1.0/src/main/java/datadog/trace/instrumentation/playws1/PlayWSClientInstrumentation.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package datadog.trace.instrumentation.playws1;
22

33
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.startSpan;
4-
import static datadog.trace.bootstrap.instrumentation.api.Java8BytecodeBridge.currentContext;
54
import static datadog.trace.bootstrap.instrumentation.api.Java8BytecodeBridge.spanFromContext;
65
import static datadog.trace.instrumentation.playws.PlayWSClientDecorator.DECORATE;
76
import static datadog.trace.instrumentation.playws.PlayWSClientDecorator.PLAY_WS_REQUEST;
@@ -37,7 +36,7 @@ public static ContextScope methodEnter(
3736
asyncHandler = new AsyncHandlerWrapper(asyncHandler, span);
3837
}
3938

40-
return currentContext().with(span).attach();
39+
return span.attachWithContext();
4140
}
4241

4342
@Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class)

dd-java-agent/instrumentation/play-ws/play-ws-2.0/src/main/java/datadog/trace/instrumentation/playws2/PlayWSClientInstrumentation.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package datadog.trace.instrumentation.playws2;
22

33
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.startSpan;
4-
import static datadog.trace.bootstrap.instrumentation.api.Java8BytecodeBridge.currentContext;
54
import static datadog.trace.bootstrap.instrumentation.api.Java8BytecodeBridge.spanFromContext;
65
import static datadog.trace.instrumentation.playws.PlayWSClientDecorator.DECORATE;
76
import static datadog.trace.instrumentation.playws.PlayWSClientDecorator.PLAY_WS_REQUEST;
@@ -37,7 +36,7 @@ public static ContextScope methodEnter(
3736
asyncHandler = new AsyncHandlerWrapper(asyncHandler, span);
3837
}
3938

40-
return currentContext().with(span).attach();
39+
return span.attachWithContext();
4140
}
4241

4342
@Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class)

dd-java-agent/instrumentation/play-ws/play-ws-2.1/src/main/java/datadog/trace/instrumentation/playws21/PlayWSClientInstrumentation.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package datadog.trace.instrumentation.playws21;
22

33
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.startSpan;
4-
import static datadog.trace.bootstrap.instrumentation.api.Java8BytecodeBridge.currentContext;
54
import static datadog.trace.bootstrap.instrumentation.api.Java8BytecodeBridge.spanFromContext;
65
import static datadog.trace.instrumentation.playws.PlayWSClientDecorator.DECORATE;
76
import static datadog.trace.instrumentation.playws.PlayWSClientDecorator.PLAY_WS_REQUEST;
@@ -37,7 +36,7 @@ public static ContextScope methodEnter(
3736
asyncHandler = new AsyncHandlerWrapper(asyncHandler, span);
3837
}
3938

40-
return currentContext().with(span).attach();
39+
return span.attachWithContext();
4140
}
4241

4342
@Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class)

0 commit comments

Comments
 (0)