Skip to content

Commit 6ee53ad

Browse files
committed
Reuse OtelInstrument
1 parent 5c9c0b0 commit 6ee53ad

10 files changed

Lines changed: 12 additions & 5 deletions

File tree

dd-java-agent/agent-otel/otel-shim/src/main/java/datadog/opentelemetry/shim/metrics/OtelInstrument.java renamed to dd-java-agent/agent-otel/otel-bootstrap/src/main/java/datadog/trace/bootstrap/otel/metrics/OtelInstrument.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
package datadog.opentelemetry.shim.metrics;
1+
package datadog.trace.bootstrap.otel.metrics;
22

33
import datadog.trace.bootstrap.otel.metrics.data.OtelMetricStorage;
44

55
/** Ensure all instruments implement the same equivalency. */
6-
abstract class OtelInstrument {
7-
final OtelMetricStorage storage;
6+
public abstract class OtelInstrument {
7+
protected final OtelMetricStorage storage;
88

9-
OtelInstrument(OtelMetricStorage storage) {
9+
protected OtelInstrument(OtelMetricStorage storage) {
1010
this.storage = storage;
1111
}
1212

dd-java-agent/agent-otel/otel-shim/src/main/java/datadog/opentelemetry/shim/metrics/OtelDoubleCounter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import static datadog.trace.bootstrap.otel.metrics.OtelInstrumentBuilder.ofDoubles;
44
import static datadog.trace.bootstrap.otel.metrics.OtelInstrumentType.COUNTER;
55

6+
import datadog.trace.bootstrap.otel.metrics.OtelInstrument;
67
import datadog.trace.bootstrap.otel.metrics.OtelInstrumentBuilder;
78
import datadog.trace.bootstrap.otel.metrics.data.OtelMetricStorage;
89
import datadog.trace.relocate.api.RatelimitedLogger;

dd-java-agent/agent-otel/otel-shim/src/main/java/datadog/opentelemetry/shim/metrics/OtelDoubleGauge.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import static datadog.trace.bootstrap.otel.metrics.OtelInstrumentBuilder.ofDoubles;
44
import static datadog.trace.bootstrap.otel.metrics.OtelInstrumentType.GAUGE;
55

6+
import datadog.trace.bootstrap.otel.metrics.OtelInstrument;
67
import datadog.trace.bootstrap.otel.metrics.OtelInstrumentBuilder;
78
import datadog.trace.bootstrap.otel.metrics.data.OtelMetricStorage;
89
import io.opentelemetry.api.common.Attributes;

dd-java-agent/agent-otel/otel-shim/src/main/java/datadog/opentelemetry/shim/metrics/OtelDoubleHistogram.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import static java.util.Arrays.asList;
77
import static java.util.Collections.emptyList;
88

9+
import datadog.trace.bootstrap.otel.metrics.OtelInstrument;
910
import datadog.trace.bootstrap.otel.metrics.OtelInstrumentBuilder;
1011
import datadog.trace.bootstrap.otel.metrics.data.OtelMetricStorage;
1112
import datadog.trace.relocate.api.RatelimitedLogger;

dd-java-agent/agent-otel/otel-shim/src/main/java/datadog/opentelemetry/shim/metrics/OtelDoubleUpDownCounter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import static datadog.trace.bootstrap.otel.metrics.OtelInstrumentBuilder.ofDoubles;
44
import static datadog.trace.bootstrap.otel.metrics.OtelInstrumentType.UP_DOWN_COUNTER;
55

6+
import datadog.trace.bootstrap.otel.metrics.OtelInstrument;
67
import datadog.trace.bootstrap.otel.metrics.OtelInstrumentBuilder;
78
import datadog.trace.bootstrap.otel.metrics.data.OtelMetricStorage;
89
import io.opentelemetry.api.common.Attributes;

dd-java-agent/agent-otel/otel-shim/src/main/java/datadog/opentelemetry/shim/metrics/OtelLongCounter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import static datadog.trace.bootstrap.otel.metrics.OtelInstrumentBuilder.ofLongs;
44
import static datadog.trace.bootstrap.otel.metrics.OtelInstrumentType.COUNTER;
55

6+
import datadog.trace.bootstrap.otel.metrics.OtelInstrument;
67
import datadog.trace.bootstrap.otel.metrics.OtelInstrumentBuilder;
78
import datadog.trace.bootstrap.otel.metrics.data.OtelMetricStorage;
89
import datadog.trace.relocate.api.RatelimitedLogger;

dd-java-agent/agent-otel/otel-shim/src/main/java/datadog/opentelemetry/shim/metrics/OtelLongGauge.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import static datadog.trace.bootstrap.otel.metrics.OtelInstrumentBuilder.ofLongs;
44
import static datadog.trace.bootstrap.otel.metrics.OtelInstrumentType.GAUGE;
55

6+
import datadog.trace.bootstrap.otel.metrics.OtelInstrument;
67
import datadog.trace.bootstrap.otel.metrics.OtelInstrumentBuilder;
78
import datadog.trace.bootstrap.otel.metrics.data.OtelMetricStorage;
89
import io.opentelemetry.api.common.Attributes;

dd-java-agent/agent-otel/otel-shim/src/main/java/datadog/opentelemetry/shim/metrics/OtelLongHistogram.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import static datadog.trace.bootstrap.otel.metrics.data.OtelMetricStorage.newHistogramStorage;
77
import static java.util.stream.Collectors.toList;
88

9+
import datadog.trace.bootstrap.otel.metrics.OtelInstrument;
910
import datadog.trace.bootstrap.otel.metrics.OtelInstrumentBuilder;
1011
import datadog.trace.bootstrap.otel.metrics.data.OtelMetricStorage;
1112
import datadog.trace.relocate.api.RatelimitedLogger;

dd-java-agent/agent-otel/otel-shim/src/main/java/datadog/opentelemetry/shim/metrics/OtelLongUpDownCounter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import static datadog.trace.bootstrap.otel.metrics.OtelInstrumentBuilder.ofLongs;
44
import static datadog.trace.bootstrap.otel.metrics.OtelInstrumentType.UP_DOWN_COUNTER;
55

6+
import datadog.trace.bootstrap.otel.metrics.OtelInstrument;
67
import datadog.trace.bootstrap.otel.metrics.OtelInstrumentBuilder;
78
import datadog.trace.bootstrap.otel.metrics.data.OtelMetricStorage;
89
import io.opentelemetry.api.common.Attributes;

dd-java-agent/instrumentation/opentelemetry/opentelemetry-1.47/src/main/java/datadog/trace/instrumentation/opentelemetry147/OpenTelemetryMetricsInstrumentation.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ public String[] helperClassNames() {
6464
"datadog.opentelemetry.shim.metrics.OtelMeter",
6565
"datadog.opentelemetry.shim.metrics.OtelMeterBuilder",
6666
"datadog.opentelemetry.shim.metrics.OtelMeterProvider",
67-
"datadog.opentelemetry.shim.metrics.OtelInstrument",
6867
"datadog.opentelemetry.shim.metrics.OtelDoubleCounter",
6968
"datadog.opentelemetry.shim.metrics.OtelDoubleCounter$Builder",
7069
"datadog.opentelemetry.shim.metrics.OtelDoubleGauge",

0 commit comments

Comments
 (0)