Address review feedback

- Restore refreshAcessTime as a deprecated forwarding alias to
  preserve binary compatibility for any existing callers compiled
  against the prior artifact.
- Drop reflection in GenerationalUtf8CacheTest by making the eden
  and tenured entry arrays package-visible.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: dougqh

communication/src/main/java/datadog/communication/serialization/GenerationalUtf8Cache.java

@@ -85,10 +85,10 @@ public final class GenerationalUtf8Cache implements EncodingCache {
 
   static final int MAX_ENTRY_LEN = 256;
 
-  private final CacheEntry[] edenEntries;
+  final CacheEntry[] edenEntries;
   private final int[] edenMarkers;
 
-  private final CacheEntry[] tenuredEntries;
+  final CacheEntry[] tenuredEntries;
 
   private long accessTimeMs;
   private double promotionThreshold = INITIAL_PROMOTION_THRESHOLD;
@@ -147,6 +147,12 @@ public void refreshAccessTime() {
     this.updateAccessTime(System.currentTimeMillis());
   }
 
+  /** Deprecated in favor of {@link #refreshAccessTime()} - retained for binary compatibility. */
+  @Deprecated
+  public void refreshAcessTime() {
+    this.refreshAccessTime();
+  }
+
   public synchronized void recalibrate() {
     this.recalibrate(System.currentTimeMillis());
   }

communication/src/test/java/datadog/communication/serialization/GenerationalUtf8CacheTest.java

@@ -6,7 +6,6 @@
 import static org.junit.jupiter.api.Assertions.assertNotSame;
 import static org.junit.jupiter.api.Assertions.assertSame;
 
-import java.lang.reflect.Field;
 import java.nio.charset.StandardCharsets;
 import java.util.Random;
 import java.util.concurrent.ThreadLocalRandom;
@@ -91,7 +90,7 @@ public void caching() {
   }
 
   @Test
-  public void getUtf8_perCallAccessTime_overridesField() throws Exception {
+  public void getUtf8_perCallAccessTime_overridesField() {
     GenerationalUtf8Cache cache = create();
     // The field value should not leak into the entry when an explicit time is supplied.
     cache.updateAccessTime(0L);
@@ -236,27 +235,22 @@ static final String nextValue() {
     return baseString + valueSuffix;
   }
 
-  static long lookupEdenLastUsedMs(GenerationalUtf8Cache cache, String value) throws Exception {
-    return lookupLastUsedMs(cache, "edenEntries", value);
+  static long lookupEdenLastUsedMs(GenerationalUtf8Cache cache, String value) {
+    return lookupLastUsedMs(cache.edenEntries, "edenEntries", value);
   }
 
-  static long lookupTenuredLastUsedMs(GenerationalUtf8Cache cache, String value) throws Exception {
-    return lookupLastUsedMs(cache, "tenuredEntries", value);
+  static long lookupTenuredLastUsedMs(GenerationalUtf8Cache cache, String value) {
+    return lookupLastUsedMs(cache.tenuredEntries, "tenuredEntries", value);
   }
 
-  private static long lookupLastUsedMs(GenerationalUtf8Cache cache, String fieldName, String value)
-      throws Exception {
-    Field arrayField = GenerationalUtf8Cache.class.getDeclaredField(fieldName);
-    arrayField.setAccessible(true);
-    GenerationalUtf8Cache.CacheEntry[] entries =
-        (GenerationalUtf8Cache.CacheEntry[]) arrayField.get(cache);
-
+  private static long lookupLastUsedMs(
+      GenerationalUtf8Cache.CacheEntry[] entries, String arrayName, String value) {
     for (GenerationalUtf8Cache.CacheEntry entry : entries) {
       if (entry != null && value.equals(entry.value)) {
         return entry.lastUsedMs();
       }
     }
-    throw new AssertionError("entry for value '" + value + "' not found in " + fieldName);
+    throw new AssertionError("entry for value '" + value + "' not found in " + arrayName);
   }
 
   static final void printStats(GenerationalUtf8Cache cache) {