No captures in eval errors snapshots (#11973)

No captures in eval errors snapshots

for Log line probe captures was included even though there is an
evaluation error while for method probe it was not included
make sure we are only including captures if no eval errors

Co-authored-by: devflow.devflow-routing-intake <devflow.devflow-routing-intake@kubernetes.us1.ddbuild.io>

Author: jpbempel

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/LogProbe.java

@@ -834,6 +834,13 @@ public void commit(CapturedContext lineContext, int line) {
     Snapshot snapshot = createSnapshot();
     boolean shouldCommit = false;
     if (status.shouldSend()) {
+      if (isFullSnapshot()) {
+        // freeze context just before commit because line probes have only one context
+        Duration timeout =
+            Duration.ofMillis(Config.get().getDynamicInstrumentationCaptureTimeout());
+        lineContext.freeze(TimeoutChecker.create(Config.get(), timeout));
+        snapshot.addLine(lineContext, line);
+      }
       snapshot.setTraceId(CorrelationIdentifier.getTraceId());
       snapshot.setSpanId(CorrelationIdentifier.getSpanId());
       snapshot.setMessage(status.getMessage());
@@ -846,13 +853,6 @@ public void commit(CapturedContext lineContext, int line) {
     if (shouldCommit) {
       incrementBudget();
       if (inBudget()) {
-        if (isFullSnapshot()) {
-          // freeze context just before commit because line probes have only one context
-          Duration timeout =
-              Duration.ofMillis(Config.get().getDynamicInstrumentationCaptureTimeout());
-          lineContext.freeze(TimeoutChecker.create(Config.get(), timeout));
-          snapshot.addLine(lineContext, line);
-        }
         commitSnapshot(snapshot, sink);
         return;
       }

dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/agent/CapturedSnapshotTest.java

@@ -1249,6 +1249,26 @@ public void lineProbeCondition() throws IOException, URISyntaxException {
         "5");
   }
 
+  @Test
+  public void lineProbeConditionFailed() throws IOException, URISyntaxException {
+    final String CLASS_NAME = "CapturedSnapshot08";
+    int line = getLineForLineProbe(CLASS_NAME, LINE_PROBE_ID1);
+    LogProbe logProbe =
+        createProbeBuilder(LINE_PROBE_ID1, CLASS_NAME, line)
+            .when(
+                new ProbeCondition(DSL.when(DSL.eq(ref("foobar"), nullValue())), "foobar == null"))
+            .build();
+    TestSnapshotListener listener = installProbes(logProbe);
+    Class<?> testClass = compileAndLoadClass(CLASS_NAME);
+    int result = Reflect.onClass(testClass).call("main", "0").get();
+    assertEquals(3, result);
+    Snapshot snapshot = assertOneSnapshot(LINE_PROBE_ID1, listener);
+    assertNull(snapshot.getCaptures().getLines());
+    assertEquals(1, snapshot.getEvaluationErrors().size());
+    assertEquals(
+        "Cannot dereference field: foobar", snapshot.getEvaluationErrors().get(0).getMessage());
+  }
+
   @Test
   public void staticFieldCondition() throws IOException, URISyntaxException {
     final String CLASS_NAME = "com.datadog.debugger.CapturedSnapshot19";