Skip to content

Commit 7a6cdac

Browse files
mccullsdevflow.devflow-routing-intake
authored andcommitted
Exclude patched OkHttp classes and trivial I/O classes from coverage (#11770)
Exclude patched OkHttp classes and trivial I/O classes from coverage Remove unused matches(CacheEntry) method Co-authored-by: devflow.devflow-routing-intake <devflow.devflow-routing-intake@kubernetes.us1.ddbuild.io>
1 parent 3480d0f commit 7a6cdac

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

communication/build.gradle.kts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,12 @@ dependencies {
3939
extra["minimumBranchCoverage"] = 0.5
4040
extra["minimumInstructionCoverage"] = 0.8
4141
extra["excludedClassesCoverage"] = listOf(
42+
"okhttp3.internal.PatchUtil",
43+
"okhttp3.internal.PatchUtil.1",
44+
"okhttp3.internal.PatchUtil.2",
45+
"okhttp3.internal.platform.PatchPlatform",
4246
"datadog.communication.ddagent.ExternalAgentLauncher",
47+
"datadog.communication.ddagent.NoopFeaturesDiscovery",
4348
"datadog.communication.ddagent.ExternalAgentLauncher.NamedPipeHealthCheck",
4449
"datadog.communication.ddagent.SharedCommunicationObjects.FixedConfigUrlSupplier",
4550
"datadog.communication.ddagent.SharedCommunicationObjects.RetryConfigUrlSupplier",
@@ -56,6 +61,7 @@ extra["excludedClassesCoverage"] = listOf(
5661
"datadog.communication.IntakeApi",
5762
"datadog.communication.util.IOUtils",
5863
"datadog.communication.util.IOUtils.1",
64+
"datadog.communication.http.SocketUtils",
5965
)
6066
extra["excludedClassesBranchCoverage"] = listOf(
6167
"datadog.communication.ddagent.TracerVersion",

communication/src/main/java/datadog/communication/serialization/SimpleUtf8Cache.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -179,10 +179,6 @@ public CacheEntry(int adjHash, String value) {
179179
this.valueUtf8 = utf8(value);
180180
}
181181

182-
boolean matches(CacheEntry thatEntry) {
183-
return (this == thatEntry) || this.matches(thatEntry.adjHash, thatEntry.value);
184-
}
185-
186182
boolean matches(int adjHash, String value) {
187183
return (this.adjHash == adjHash) && value.equals(this.value);
188184
}

0 commit comments

Comments
 (0)