Skip to content

Commit 7a9abad

Browse files
committed
fix: Fix test names to be unique
1 parent 8c1f7d8 commit 7a9abad

File tree

3 files changed

+15
-21
lines changed

3 files changed

+15
-21
lines changed

dd-java-agent/instrumentation/reactor-core-3.1/src/test/groovy/ReactorCoreTest.groovy

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@ class ReactorCoreTest extends AgentTestRunner {
357357
"basic flux" | 2 | { -> Flux.fromIterable([1, 2]).map(addOne) }
358358
}
359359

360-
def "Fluxes produce the right number of results '#scheduler'"() {
360+
def "Fluxes produce the right number of results on '#schedulerName' scheduler"() {
361361
when:
362362
List<String> values = Flux.fromIterable(Arrays.asList(1, 2, 3, 4))
363363
.parallel()
@@ -371,12 +371,11 @@ class ReactorCoreTest extends AgentTestRunner {
371371
values.size() == 4
372372

373373
where:
374-
scheduler << [
375-
Schedulers.parallel(),
376-
Schedulers.elastic(),
377-
Schedulers.single(),
378-
Schedulers.immediate()
379-
]
374+
schedulerName | scheduler
375+
"parallel" | Schedulers.parallel()
376+
"elastic" | Schedulers.elastic()
377+
"single" | Schedulers.single()
378+
"immediate" | Schedulers.immediate()
380379
}
381380

382381
@Trace(operationName = "trace-parent", resourceName = "trace-parent")

dd-java-agent/instrumentation/rxjava-2/src/test/groovy/RxJava2Test.groovy

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,7 @@ class RxJava2Test extends AgentTestRunner {
359359
"basic flowable" | 2 | { -> Flowable.fromIterable([1, 2]).map(addOne) }
360360
}
361361

362-
def "Flowables produce the right number of results '#scheduler'"() {
362+
def "Flowables produce the right number of results on '#schedulerName' scheduler"() {
363363
when:
364364
List<String> values = Flowable.fromIterable(Arrays.asList(1, 2, 3, 4))
365365
.parallel()
@@ -373,12 +373,11 @@ class RxJava2Test extends AgentTestRunner {
373373
values.size() == 4
374374

375375
where:
376-
scheduler << [
377-
Schedulers.newThread(),
378-
Schedulers.computation(),
379-
Schedulers.single(),
380-
Schedulers.trampoline()
381-
]
376+
schedulerName | scheduler
377+
"new-thread" | Schedulers.newThread()
378+
"computation" | Schedulers.computation()
379+
"single" | Schedulers.single()
380+
"trampoline" | Schedulers.trampoline()
382381
}
383382

384383
@Trace(operationName = "trace-parent", resourceName = "trace-parent")

remote-config/src/test/groovy/datadog/remoteconfig/ConfigurationPollerSpecification.groovy

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,8 @@
1+
package datadog.remoteconfig
2+
13
import cafe.cryptography.ed25519.Ed25519PrivateKey
24
import cafe.cryptography.ed25519.Ed25519PublicKey
35
import cafe.cryptography.ed25519.Ed25519Signature
4-
import datadog.remoteconfig.ConfigurationChangesListener
5-
import datadog.remoteconfig.ConfigurationChangesTypedListener
6-
import datadog.remoteconfig.ConfigurationDeserializer
7-
import datadog.remoteconfig.ConfigurationPoller
8-
import datadog.remoteconfig.JsonCanonicalizer
9-
import datadog.remoteconfig.Product
106
import datadog.remoteconfig.state.ProductListener
117
import datadog.trace.api.Config
128
import datadog.trace.test.util.DDSpecification
@@ -1108,7 +1104,7 @@ class ConfigurationPollerSpecification extends DDSpecification {
11081104
]
11091105
}
11101106

1111-
void 'reportable errors'() {
1107+
void 'reportable errors #errorMsg'() {
11121108
when:
11131109
poller.addListener(Product.ASM_DD,
11141110
{ throw new RuntimeException('should not be called') } as ConfigurationDeserializer,

0 commit comments

Comments
 (0)