Clean up

Author: sarahchen6

.github/scripts/dependency_age.py

@@ -166,7 +166,6 @@ def select_gradle_release(args: argparse.Namespace) -> int:
 
     return emit_selection_result(
         label="Gradle",
-        cutoff=cutoff,
         github_output=args.github_output,
         candidates=candidates,
         not_found_reason=(
@@ -199,7 +198,6 @@ def select_maven_release(args: argparse.Namespace) -> int:
 
     return emit_selection_result(
         label=f"{args.group_id}:{args.artifact_id}",
-        cutoff=cutoff,
         github_output=args.github_output,
         candidates=candidates,
         not_found_reason=(
@@ -282,7 +280,6 @@ def _version_sort_key(version: str) -> tuple:
 def emit_selection_result(
     *,
     label: str,
-    cutoff: datetime,
     github_output: str | None,
     candidates: list[Candidate],
     not_found_reason: str,
@@ -423,7 +420,7 @@ def revert_lockfiles_to_baseline(
 
 # look up the publish timestamp for a group:artifact:version coordinate in Maven Central
 # returns (datetime, None) on success, (None, reason) when the timestamp cannot be determined
-# retries once on transient 5xx / network errors; 4xx fails immediately (permanent client error)
+# retries once on any error
 def resolve_gav_timestamp(
     *,
     gav: str,
@@ -449,11 +446,6 @@ def resolve_gav_timestamp(
             fetch_error = None
             break
         except urllib.error.HTTPError as exc:
-            if exc.code < 500:
-                return None, (
-                    f"Maven Central returned HTTP {exc.code} for {gav}. "
-                    "Add an entry in --metadata-file to bypass."
-                )
             fetch_error = f"Maven Central search failed (HTTP {exc.code})."
         except (urllib.error.URLError, TimeoutError, OSError, ValueError):
             fetch_error = "Maven Central search was unreachable."

.github/scripts/tests/test_dependency_age.py

@@ -180,31 +180,6 @@ def test_keeps_current_version_when_higher_than_eligible(self) -> None:
         self.assertEqual(outputs["version"], "4.0.0-beta-3")
         self.assertEqual(outputs["published_at"], "")
 
-    def test_updates_when_eligible_version_is_higher_than_current(self) -> None:
-        result = self.run_script(
-            "select-maven",
-            "--now",
-            NOW,
-            "--group-id",
-            "org.apache.maven.plugins",
-            "--artifact-id",
-            "maven-surefire-plugin",
-            "--search-response-file",
-            str(FIXTURES / "surefire-boundary.json"),
-            "--prerelease-pattern",
-            "alpha",
-            "--prerelease-pattern",
-            "beta",
-            "--current-version",
-            "3.5.4",
-        )
-
-        self.assertEqual(result.returncode, 0, result.stderr)
-        outputs = self.parse_outputs(result.stdout)
-        self.assertEqual(outputs["found"], "true")
-        self.assertEqual(outputs["version"], "3.5.5")
-        self.assertEqual(outputs["published_at"], "2026-04-22")
-
     def test_keeps_current_version_when_no_eligible_version_exists(self) -> None:
         result = self.run_script(
             "select-gradle",
@@ -303,22 +278,6 @@ def test_reverts_lockfile_when_any_changed_dependency_is_too_new(self) -> None:
         self.assertEqual(outputs["reverted_files"], "1")
         self.assertEqual((current_dir / "module/gradle.lockfile").read_text(encoding="utf-8"), baseline_content)
 
-    def test_reverts_lockfile_when_one_of_multiple_coexisting_versions_is_too_new(self) -> None:
-        baseline_content = "# lockfile\ncom.typesafe:config:1.3.1=compileClasspath\ncom.typesafe:config:1.4.4=runtimeClasspath\n"
-        current_content  = "# lockfile\ncom.typesafe:config:1.3.1=compileClasspath\ncom.typesafe:config:1.5.0=runtimeClasspath\n"
-        metadata = {
-            "com.typesafe:config:1.5.0": "2026-04-24T11:00:00Z",  # too new
-        }
-
-        result, current_dir = self.run_validate_lockfiles(
-            baseline={"module/gradle.lockfile": baseline_content},
-            current={"module/gradle.lockfile": current_content},
-            metadata=metadata,
-        )
-
-        self.assertEqual(result.returncode, 0, result.stderr)
-        self.assertEqual((current_dir / "module/gradle.lockfile").read_text(encoding="utf-8"), baseline_content)
-
     def test_removes_brand_new_lockfile_with_too_new_dependency(self) -> None:
         # A brand-new module has no baseline counterpart — the lockfile should be removed.
         # So include an unchanged pre-existing lockfile in both baseline and current to satisfy
@@ -358,19 +317,6 @@ def test_reverts_lockfile_when_metadata_lookup_fails(self) -> None:
         self.assertIn("::warning", result.stdout)
         self.assertEqual((current_dir / "module/gradle.lockfile").read_text(encoding="utf-8"), baseline_content)
 
-    def test_fails_when_baseline_has_no_lockfiles_but_current_does(self) -> None:
-        # empty baseline with lockfiles in current suggests the snapshot step failed
-        current_content = "# lockfile\ncom.example:lib:1.0.0=runtimeClasspath\n"
-
-        result, _ = self.run_validate_lockfiles(
-            baseline={},
-            current={"module/gradle.lockfile": current_content},
-            metadata={},
-        )
-
-        self.assertEqual(result.returncode, 1, result.stderr)
-        self.assertIn("::error::Baseline has no lockfiles", result.stdout)
-
     def test_exits_cleanly_when_lockfiles_are_identical(self) -> None:
         # no changes between baseline and current -> exit 0 with reverted_files=0
         content = "# lockfile\ncom.example:lib:1.0.0=runtimeClasspath\n"

.github/workflows/update-gradle-dependencies.yaml

@@ -45,6 +45,7 @@ jobs:
 
       - name: Snapshot current Gradle lock files
         run: |
+          rm -rf /tmp/gradle-lockfiles-before
           mkdir -p /tmp/gradle-lockfiles-before
           find . -name 'gradle.lockfile' -print0 | xargs -0 -r cp --parents -t /tmp/gradle-lockfiles-before/