Use integer agentless polling durations

Author: leoromanovsky

dd-trace-api/src/main/java/datadog/trace/api/ConfigDefaults.java

@@ -50,10 +50,9 @@ public final class ConfigDefaults {
   static final String DEFAULT_SITE = "datadoghq.com";
 
   public static final String DEFAULT_FEATURE_FLAGGING_CONFIGURATION_SOURCE = "agentless";
-  public static final double DEFAULT_FEATURE_FLAGGING_CONFIGURATION_SOURCE_POLL_INTERVAL_SECONDS =
-      30.0D;
-  public static final double DEFAULT_FEATURE_FLAGGING_CONFIGURATION_SOURCE_REQUEST_TIMEOUT_SECONDS =
-      2.0D;
+  public static final int DEFAULT_FEATURE_FLAGGING_CONFIGURATION_SOURCE_POLL_INTERVAL_SECONDS = 30;
+  public static final int DEFAULT_FEATURE_FLAGGING_CONFIGURATION_SOURCE_REQUEST_TIMEOUT_SECONDS =
+      2;
 
   static final boolean DEFAULT_CODE_ORIGIN_FOR_SPANS_INTERFACE_SUPPORT = false;
   static final int DEFAULT_CODE_ORIGIN_MAX_USER_FRAMES = 8;

internal-api/src/main/java/datadog/trace/api/Config.java

@@ -1222,8 +1222,8 @@ public static String getHostName() {
 
   private final String featureFlaggingConfigurationSource;
   private final String featureFlaggingConfigurationSourceAgentlessBaseUrl;
-  private final double featureFlaggingConfigurationSourcePollIntervalSeconds;
-  private final double featureFlaggingConfigurationSourceRequestTimeoutSeconds;
+  private final int featureFlaggingConfigurationSourcePollIntervalSeconds;
+  private final int featureFlaggingConfigurationSourceRequestTimeoutSeconds;
 
   private final boolean dbmInjectSqlBaseHash;
   private final String dbmPropagationMode;
@@ -2855,11 +2855,11 @@ PROFILING_DATADOG_PROFILER_ENABLED, isDatadogProfilerSafeInCurrentEnvironment())
         configProvider.getStringNotEmpty(
             FEATURE_FLAGS_CONFIGURATION_SOURCE_AGENTLESS_BASE_URL, null);
     featureFlaggingConfigurationSourcePollIntervalSeconds =
-        configProvider.getDouble(
+        configProvider.getInteger(
             FEATURE_FLAGS_CONFIGURATION_SOURCE_AGENTLESS_POLL_INTERVAL_SECONDS,
             DEFAULT_FEATURE_FLAGGING_CONFIGURATION_SOURCE_POLL_INTERVAL_SECONDS);
     featureFlaggingConfigurationSourceRequestTimeoutSeconds =
-        configProvider.getDouble(
+        configProvider.getInteger(
             FEATURE_FLAGS_CONFIGURATION_SOURCE_AGENTLESS_REQUEST_TIMEOUT_SECONDS,
             DEFAULT_FEATURE_FLAGGING_CONFIGURATION_SOURCE_REQUEST_TIMEOUT_SECONDS);
 
@@ -4698,11 +4698,11 @@ public String getFeatureFlaggingConfigurationSourceAgentlessBaseUrl() {
     return featureFlaggingConfigurationSourceAgentlessBaseUrl;
   }
 
-  public double getFeatureFlaggingConfigurationSourcePollIntervalSeconds() {
+  public int getFeatureFlaggingConfigurationSourcePollIntervalSeconds() {
     return featureFlaggingConfigurationSourcePollIntervalSeconds;
   }
 
-  public double getFeatureFlaggingConfigurationSourceRequestTimeoutSeconds() {
+  public int getFeatureFlaggingConfigurationSourceRequestTimeoutSeconds() {
     return featureFlaggingConfigurationSourceRequestTimeoutSeconds;
   }
 

metadata/supported-configurations.json

@@ -1516,15 +1516,15 @@
     "DD_FEATURE_FLAGS_CONFIGURATION_SOURCE_AGENTLESS_POLL_INTERVAL_SECONDS": [
       {
         "version": "A",
-        "type": "decimal",
+        "type": "int",
         "default": "30",
         "aliases": []
       }
     ],
     "DD_FEATURE_FLAGS_CONFIGURATION_SOURCE_AGENTLESS_REQUEST_TIMEOUT_SECONDS": [
       {
         "version": "A",
-        "type": "decimal",
+        "type": "int",
         "default": "2",
         "aliases": []
       }

products/feature-flagging/feature-flagging-lib/src/main/java/com/datadog/featureflag/AgentlessConfigurationSource.java

@@ -219,8 +219,8 @@ private static String urlEncode(final String value) {
     }
   }
 
-  static long millis(final double seconds) {
-    return Math.max(1L, Math.round(seconds * 1000));
+  static long millis(final int seconds) {
+    return Math.max(1L, seconds * 1000L);
   }
 
   interface UfcHttpClient {

products/feature-flagging/feature-flagging-lib/src/test/java/com/datadog/featureflag/AgentlessConfigurationSourceTest.java

@@ -429,10 +429,10 @@ private static Config config(final String site, final String env) {
     final Config config = mock(Config.class);
     lenient()
         .when(config.getFeatureFlaggingConfigurationSourcePollIntervalSeconds())
-        .thenReturn(30.0D);
+        .thenReturn(30);
     lenient()
         .when(config.getFeatureFlaggingConfigurationSourceRequestTimeoutSeconds())
-        .thenReturn(2.0D);
+        .thenReturn(2);
     lenient().when(config.getFeatureFlaggingConfigurationSourceAgentlessBaseUrl()).thenReturn(null);
     lenient().when(config.getApiKey()).thenReturn("test-api-key");
     lenient().when(config.getSite()).thenReturn(site);