Skip to content

Commit 95c6c74

Browse files
committed
Add appId and stack trace
1 parent c02607d commit 95c6c74

2 files changed

Lines changed: 4 additions & 0 deletions

File tree

dd-java-agent/instrumentation/spark/spark-common/src/main/java/datadog/trace/instrumentation/spark/AbstractSparkInstrumentation.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,8 @@ public static void exit(@Advice.Thrown Throwable throwable) {
106106
if (AbstractDatadogSparkListener.listener != null) {
107107
AbstractDatadogSparkListener.listener.finishApplication(
108108
System.currentTimeMillis(), throwable, 0, null);
109+
} else {
110+
SparkLauncherAdvice.finishSpanWithThrowable(throwable);
109111
}
110112
}
111113
}

dd-java-agent/instrumentation/spark/spark-common/src/main/java/datadog/trace/instrumentation/spark/SparkLauncherAdvice.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ public void stateChanged(SparkAppHandle handle) {
171171
String appId = handle.getAppId();
172172
if (appId != null) {
173173
span.setTag("spark.app_id", appId);
174+
span.setTag("app_id", appId);
174175
}
175176

176177
if (state.isFinal()) {
@@ -192,6 +193,7 @@ public void infoChanged(SparkAppHandle handle) {
192193
String appId = handle.getAppId();
193194
if (appId != null) {
194195
span.setTag("spark.app_id", appId);
196+
span.setTag("app_id", appId);
195197
}
196198
}
197199
}

0 commit comments

Comments
 (0)