Address internal review feedback

- Remove exporterIsConfiguredWithCumulativeTemporalityForCounters
  test (tested OTel SDK, not our code; the integration test is the
  real regression guard)
- Fix Provider catch block comment to reflect that FlagEvalMetrics
  may not have logged if we reach this point
- Include exception in log.error calls for NoClassDefFoundError and
  general Exception to aid debugging
- Reword InMemoryMetricReader comment for precision

Author: typotter

products/feature-flagging/feature-flagging-api/src/main/java/datadog/trace/api/openfeature/FlagEvalMetrics.java

@@ -85,11 +85,12 @@ class FlagEvalMetrics implements Closeable {
       log.error(
           "Evaluation logging is enabled but OpenTelemetry SDK is not on the classpath. "
               + "Add opentelemetry-sdk-metrics and opentelemetry-exporter-otlp to your dependencies, "
-              + "or disable evaluation logging via Provider.Options.evaluationLogging(false).");
+              + "or disable evaluation logging via Provider.Options.evaluationLogging(false).",
+          e);
       counter = null;
       meterProvider = null;
     } catch (Exception e) {
-      log.error("Failed to initialize flag evaluation metrics: {}", e.getMessage());
+      log.error("Failed to initialize flag evaluation metrics", e);
       counter = null;
       meterProvider = null;
     }

products/feature-flagging/feature-flagging-api/src/main/java/datadog/trace/api/openfeature/Provider.java

@@ -49,7 +49,7 @@ public Provider(final Options options) {
         metrics = new FlagEvalMetrics();
         hook = new FlagEvalHook(metrics);
       } catch (NoClassDefFoundError | Exception e) {
-        // FlagEvalMetrics logs the error — degrade to no-op
+        // Fallback: FlagEvalMetrics constructor threw unexpectedly — degrade to no-op
       }
     }
     this.flagEvalMetrics = metrics;

products/feature-flagging/feature-flagging-api/src/test/java/datadog/trace/api/openfeature/FlagEvalMetricsTest.java

@@ -9,13 +9,10 @@
 import dev.openfeature.sdk.ErrorCode;
 import io.opentelemetry.api.common.Attributes;
 import io.opentelemetry.api.metrics.LongCounter;
-import io.opentelemetry.exporter.otlp.http.metrics.OtlpHttpMetricExporter;
-import io.opentelemetry.sdk.metrics.InstrumentType;
 import io.opentelemetry.sdk.metrics.SdkMeterProvider;
 import io.opentelemetry.sdk.metrics.data.AggregationTemporality;
 import io.opentelemetry.sdk.metrics.data.LongPointData;
 import io.opentelemetry.sdk.metrics.data.MetricData;
-import io.opentelemetry.sdk.metrics.export.AggregationTemporalitySelector;
 import io.opentelemetry.sdk.testing.exporter.InMemoryMetricReader;
 import java.util.Collection;
 import org.junit.jupiter.api.Test;
@@ -147,26 +144,11 @@ void shutdownClearsCounter() {
     verifyNoInteractions(counter);
   }
 
-  @Test
-  void exporterIsConfiguredWithCumulativeTemporalityForCounters() {
-    // Regression guard: FlagEvalMetrics must explicitly configure alwaysCumulative() so that
-    // the Datadog agent receives absolute counts rather than delta values that may be converted
-    // to rates. This test documents and enforces that the exporter uses CUMULATIVE for counters.
-    try (OtlpHttpMetricExporter exporter =
-        OtlpHttpMetricExporter.builder()
-            .setAggregationTemporalitySelector(AggregationTemporalitySelector.alwaysCumulative())
-            .build()) {
-      assertEquals(
-          AggregationTemporality.CUMULATIVE,
-          exporter.getAggregationTemporality(InstrumentType.COUNTER),
-          "alwaysCumulative() selector must produce CUMULATIVE for counters");
-    }
-  }
-
   @Test
   void multipleRecordCallsAccumulateCumulativelyInExportedMetrics() {
-    // Use InMemoryMetricReader with cumulative temporality (matching what FlagEvalMetrics
-    // configures on the OTLP exporter) to verify that N record() calls produce a sum of N.
+    // InMemoryMetricReader defaults to cumulative temporality. This validates that N record()
+    // calls produce a cumulative sum of N, matching the alwaysCumulative() selector configured
+    // on the production OTLP exporter in FlagEvalMetrics.
     InMemoryMetricReader reader = InMemoryMetricReader.create();
     SdkMeterProvider provider = SdkMeterProvider.builder().registerMetricReader(reader).build();