Review feedback: avoid cast exception if span.kind set to non-string value

mcculls · mcculls · commit 97b5fc9e3d60 · 2026-04-17T19:54:02.000+01:00
diff --git a/dd-trace-core/src/main/java/datadog/trace/core/otlp/trace/OtlpTraceProto.java b/dd-trace-core/src/main/java/datadog/trace/core/otlp/trace/OtlpTraceProto.java
@@ -126,7 +126,7 @@ public static byte[] recordSpanMessage(
     }
 
     writeTag(buf, 6, VARINT_WIRE_TYPE);
-    writeVarInt(buf, spanKind((CharSequence) span.getTag(SPAN_KIND)));
+    writeVarInt(buf, spanKind(span.context().getSpanKindString()));
 
     writeTag(buf, 7, I64_WIRE_TYPE);
     writeI64(buf, span.getStartTime());

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ public static byte[] recordSpanMessage(`
`126`	`126`	`}`
`127`	`127`
`128`	`128`	`writeTag(buf, 6, VARINT_WIRE_TYPE);`
`129`		`- writeVarInt(buf, spanKind((CharSequence) span.getTag(SPAN_KIND)));`
	`129`	`+ writeVarInt(buf, spanKind(span.context().getSpanKindString()));`
`130`	`130`
`131`	`131`	`writeTag(buf, 7, I64_WIRE_TYPE);`
`132`	`132`	`writeI64(buf, span.getStartTime());`