Skip to content

Commit 9983d0e

Browse files
Increase HikariCP connection timeout in JDBC tests to reduce flakiness. (#10760)
Increase HikariCP connection timeout in JDBC tests to reduce flakiness. Fixed tests. Merge branch 'master' into alexeyk/hikary-timeout-fix Co-authored-by: alexey.kuznetsov <alexey.kuznetsov@datadoghq.com>
1 parent 10d731c commit 9983d0e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

dd-java-agent/instrumentation/jdbc/src/test/groovy/JDBCInstrumentationTestBase.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ abstract class JDBCInstrumentationTest extends VersionedNamingTestBase {
135135
config.addDataSourceProperty("prepStmtCacheSize", "250")
136136
config.addDataSourceProperty("prepStmtCacheSqlLimit", "2048")
137137
config.setMaximumPoolSize(1)
138-
config.setConnectionTimeout(1000)
138+
config.setConnectionTimeout(5000)
139139

140140
return new HikariDataSource(config)
141141
}
@@ -948,7 +948,7 @@ abstract class JDBCInstrumentationTest extends VersionedNamingTestBase {
948948
connectionPoolName | exhaustPoolForMillis | expectException
949949
"hikari" | 500 | false
950950
"dbcp2" | 500 | false
951-
"hikari" | 1500 | true
951+
"hikari" | 6000 | true
952952
"dbcp2" | 1500 | true
953953
}
954954

0 commit comments

Comments
 (0)