Skip to content

Commit 9bd2b86

Browse files
committed
Add assertion to ensure latestDepTest dependencies are different from test.
1 parent b3cdb28 commit 9bd2b86

25 files changed

Lines changed: 73 additions & 149 deletions

File tree

dd-java-agent/instrumentation/aws-java-sdk-1.11.0/aws-java-sdk-1.11.0.gradle

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -95,13 +95,6 @@ configurations.test_1_11_106Compile {
9595
}
9696
}
9797

98-
configurations.latestDepTestCompile {
99-
resolutionStrategy {
100-
force group: 'com.amazonaws', name: 'aws-java-sdk', version: '+'
101-
}
102-
}
103-
104-
10598
dependencies {
10699
compileOnly group: 'com.amazonaws', name: 'aws-java-sdk-core', version: '1.11.0'
107100

dd-java-agent/instrumentation/datastax-cassandra-2.3/datastax-cassandra-2.3.gradle

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,6 @@ dependencies {
3636
testCompile project(':dd-java-agent:testing')
3737
testCompile group: 'com.datastax.cassandra', name: 'cassandra-driver-core', version: '3.2.0'
3838
testCompile group: 'org.cassandraunit', name: 'cassandra-unit', version: '3.1.3.2'
39-
}
4039

41-
configurations.latestDepTestCompile {
42-
resolutionStrategy {
43-
force group: 'com.datastax.cassandra', name: 'cassandra-driver-core', version: '+'
44-
}
40+
latestDepTestCompile group: 'com.datastax.cassandra', name: 'cassandra-driver-core', version: '+'
4541
}

dd-java-agent/instrumentation/grpc-1.5/grpc-1.5.gradle

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,7 @@ dependencies {
6060
testCompile group: 'io.grpc', name: 'grpc-stub', version: grpcVersion
6161

6262
latestDepTestCompile sourceSets.test.output // include the protobuf generated classes
63-
}
64-
65-
configurations.latestDepTestCompile {
66-
resolutionStrategy {
67-
force group: 'io.grpc', name: 'grpc-netty', version: '+'
68-
force group: 'io.grpc', name: 'grpc-protobuf', version: '+'
69-
force group: 'io.grpc', name: 'grpc-stub', version: '+'
70-
}
63+
latestDepTestCompile group: 'io.grpc', name: 'grpc-netty', version: '+'
64+
latestDepTestCompile group: 'io.grpc', name: 'grpc-protobuf', version: '+'
65+
latestDepTestCompile group: 'io.grpc', name: 'grpc-stub', version: '+'
7166
}

dd-java-agent/instrumentation/hystrix-1.4/hystrix-1.4.gradle

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@ dependencies {
3232
testCompile project(':dd-java-agent:instrumentation:java-concurrent')
3333
testCompile project(':dd-java-agent:instrumentation:trace-annotation')
3434
testCompile group: 'com.netflix.hystrix', name: 'hystrix-core', version: '1.4.0'
35-
}
3635

37-
configurations.latestDepTestCompile {
38-
resolutionStrategy {
39-
force group: 'com.netflix.hystrix', name: 'hystrix-core', version: '+'
40-
}
36+
latestDepTestCompile group: 'com.netflix.hystrix', name: 'hystrix-core', version: '+'
4137
}

dd-java-agent/instrumentation/jdbc/jdbc.gradle

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,13 @@ dependencies {
3333
testCompile group: 'org.apache.tomcat', name: 'tomcat-juli', version: '7.0.19'
3434
testCompile group: 'com.zaxxer', name: 'HikariCP', version: '2.4.0'
3535
testCompile group: 'com.mchange', name: 'c3p0', version: '0.9.5'
36-
}
37-
38-
configurations.latestDepTestCompile {
39-
resolutionStrategy {
40-
force group: 'com.h2database', name: 'h2', version: '+'
41-
force group: 'org.apache.derby', name: 'derby', version: '+'
42-
force group: 'org.hsqldb', name: 'hsqldb', version: '+'
43-
44-
force group: 'org.apache.tomcat', name: 'tomcat-jdbc', version: '+'
45-
force group: 'org.apache.tomcat', name: 'tomcat-juli', version: '+'
46-
force group: 'com.zaxxer', name: 'HikariCP', version: '+'
47-
force group: 'com.mchange', name: 'c3p0', version: '+'
48-
}
36+
37+
latestDepTestCompile group: 'com.h2database', name: 'h2', version: '+'
38+
latestDepTestCompile group: 'org.apache.derby', name: 'derby', version: '+'
39+
latestDepTestCompile group: 'org.hsqldb', name: 'hsqldb', version: '+'
40+
41+
latestDepTestCompile group: 'org.apache.tomcat', name: 'tomcat-jdbc', version: '+'
42+
latestDepTestCompile group: 'org.apache.tomcat', name: 'tomcat-juli', version: '+'
43+
latestDepTestCompile group: 'com.zaxxer', name: 'HikariCP', version: '+'
44+
latestDepTestCompile group: 'com.mchange', name: 'c3p0', version: '+'
4945
}

dd-java-agent/instrumentation/jedis-1.4/jedis-1.4.gradle

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,3 @@ dependencies {
3333

3434
latestDepTestCompile group: 'redis.clients', name: 'jedis', version: '+'
3535
}
36-
37-
configurations.latestDepTestCompile {
38-
resolutionStrategy {
39-
force group: 'redis.clients', name: 'jedis', version: '+'
40-
}
41-
}

dd-java-agent/instrumentation/jetty-8/jetty-8.gradle

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,9 @@ dependencies {
3333
}
3434
testCompile group: 'org.eclipse.jetty', name: 'jetty-server', version: '8.0.0.v20110901'
3535
testCompile group: 'org.eclipse.jetty', name: 'jetty-servlet', version: '8.0.0.v20110901'
36-
}
36+
testCompile group: 'org.eclipse.jetty', name: 'jetty-continuation', version: '8.0.0.v20110901'
3737

38-
configurations.latestDepTestCompile {
39-
resolutionStrategy {
40-
force group: 'org.eclipse.jetty', name: 'jetty-server', version: '+'
41-
force group: 'org.eclipse.jetty', name: 'jetty-servlet', version: '+'
42-
}
38+
latestDepTestCompile group: 'org.eclipse.jetty', name: 'jetty-server', version: '+'
39+
latestDepTestCompile group: 'org.eclipse.jetty', name: 'jetty-servlet', version: '+'
40+
latestDepTestCompile group: 'org.eclipse.jetty', name: 'jetty-continuation', version: '+'
4341
}

dd-java-agent/instrumentation/jetty-8/src/main/java/datadog/trace/instrumentation/jetty8/HandlerInstrumentation.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
@AutoService(Instrumenter.class)
1818
public final class HandlerInstrumentation extends Instrumenter.Default {
19-
public static final String SERVLET_OPERATION_NAME = "jetty.request";
2019

2120
public HandlerInstrumentation() {
2221
super("jetty", "jetty-8");

dd-java-agent/instrumentation/jetty-8/src/test/groovy/JettyHandlerTest.groovy

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,14 +80,13 @@ class JettyHandlerTest extends AgentTestRunner {
8080
tags.size() == 10
8181
}
8282

83-
8483
def "handler instrumentation clears state after async request"() {
8584
setup:
8685
Handler handler = new AbstractHandler() {
8786
@Override
8887
void handle(String target, Request baseRequest, HttpServletRequest request, HttpServletResponse response) throws IOException, ServletException {
8988
final Continuation continuation = ContinuationSupport.getContinuation(request)
90-
continuation.suspend()
89+
continuation.suspend(response)
9190
// By the way, this is a terrible async server
9291
new Thread() {
9392
@Override

dd-java-agent/instrumentation/jsp-2.3/jsp-2.3.gradle

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,10 @@ dependencies {
3838
testCompile group: 'org.apache.tomcat.embed', name: 'tomcat-embed-core', version: '7.0.37'
3939
testCompile group: 'org.apache.tomcat.embed', name: 'tomcat-embed-logging-juli', version: '7.0.37'
4040
testCompile group: 'org.apache.tomcat.embed', name: 'tomcat-embed-jasper', version: '7.0.37'
41-
}
4241

43-
configurations.latestDepTestCompile {
44-
resolutionStrategy {
45-
force group: 'javax.servlet.jsp', name: 'javax.servlet.jsp-api', version: '+'
46-
force group: 'javax.servlet', name: 'javax.servlet-api', version: '+'
47-
force group: 'org.apache.tomcat.embed', name: 'tomcat-embed-core', version: '+'
48-
force group: 'org.apache.tomcat.embed', name: 'tomcat-embed-jasper', version: '+'
49-
force group: 'org.apache.tomcat.embed', name: 'tomcat-embed-logging-juli', version: '+'
50-
}
42+
latestDepTestCompile group: 'javax.servlet.jsp', name: 'javax.servlet.jsp-api', version: '+'
43+
latestDepTestCompile group: 'javax.servlet', name: 'javax.servlet-api', version: '+'
44+
latestDepTestCompile group: 'org.apache.tomcat.embed', name: 'tomcat-embed-core', version: '+'
45+
latestDepTestCompile group: 'org.apache.tomcat.embed', name: 'tomcat-embed-jasper', version: '+'
46+
latestDepTestCompile group: 'org.apache.tomcat.embed', name: 'tomcat-embed-logging-juli', version: '+'
5147
}

0 commit comments

Comments
 (0)