Skip to content

Commit a1a2a0d

Browse files
committed
Improve naming for instrumentation class.
1 parent 513cded commit a1a2a0d

1 file changed

Lines changed: 44 additions & 46 deletions

File tree

dd-java-agent/instrumentation/kafka-streams-0.11/src/main/java/datadog/trace/instrumentation/kafka_streams/KafkaStreamsSourceNodeRecordDeserializerInstrumentation.java

Lines changed: 44 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -17,56 +17,54 @@
1717
import org.apache.kafka.common.record.TimestampType;
1818

1919
// This is necessary because SourceNodeRecordDeserializer drops the headers. :-(
20-
public class KafkaStreamsSourceNodeRecordDeserializerInstrumentation {
20+
@AutoService(Instrumenter.class)
21+
public class KafkaStreamsSourceNodeRecordDeserializerInstrumentation
22+
extends Instrumenter.Configurable {
2123

22-
@AutoService(Instrumenter.class)
23-
public static class StartInstrumentation extends Instrumenter.Configurable {
24-
25-
public StartInstrumentation() {
26-
super("kafka", "kafka-streams");
27-
}
24+
public KafkaStreamsSourceNodeRecordDeserializerInstrumentation() {
25+
super("kafka", "kafka-streams");
26+
}
2827

29-
@Override
30-
public AgentBuilder apply(final AgentBuilder agentBuilder) {
31-
return agentBuilder
32-
.type(
33-
named("org.apache.kafka.streams.processor.internals.SourceNodeRecordDeserializer"),
34-
classLoaderHasClasses("org.apache.kafka.streams.state.internals.KeyValueIterators"))
35-
.transform(DDTransformers.defaultTransformers())
36-
.transform(
37-
DDAdvice.create()
38-
.advice(
39-
isMethod()
40-
.and(isPublic())
41-
.and(named("deserialize"))
42-
.and(
43-
takesArgument(
44-
0, named("org.apache.kafka.clients.consumer.ConsumerRecord")))
45-
.and(returns(named("org.apache.kafka.clients.consumer.ConsumerRecord"))),
46-
SaveHeadersAdvice.class.getName()))
47-
.asDecorator();
48-
}
28+
@Override
29+
public AgentBuilder apply(final AgentBuilder agentBuilder) {
30+
return agentBuilder
31+
.type(
32+
named("org.apache.kafka.streams.processor.internals.SourceNodeRecordDeserializer"),
33+
classLoaderHasClasses("org.apache.kafka.streams.state.internals.KeyValueIterators"))
34+
.transform(DDTransformers.defaultTransformers())
35+
.transform(
36+
DDAdvice.create()
37+
.advice(
38+
isMethod()
39+
.and(isPublic())
40+
.and(named("deserialize"))
41+
.and(
42+
takesArgument(
43+
0, named("org.apache.kafka.clients.consumer.ConsumerRecord")))
44+
.and(returns(named("org.apache.kafka.clients.consumer.ConsumerRecord"))),
45+
SaveHeadersAdvice.class.getName()))
46+
.asDecorator();
47+
}
4948

50-
public static class SaveHeadersAdvice {
49+
public static class SaveHeadersAdvice {
5150

52-
@Advice.OnMethodExit(suppress = Throwable.class)
53-
public static void saveHeaders(
54-
@Advice.Argument(0) final ConsumerRecord incoming,
55-
@Advice.Return(readOnly = false) ConsumerRecord result) {
56-
result =
57-
new ConsumerRecord<>(
58-
result.topic(),
59-
result.partition(),
60-
result.offset(),
61-
result.timestamp(),
62-
TimestampType.CREATE_TIME,
63-
result.checksum(),
64-
result.serializedKeySize(),
65-
result.serializedValueSize(),
66-
result.key(),
67-
result.value(),
68-
incoming.headers());
69-
}
51+
@Advice.OnMethodExit(suppress = Throwable.class)
52+
public static void saveHeaders(
53+
@Advice.Argument(0) final ConsumerRecord incoming,
54+
@Advice.Return(readOnly = false) ConsumerRecord result) {
55+
result =
56+
new ConsumerRecord<>(
57+
result.topic(),
58+
result.partition(),
59+
result.offset(),
60+
result.timestamp(),
61+
TimestampType.CREATE_TIME,
62+
result.checksum(),
63+
result.serializedKeySize(),
64+
result.serializedValueSize(),
65+
result.key(),
66+
result.value(),
67+
incoming.headers());
7068
}
7169
}
7270
}

0 commit comments

Comments
 (0)