Skip to content

Commit aec809e

Browse files
Reverted test code.
1 parent d341b7c commit aec809e

4 files changed

Lines changed: 47 additions & 46 deletions

File tree

.gitlab-ci.yml

Lines changed: 42 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ variables:
3131
GRADLE_PLUGIN_PROXY: "https://depot-read-api-java.us1.ddbuild.io/magicmirror/magicmirror/@current/"
3232
BUILDER_IMAGE_VERSION_PREFIX: "v26.02-" # use either an empty string (e.g. "") for latest images or a version followed by a hyphen (e.g. "v25.05-")
3333
REPO_NOTIFICATION_CHANNEL: "#apm-java-escalations"
34-
DEFAULT_TEST_JVMS: /^(8|21|ibm8)$/ # the latest "stable" version is 26
34+
DEFAULT_TEST_JVMS: /^(8|11|17|21|25|stable)$/ # the latest "stable" version is 26
3535
PROFILE_TESTS:
3636
description: "Enable profiling of tests"
3737
value: "false"
@@ -468,17 +468,17 @@ check_build_src:
468468
variables:
469469
GRADLE_TARGET: ":buildSrc:build"
470470

471-
# check_base:
472-
# extends: .check_job
473-
# variables:
474-
# GRADLE_TARGET: ":baseCheck"
475-
#
476-
# check_inst:
477-
# extends: .check_job
478-
# parallel: 4
479-
# variables:
480-
# GRADLE_TARGET: ":instrumentationCheck"
481-
# CACHE_TYPE: "inst"
471+
check_base:
472+
extends: .check_job
473+
variables:
474+
GRADLE_TARGET: ":baseCheck"
475+
476+
check_inst:
477+
extends: .check_job
478+
parallel: 4
479+
variables:
480+
GRADLE_TARGET: ":instrumentationCheck"
481+
CACHE_TYPE: "inst"
482482

483483
check_smoke:
484484
extends: .check_job
@@ -670,36 +670,36 @@ agent_integration_tests:
670670
DD_HOSTNAME: "local-agent"
671671
DD_API_KEY: "invalid_key_but_this_is_fine"
672672

673-
# test_base:
674-
# extends: .test_job
675-
# variables:
676-
# GRADLE_TARGET: ":baseTest"
677-
# CACHE_TYPE: "base"
678-
# parallel:
679-
# matrix: *test_matrix_4
680-
# script:
681-
# - if [ "$testJvm" == "8" ]; then export GRADLE_PARAMS="-PskipFlakyTests -PcheckCoverage"; fi
682-
# - !reference [.test_job, script]
683-
684-
# test_inst:
685-
# extends: .test_job_with_test_agent
686-
# variables:
687-
# GRADLE_TARGET: ":instrumentationTest"
688-
# CACHE_TYPE: "inst"
689-
# parallel:
690-
# matrix: *test_matrix_8
691-
#
692-
# test_inst_latest:
693-
# extends: .test_job_with_test_agent
694-
# variables:
695-
# GRADLE_TARGET: ":instrumentationLatestDepTest"
696-
# CACHE_TYPE: "latestdep"
697-
# parallel:
698-
# matrix:
699-
# - testJvm: ["8", "17", "21", "25"] # the latest "stable" version is LTS v25
700-
# # Gitlab doesn't support "parallel" and "parallel:matrix" at the same time
701-
# # This emulates "parallel" by including it in the matrix
702-
# CI_SPLIT: [ "1/6", "2/6", "3/6", "4/6", "5/6", "6/6"]
673+
test_base:
674+
extends: .test_job
675+
variables:
676+
GRADLE_TARGET: ":baseTest"
677+
CACHE_TYPE: "base"
678+
parallel:
679+
matrix: *test_matrix_4
680+
script:
681+
- if [ "$testJvm" == "8" ]; then export GRADLE_PARAMS="-PskipFlakyTests -PcheckCoverage"; fi
682+
- !reference [.test_job, script]
683+
684+
test_inst:
685+
extends: .test_job_with_test_agent
686+
variables:
687+
GRADLE_TARGET: ":instrumentationTest"
688+
CACHE_TYPE: "inst"
689+
parallel:
690+
matrix: *test_matrix_8
691+
692+
test_inst_latest:
693+
extends: .test_job_with_test_agent
694+
variables:
695+
GRADLE_TARGET: ":instrumentationLatestDepTest"
696+
CACHE_TYPE: "latestdep"
697+
parallel:
698+
matrix:
699+
- testJvm: ["8", "17", "21", "25"] # the latest "stable" version is LTS v25
700+
# Gitlab doesn't support "parallel" and "parallel:matrix" at the same time
701+
# This emulates "parallel" by including it in the matrix
702+
CI_SPLIT: [ "1/6", "2/6", "3/6", "4/6", "5/6", "6/6"]
703703

704704
test_flaky:
705705
extends: .test_job_with_test_agent

dd-smoke-tests/concurrent/java-21/src/test/groovy/datadog/smoketest/concurrent/AbstractConcurrentTest.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ abstract class AbstractConcurrentTest extends AbstractSmokeTest {
6565
}
6666

6767
protected void receivedCorrectTrace() {
68-
waitForTrace(freezePoll, checkTrace())
68+
waitForTrace(defaultPoll, checkTrace())
6969
assert traceCount.get() == 1
7070
assert testedProcess.waitFor(TIMEOUT_SECS, SECONDS)
7171
assert testedProcess.exitValue() == 0

dd-smoke-tests/concurrent/java-21/src/test/groovy/datadog/smoketest/concurrent/VirtualThreadTest.groovy

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
11
package datadog.smoketest.concurrent
22

3+
import datadog.trace.test.util.Flaky
4+
35
class VirtualThreadStartTest extends AbstractConcurrentTest {
46
@Override
57
protected List<String> getTestArguments() {
68
return ['virtualThreadStart']
79
}
810

11+
@Flaky("Sometimes fails on CI with: Condition not satisfied after 30.00 seconds and 31 attempts")
912
def 'test Thread.startVirtualThread() runnable'() {
1013
expect:
1114
receivedCorrectTrace()
@@ -54,6 +57,7 @@ class VirtualThreadSubmitRunnableTest extends AbstractConcurrentTest {
5457
return ['virtualThreadSubmitRunnable']
5558
}
5659

60+
@Flaky("Sometimes fails on CI with: Condition not satisfied after 30.00 seconds and 31 attempts")
5761
def 'test VirtualThread submit runnable'() {
5862
expect:
5963
receivedCorrectTrace()

dd-smoke-tests/src/main/groovy/datadog/smoketest/AbstractSmokeTest.groovy

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,6 @@ abstract class AbstractSmokeTest extends ProcessManager {
6868
@Shared
6969
protected final PollingConditions defaultPoll = new PollingConditions(timeout: 30, initialDelay: 0, delay: 1, factor: 1)
7070

71-
@Shared
72-
protected final PollingConditions freezePoll = new PollingConditions(timeout: 1260, initialDelay: 0, delay: 5, factor: 2)
73-
7471
@Shared
7572
@AutoCleanup
7673
protected TestHttpServer server = httpServer {

0 commit comments

Comments
 (0)