Skip to content

Commit b065fc3

Browse files
authored
Identify remaining final field mutations (#12039)
Identify remaining final field mutations Co-authored-by: sarah.chen <sarah.chen@datadoghq.com>
1 parent 983a0be commit b065fc3

5 files changed

Lines changed: 5 additions & 5 deletions

File tree

dd-java-agent/agent-debugger/debugger-bootstrap/src/test/java/datadog/trace/bootstrap/debugger/util/RedactionTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ private static void setFieldInConfig(Config config, String fieldName, Object val
7474
try {
7575
Field field = config.getClass().getDeclaredField(fieldName);
7676
field.setAccessible(true);
77-
field.set(config, value);
77+
field.set(config, value); // TODO: JEP 500 - avoid mutating final fields
7878
} catch (Throwable e) {
7979
e.printStackTrace();
8080
}

dd-java-agent/agent-debugger/debugger-el/src/test/java/com/datadog/debugger/el/TestHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ public static void setFieldInConfig(Config config, String fieldName, Object valu
88
try {
99
Field field = config.getClass().getDeclaredField(fieldName);
1010
field.setAccessible(true);
11-
field.set(config, value);
11+
field.set(config, value); // TODO: JEP 500 - avoid mutating final fields
1212
} catch (Throwable e) {
1313
e.printStackTrace();
1414
}

dd-java-agent/agent-debugger/src/test/java/utils/TestHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public static void setFieldInConfig(Object target, String fieldName, Object valu
2828
try {
2929
Field field = target.getClass().getDeclaredField(fieldName);
3030
field.setAccessible(true);
31-
field.set(target, value);
31+
field.set(target, value); // TODO: JEP 500 - avoid mutating final fields
3232
} catch (Throwable e) {
3333
e.printStackTrace();
3434
}

dd-java-agent/agent-profiling/profiling-uploader/src/test/java/com/datadog/profiling/uploader/ProfileUploaderTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -644,7 +644,7 @@ public void testSyncDoesNotStayBlocked() throws Exception {
644644
// will always fail first on socket timeouts.
645645
Field fld = ProfileUploader.class.getDeclaredField("uploadTimeout");
646646
fld.setAccessible(true);
647-
fld.set(uploader, Duration.ofSeconds(1));
647+
fld.set(uploader, Duration.ofSeconds(1)); // TODO: JEP 500 - avoid mutating final fields
648648
// ---
649649

650650
server.enqueue(new MockResponse().setSocketPolicy(SocketPolicy.STALL_SOCKET_AT_START));

dd-java-agent/instrumentation/openai-java/openai-java-3.0/src/test/groovy/OpenAiTest.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -477,7 +477,7 @@ Alice Johnson majors in mathematics at UCLA.""")
477477

478478
def toolsField = params._body().class.getDeclaredField("tools")
479479
toolsField.accessible = true
480-
toolsField.set(params._body(), rawTools)
480+
toolsField.set(params._body(), rawTools) // TODO: JEP 500 - avoid mutating final fields
481481

482482
params
483483
}

0 commit comments

Comments
 (0)