Remove dead catch block from MultipartContentDecoder.decodeBytes

With CodingErrorAction.REPLACE the decoder never throws
CharacterCodingException, making the catch branch unreachable.

Author: jandro996

internal-api/src/main/java/datadog/trace/api/http/MultipartContentDecoder.java

@@ -1,7 +1,6 @@
 package datadog.trace.api.http;
 
 import java.nio.ByteBuffer;
-import java.nio.charset.CharacterCodingException;
 import java.nio.charset.Charset;
 import java.nio.charset.CodingErrorAction;
 
@@ -11,16 +10,12 @@ public final class MultipartContentDecoder {
   public static String decodeBytes(byte[] buf, int length, String contentType) {
     Charset charset = extractCharset(contentType);
     if (charset == null) charset = Charset.defaultCharset();
-    try {
-      return charset
-          .newDecoder()
-          .onMalformedInput(CodingErrorAction.REPLACE)
-          .onUnmappableCharacter(CodingErrorAction.REPLACE)
-          .decode(ByteBuffer.wrap(buf, 0, length))
-          .toString();
-    } catch (CharacterCodingException e) {
-      return new String(buf, 0, length, Charset.defaultCharset());
-    }
+    return charset
+        .newDecoder()
+        .onMalformedInput(CodingErrorAction.REPLACE)
+        .onUnmappableCharacter(CodingErrorAction.REPLACE)
+        .decode(ByteBuffer.wrap(buf, 0, length))
+        .toString();
   }
 
   public static Charset extractCharset(String contentType) {

internal-api/src/test/java/datadog/trace/api/http/MultipartContentDecoderTest.java

@@ -3,7 +3,6 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNull;
 
-import java.nio.charset.Charset;
 import java.nio.charset.StandardCharsets;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
@@ -56,13 +55,6 @@ void decodeBytesReturnsEmptyStringForZeroLength() {
     assertEquals("", MultipartContentDecoder.decodeBytes(new byte[16], 0, null));
   }
 
-  @Test
-  void decodeBytesUsesMachineDefaultFallbackWhenBytesCannotBeDecoded() {
-    byte[] bytes = "café".getBytes(StandardCharsets.ISO_8859_1);
-    String expected = new String(bytes, Charset.defaultCharset());
-    assertEquals(expected, MultipartContentDecoder.decodeBytes(bytes, bytes.length, null));
-  }
-
   @Test
   void decodeBytesReplacesMalformedBytesWithReplacementCharacterUsingDeclaredCharset() {
     // 0xE9 (ISO-8859-1 'é') is not valid UTF-8; REPLACE substitutes U+FFFD