error type and error message

Author: aboitreaud

dd-java-agent/instrumentation/spark/spark-common/src/main/java/datadog/trace/instrumentation/spark/SparkLauncherAdvice.java

@@ -111,14 +111,15 @@ public static synchronized void createLauncherSpan(Object launcher) {
     }
   }
 
-  public static synchronized void finishSpan(boolean isError, String errorType) {
+  public static synchronized void finishSpan(boolean isError, String errorMessage) {
     AgentSpan span = launcherSpan;
     if (span == null) {
       return;
     }
     if (isError) {
       span.setError(true);
-      span.setTag(DDTags.ERROR_TYPE, errorType);
+      span.setTag(DDTags.ERROR_TYPE, "Spark Launcher Failed");
+      span.setTag(DDTags.ERROR_MSG, errorMessage);
     }
     span.finish();
     launcherSpan = null;
@@ -176,7 +177,7 @@ public void stateChanged(SparkAppHandle handle) {
           if (state == SparkAppHandle.State.FAILED
               || state == SparkAppHandle.State.KILLED
               || state == SparkAppHandle.State.LOST) {
-            finishSpan(true, "Spark Application " + state);
+            finishSpan(true, "Application " + state);
           } else {
             finishSpan(false, null);
           }

dd-java-agent/instrumentation/spark/spark-common/src/test/groovy/datadog/trace/instrumentation/spark/SparkLauncherTest.groovy

@@ -160,7 +160,8 @@ class SparkLauncherTest extends InstrumentationSpecification {
           operationName "spark.launcher.launch"
           spanType "spark"
           errored true
-          assert span.tags["error.type"] == "Spark Application FAILED"
+          assert span.tags["error.type"] == "Spark Launcher Failed"
+          assert span.tags["error.msg"] == "Application FAILED"
           assert span.tags["spark.app_id"] == "app-456"
         }
       }